Use mojo typemaps to simplify arc::IntentFilter::IntentFilter() (context: https://codereview.chromium.org/2498223002/)
Yoshiki, could you also work on this (and crbug.com/665723 )? I think you're more familiar with mojo typemaps than I am.
sure!
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6d90e3c056d091756ae21d32a85c843350310878 commit 6d90e3c056d091756ae21d32a85c843350310878 Author: yoshiki <yoshiki@chromium.org> Date: Tue Dec 06 08:33:48 2016 Use mojo typemaps to simplify arc::IntentFilter::IntentFilter() BUG= 665719 Review-Url: https://codereview.chromium.org/2511883003 Cr-Commit-Position: refs/heads/master@{#436545} [add] https://crrev.com/6d90e3c056d091756ae21d32a85c843350310878/components/arc/common/intent_helper.typemap [modify] https://crrev.com/6d90e3c056d091756ae21d32a85c843350310878/components/arc/common/typemaps.gni [add] https://crrev.com/6d90e3c056d091756ae21d32a85c843350310878/components/arc/intent_helper/OWNERS [modify] https://crrev.com/6d90e3c056d091756ae21d32a85c843350310878/components/arc/intent_helper/arc_intent_helper_bridge.cc [modify] https://crrev.com/6d90e3c056d091756ae21d32a85c843350310878/components/arc/intent_helper/arc_intent_helper_bridge.h [modify] https://crrev.com/6d90e3c056d091756ae21d32a85c843350310878/components/arc/intent_helper/arc_intent_helper_bridge_unittest.cc [modify] https://crrev.com/6d90e3c056d091756ae21d32a85c843350310878/components/arc/intent_helper/intent_filter.cc [modify] https://crrev.com/6d90e3c056d091756ae21d32a85c843350310878/components/arc/intent_helper/intent_filter.h [add] https://crrev.com/6d90e3c056d091756ae21d32a85c843350310878/components/arc/intent_helper/intent_filter_struct_traits.cc [add] https://crrev.com/6d90e3c056d091756ae21d32a85c843350310878/components/arc/intent_helper/intent_filter_struct_traits.h [modify] https://crrev.com/6d90e3c056d091756ae21d32a85c843350310878/components/arc/intent_helper/intent_filter_unittest.cc [modify] https://crrev.com/6d90e3c056d091756ae21d32a85c843350310878/components/arc/intent_helper/local_activity_resolver.cc [modify] https://crrev.com/6d90e3c056d091756ae21d32a85c843350310878/components/arc/intent_helper/local_activity_resolver.h [modify] https://crrev.com/6d90e3c056d091756ae21d32a85c843350310878/components/arc/intent_helper/local_activity_resolver_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cbcd7bf6139fb6b95e65b28497ea3c24c8b76f2e commit cbcd7bf6139fb6b95e65b28497ea3c24c8b76f2e Author: tkent <tkent@chromium.org> Date: Tue Dec 06 08:59:22 2016 Revert of Use mojo typemaps to simplify arc::IntentFilter::IntentFilter() (patchset #3 id:180001 of https://codereview.chromium.org/2511883003/ ) Reason for revert: Build failure on Linux ChromiumOS Builder (dbg). https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Builder%20(dbg)/builds/81360 Original issue's description: > Use mojo typemaps to simplify arc::IntentFilter::IntentFilter() > > BUG= 665719 > > Committed: https://crrev.com/6d90e3c056d091756ae21d32a85c843350310878 > Cr-Commit-Position: refs/heads/master@{#436545} TBR=yusukes@chromium.org,lhchavez@chromium.org,djacobo@chromium.org,hidehiko@chromium.org,dcheng@chromium.org,yoshiki@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= 665719 Review-Url: https://codereview.chromium.org/2557703002 Cr-Commit-Position: refs/heads/master@{#436546} [delete] https://crrev.com/6d90e3c056d091756ae21d32a85c843350310878/components/arc/common/intent_helper.typemap [modify] https://crrev.com/cbcd7bf6139fb6b95e65b28497ea3c24c8b76f2e/components/arc/common/typemaps.gni [delete] https://crrev.com/6d90e3c056d091756ae21d32a85c843350310878/components/arc/intent_helper/OWNERS [modify] https://crrev.com/cbcd7bf6139fb6b95e65b28497ea3c24c8b76f2e/components/arc/intent_helper/arc_intent_helper_bridge.cc [modify] https://crrev.com/cbcd7bf6139fb6b95e65b28497ea3c24c8b76f2e/components/arc/intent_helper/arc_intent_helper_bridge.h [modify] https://crrev.com/cbcd7bf6139fb6b95e65b28497ea3c24c8b76f2e/components/arc/intent_helper/arc_intent_helper_bridge_unittest.cc [modify] https://crrev.com/cbcd7bf6139fb6b95e65b28497ea3c24c8b76f2e/components/arc/intent_helper/intent_filter.cc [modify] https://crrev.com/cbcd7bf6139fb6b95e65b28497ea3c24c8b76f2e/components/arc/intent_helper/intent_filter.h [delete] https://crrev.com/6d90e3c056d091756ae21d32a85c843350310878/components/arc/intent_helper/intent_filter_struct_traits.cc [delete] https://crrev.com/6d90e3c056d091756ae21d32a85c843350310878/components/arc/intent_helper/intent_filter_struct_traits.h [modify] https://crrev.com/cbcd7bf6139fb6b95e65b28497ea3c24c8b76f2e/components/arc/intent_helper/intent_filter_unittest.cc [modify] https://crrev.com/cbcd7bf6139fb6b95e65b28497ea3c24c8b76f2e/components/arc/intent_helper/local_activity_resolver.cc [modify] https://crrev.com/cbcd7bf6139fb6b95e65b28497ea3c24c8b76f2e/components/arc/intent_helper/local_activity_resolver.h [modify] https://crrev.com/cbcd7bf6139fb6b95e65b28497ea3c24c8b76f2e/components/arc/intent_helper/local_activity_resolver_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a931c678447eacaacac9ebf26373b8b853b236a6 commit a931c678447eacaacac9ebf26373b8b853b236a6 Author: yoshiki <yoshiki@chromium.org> Date: Wed Dec 14 07:23:47 2016 Use mojo typemaps to simplify arc::IntentFilter::IntentFilter() (reland) This patch is the reland of https://crrev.com/6d90e3c056 on the latest tot. The previous patch was reverted due to conflict and build failure. BUG= 665719 R=yusukes@chromium.org, lhchavez@chromium.org TBR=dcheng@chromium.org # TBRing since no changes in IPC-related code from the previous patch Review-Url: https://codereview.chromium.org/2556463003 Cr-Commit-Position: refs/heads/master@{#438450} [add] https://crrev.com/a931c678447eacaacac9ebf26373b8b853b236a6/components/arc/common/intent_helper.typemap [modify] https://crrev.com/a931c678447eacaacac9ebf26373b8b853b236a6/components/arc/common/typemaps.gni [add] https://crrev.com/a931c678447eacaacac9ebf26373b8b853b236a6/components/arc/intent_helper/OWNERS [modify] https://crrev.com/a931c678447eacaacac9ebf26373b8b853b236a6/components/arc/intent_helper/arc_intent_helper_bridge.cc [modify] https://crrev.com/a931c678447eacaacac9ebf26373b8b853b236a6/components/arc/intent_helper/arc_intent_helper_bridge.h [modify] https://crrev.com/a931c678447eacaacac9ebf26373b8b853b236a6/components/arc/intent_helper/arc_intent_helper_bridge_unittest.cc [modify] https://crrev.com/a931c678447eacaacac9ebf26373b8b853b236a6/components/arc/intent_helper/intent_filter.cc [modify] https://crrev.com/a931c678447eacaacac9ebf26373b8b853b236a6/components/arc/intent_helper/intent_filter.h [add] https://crrev.com/a931c678447eacaacac9ebf26373b8b853b236a6/components/arc/intent_helper/intent_filter_struct_traits.cc [add] https://crrev.com/a931c678447eacaacac9ebf26373b8b853b236a6/components/arc/intent_helper/intent_filter_struct_traits.h [modify] https://crrev.com/a931c678447eacaacac9ebf26373b8b853b236a6/components/arc/intent_helper/intent_filter_unittest.cc [modify] https://crrev.com/a931c678447eacaacac9ebf26373b8b853b236a6/components/arc/intent_helper/local_activity_resolver.cc [modify] https://crrev.com/a931c678447eacaacac9ebf26373b8b853b236a6/components/arc/intent_helper/local_activity_resolver.h [modify] https://crrev.com/a931c678447eacaacac9ebf26373b8b853b236a6/components/arc/intent_helper/local_activity_resolver_unittest.cc
The tree looks keeping green finally.
Comment 1 by yusukes@chromium.org
, Nov 17 2016