New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 665708 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Feature



Sign in to add a comment

Clearly show bot restarts in Sheriff-o-matic

Project Member Reported by suzyh@chromium.org, Nov 16 2016

Issue description

I spent a while chasing down some purple bots today to discover that there had been a master restart an hour previously. It would be very helpful to have this info clearly displayed in Sheriff-o-matic.
 
Cc: seanmccullough@chromium.org stip@chromium.org
Labels: Milestone-Workflow
Status: Available (was: Untriaged)
Which master was this?

stip: what's the best way to detect a master restart? Poll for changes in /infradata/master-manager/+log/master/desired_master_state.json?

I guess we could also display something about any upcoming scheduled restarts too, before they even begin.


Comment 2 by suzyh@chromium.org, Nov 16 2016

dsansome had pointed me to https://chrome-internal.googlesource.com/infradata/master-manager/+/67e5596e471cc805f66c156de0e70b2c55076010
and said there had been a master restart ("master manager action") at 18:39:10 MTV time.

I'm not entirely sure whether that link is the change corresponding to the quoted timestamp .. timezones are hard.
I've definitely seen this request before, certainly worth adding.
Labels: -Pri-3 Pri-1
Cc: -seanmccullough@chromium.org
Owner: seanmccullough@chromium.org
Status: Started (was: Available)

Comment 6 by benhenry@google.com, Nov 23 2016

Labels: cit-pm-7
Status: Fixed (was: Started)
This will go out in tomorrow's weekly release.
Project Member

Comment 10 by bugdroid1@chromium.org, Nov 29 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra.git/+/81bba5647c33bc1c9f7b619c961dc513e60ea80f

commit 81bba5647c33bc1c9f7b619c961dc513e60ea80f
Author: Sean McCullough <seanmccullough@chromium.org>
Date: Tue Nov 29 00:37:27 2016

[som] Show all pending and recent master restarts on /trooper

BUG= 665708 

Change-Id: Ia025fb5be148b43856bd0dd2108ce85458a13209
Reviewed-on: https://chromium-review.googlesource.com/414231
Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Reviewed-by: Tiffany Zhang <zhangtiff@chromium.org>
Commit-Queue: Sean McCullough <seanmccullough@chromium.org>

[modify] https://crrev.com/81bba5647c33bc1c9f7b619c961dc513e60ea80f/go/src/infra/appengine/sheriff-o-matic/som/alerts.go

Sign in to add a comment