New issue
Advanced search Search tips

Issue 665705 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Dec 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug

Blocking:
issue 614589



Sign in to add a comment

MD Settings: About: Channel information is incorrect and UI is non functional

Reported by joelleem...@gmail.com, Nov 16 2016

Issue description

My Chromebook's channel is on the beta channel, But the material design sees
that the channel is in the stable channel.

(See the photo attached.)

 
The Channel Confusion.png
152 KB View Download
Blocking: 614589
Cc: steve...@chromium.org michae...@chromium.org
Components: UI>Browser>AboutBox
Labels: OS-Chrome
Owner: steve...@chromium.org
Labels: M-56

Comment 4 by dbeam@chromium.org, Nov 21 2016

Cc: -steve...@chromium.org dpa...@chromium.org
Status: Assigned (was: Unconfirmed)
Status: Started (was: Assigned)
Labels: -Pri-2 Pri-1
This is pretty bad, we should get this in to 56.

Owner: dpa...@chromium.org
Status: Assigned (was: Started)
dpapad@ - Can you take a look at this one? I don't see any reason to suspect that this is cros specific. The relationship between settings-about-page and settings-detailed-build-info is a little involved. It is not clear to me how the channel info in settings-detailed-build-info is intended to be updated.

Owner: steve...@chromium.org
@stevenjb: This is CrOS specific because the channel switcher dialog only exists on ChromeOS. The channel is populated with a simple call to the about page's C++ handler, see [1] and [2]

[1] https://cs.chromium.org/chromium/src/chrome/browser/resources/settings/about_page/channel_switcher_dialog.js?q=channel_switcher_dialog.js&sq=package:chromium&dr&l=49,52
[2] https://cs.chromium.org/chromium/src/chrome/browser/ui/webui/settings/about_handler.cc?l=350

I am not able to repro locally (but I am also not using a real ChromeOS device on beta, just faking the data that is coming from C++, and using CrOS build for Linux)

Should be fairly simple to debug if you have a CrOS device on beta. Re-assigning back, and feel free to ping me for help.
Labels: -M-56 M-57
Summary: MD Settings: About: Channel information is incorrect and UI is non functional (was: The Chromium OS Channel Confusion)
OK, my plate is lightening, I will look into this.

Status: Started (was: Assigned)
Project Member

Comment 11 by bugdroid1@chromium.org, Dec 8 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9d01f7a426ca85db9b12a4db69f9bd63efb89dcd

commit 9d01f7a426ca85db9b12a4db69f9bd63efb89dcd
Author: stevenjb <stevenjb@chromium.org>
Date: Thu Dec 08 01:46:40 2016

Settings: About: Fix cros channel info.

BUG= 665705 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2538043006
Cr-Commit-Position: refs/heads/master@{#437125}

[modify] https://crrev.com/9d01f7a426ca85db9b12a4db69f9bd63efb89dcd/chrome/browser/resources/settings/about_page/about_page.js
[modify] https://crrev.com/9d01f7a426ca85db9b12a4db69f9bd63efb89dcd/chrome/browser/resources/settings/about_page/about_page_browser_proxy.js
[modify] https://crrev.com/9d01f7a426ca85db9b12a4db69f9bd63efb89dcd/chrome/browser/resources/settings/about_page/channel_switcher_dialog.js
[modify] https://crrev.com/9d01f7a426ca85db9b12a4db69f9bd63efb89dcd/chrome/browser/resources/settings/about_page/compiled_resources2.gyp
[modify] https://crrev.com/9d01f7a426ca85db9b12a4db69f9bd63efb89dcd/chrome/browser/resources/settings/about_page/detailed_build_info.html
[modify] https://crrev.com/9d01f7a426ca85db9b12a4db69f9bd63efb89dcd/chrome/browser/resources/settings/about_page/detailed_build_info.js
[modify] https://crrev.com/9d01f7a426ca85db9b12a4db69f9bd63efb89dcd/chrome/browser/ui/webui/settings/about_handler.cc
[modify] https://crrev.com/9d01f7a426ca85db9b12a4db69f9bd63efb89dcd/chrome/browser/ui/webui/settings/about_handler.h
[modify] https://crrev.com/9d01f7a426ca85db9b12a4db69f9bd63efb89dcd/chrome/test/data/webui/settings/about_page_tests.js

Status: Fixed (was: Started)
Thanks!
Status: Verified (was: Fixed)

Sign in to add a comment