New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 665700 link

Starred by 1 user
Status: Fixed
Owner:
█ tsergeant@chromium.org
Not on Chrome
Closed: Jan 2017
Cc:
rdevlin....@chromium.org
bettes@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug



Sign in to add a comment

MD WebUI: Migrate MD Extensions to <cr-toolbar>, delete <cr-search-field>

Project Member Reported by tsergeant@chromium.org, Nov 16 2016 
MD Extensions is the only remaining UI which uses the <cr-search-field> element. This element causes some difficulties in the API for <cr-toolbar>, so it is desirable to be able to delete it.

Comment 1 by tsergeant@chromium.org, Nov 16 2016 

Screenshots of <cr-toolbar> in MD Extensions.
extensions_full.png
99 KB View Download
extensions_thin.png
96.1 KB View Download
extensions_search.png
39.1 KB View Download

Comment 2 by tsergeant@chromium.org, Nov 16 2016

Cc: rdevlin....@chromium.org bettes@chromium.org
+bettes: Do the screenshots above match the desired toolbar appearance for Extensions?

+rdevlin.cronin as FYI

Comment 3 by tsergeant@chromium.org, Nov 29 2016 

A couple more screenshots now that I've changed the width of the sidebar.
extensions_toolbar_1.png
108 KB View Download
extensions_toolbar_2.png
98.2 KB View Download
Project Member

Comment 5 by bugdroid1@chromium.org, Dec 14 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a4f6b5562dcab9cc11d8d0381022bc85a40277da

commit a4f6b5562dcab9cc11d8d0381022bc85a40277da
Author: tsergeant <tsergeant@chromium.org>
Date: Wed Dec 14 04:22:02 2016

MD WebUI: Delete cr-search-field, simplify CrSearchFieldBehavior

<cr-search-field> is currently unused and can be deleted. Once it is
removed, <cr-toolbar-search-field> is the only client of the behavior
which needs the show/hide functionality. This CL moves that
functionality into <cr-toolbar-search-field>, simplifying
CrSearchFieldBehavior to be general utilities for search fields.

BUG= 665700 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2571583004
Cr-Commit-Position: refs/heads/master@{#438430}

[modify] https://crrev.com/a4f6b5562dcab9cc11d8d0381022bc85a40277da/chrome/browser/resources/md_downloads/crisper.js
[modify] https://crrev.com/a4f6b5562dcab9cc11d8d0381022bc85a40277da/chrome/browser/resources/md_downloads/vulcanized.html
[modify] https://crrev.com/a4f6b5562dcab9cc11d8d0381022bc85a40277da/chrome/browser/resources/md_history/app.crisper.js
[modify] https://crrev.com/a4f6b5562dcab9cc11d8d0381022bc85a40277da/chrome/browser/resources/md_history/app.vulcanized.html
[modify] https://crrev.com/a4f6b5562dcab9cc11d8d0381022bc85a40277da/ui/webui/resources/cr_elements/cr_search_field/compiled_resources2.gyp
[delete] https://crrev.com/805cb4f37639e3e8bc32c6789aba465453463048/ui/webui/resources/cr_elements/cr_search_field/cr_search_field.css
[delete] https://crrev.com/805cb4f37639e3e8bc32c6789aba465453463048/ui/webui/resources/cr_elements/cr_search_field/cr_search_field.html
[delete] https://crrev.com/805cb4f37639e3e8bc32c6789aba465453463048/ui/webui/resources/cr_elements/cr_search_field/cr_search_field.js
[modify] https://crrev.com/a4f6b5562dcab9cc11d8d0381022bc85a40277da/ui/webui/resources/cr_elements/cr_search_field/cr_search_field_behavior.js
[modify] https://crrev.com/a4f6b5562dcab9cc11d8d0381022bc85a40277da/ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar_search_field.html
[modify] https://crrev.com/a4f6b5562dcab9cc11d8d0381022bc85a40277da/ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar_search_field.js
[modify] https://crrev.com/a4f6b5562dcab9cc11d8d0381022bc85a40277da/ui/webui/resources/cr_elements_resources.grdp
Project Member

Comment 6 by bugdroid1@chromium.org, Dec 20 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/abaa208feeda5799c50d802f2ebc5e8b81aa00b2

commit abaa208feeda5799c50d802f2ebc5e8b81aa00b2
Author: tsergeant <tsergeant@chromium.org>
Date: Tue Dec 20 04:54:00 2016

MD WebUI: Simplify cr-toolbar CSS

This removes a number of CSS mixins which allowed almost all parts of
the toolbar to be changed. Instead, this adds better support to the
toolbar for having an action button on the right side of the element,
and migrates History and Downloads to use it.

BUG= 665700 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2562393003
Cr-Commit-Position: refs/heads/master@{#439710}

[modify] https://crrev.com/abaa208feeda5799c50d802f2ebc5e8b81aa00b2/chrome/browser/resources/md_downloads/toolbar.html
[modify] https://crrev.com/abaa208feeda5799c50d802f2ebc5e8b81aa00b2/chrome/browser/resources/md_downloads/vulcanized.html
[modify] https://crrev.com/abaa208feeda5799c50d802f2ebc5e8b81aa00b2/chrome/browser/resources/md_history/app.vulcanized.html
[modify] https://crrev.com/abaa208feeda5799c50d802f2ebc5e8b81aa00b2/chrome/browser/resources/md_history/history_toolbar.html
[modify] https://crrev.com/abaa208feeda5799c50d802f2ebc5e8b81aa00b2/chrome/browser/resources/md_history/lazy_load.vulcanized.html
[modify] https://crrev.com/abaa208feeda5799c50d802f2ebc5e8b81aa00b2/ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar.html
Project Member

Comment 7 by bugdroid1@chromium.org, Jan 19 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d69fa965ea7ddc2e61c7701a6b209c1d5f8bccda

commit d69fa965ea7ddc2e61c7701a6b209c1d5f8bccda
Author: tsergeant <tsergeant@chromium.org>
Date: Thu Jan 19 01:00:44 2017

MD Settings: Fix label visibility in subpage search fields

In crrev.com/438430, CrSearchFieldBehavior was simplified, removing
compatibility with iron-input. However, iron-input was still used by
<settings-subpage-search> to control the visibility of the input field
label.

This CL adds a public 'hasSearchText' property to the common search
field behavior which does not require iron-input to compute. This allows
<settings-subpage-search> to remove its dependency on iron-input, while
also fixing two minor issues:
- The input field label on <settings-subpage-search> now reappears when
  the 'clear search' button is clicked.
- The search icon in <cr-toolbar-search-field> now appears unfocused
  when the search field is cleared while it is unfocused.

BUG= 665700 , 665307 , 634665 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2586803002
Cr-Commit-Position: refs/heads/master@{#444578}

[modify] https://crrev.com/d69fa965ea7ddc2e61c7701a6b209c1d5f8bccda/chrome/browser/resources/md_downloads/crisper.js
[modify] https://crrev.com/d69fa965ea7ddc2e61c7701a6b209c1d5f8bccda/chrome/browser/resources/md_downloads/vulcanized.html
[modify] https://crrev.com/d69fa965ea7ddc2e61c7701a6b209c1d5f8bccda/chrome/browser/resources/md_history/app.crisper.js
[modify] https://crrev.com/d69fa965ea7ddc2e61c7701a6b209c1d5f8bccda/chrome/browser/resources/md_history/app.vulcanized.html
[modify] https://crrev.com/d69fa965ea7ddc2e61c7701a6b209c1d5f8bccda/chrome/browser/resources/settings/settings_page/settings_subpage_search.html
[modify] https://crrev.com/d69fa965ea7ddc2e61c7701a6b209c1d5f8bccda/chrome/test/data/webui/cr_elements/cr_toolbar_search_field_tests.js
[modify] https://crrev.com/d69fa965ea7ddc2e61c7701a6b209c1d5f8bccda/ui/webui/resources/cr_elements/cr_search_field/cr_search_field_behavior.js
[modify] https://crrev.com/d69fa965ea7ddc2e61c7701a6b209c1d5f8bccda/ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar_search_field.html
[modify] https://crrev.com/d69fa965ea7ddc2e61c7701a6b209c1d5f8bccda/ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar_search_field.js

Comment 8 by tsergeant@chromium.org, Jan 19 2017

Status: Fixed (was: Started)
At this stage, I'm going to mark this as fixed. <cr-search-field> is entirely gone, <cr-toolbar> has had some edges shaved off, and CrSearchFieldBehavior still exists with a small but useful purpose.
►

Sign in to add a comment