Regression : Focus is not fully seen in Network tab after capuring screenshot in DevTools |
||||||||||||||
Issue descriptionVersion: 56.0.2920.0 dev OS: Ubuntu 14.04 What steps will reproduce the problem? (1)Launch Chrome and go to chrome://chrome-signin page. (2)Press F12 to open devtools -> Go to 'Network' tab and select 'capture screenshot' option -> hit F5 to capture screenshot.(Refer attached screencast) (3)Now observe the focus on the waterfall tab. Expected: Focus should be fully seen on Waterfall tab. Actual: Instead Focus is not fully seen. This is a regression issue broken in M56. Manual Bisect Range: ======================== Good build: 56.0.2919.0 Bad build: 56.0.2920.0
,
Nov 16 2016
Issue is seen on Mac OS canary version: 56.0.2920.0 as well.
,
Nov 16 2016
,
Nov 16 2016
Thanks for the report and screencasts. @allada: this looks related to the new canvas implementation, could you please take a look?
,
Nov 16 2016
,
Nov 16 2016
Using the per-revision bisect providing the bisect results, Good build: 56.0.2919.0 (Revision:431801) Bad build: 56.0.2920.0 (Revision:432057) You are probably looking for a change made after 431940 (known good), but no later than 431941 (first known bad). CHANGELOG URL: The script might not always return single CL as suspect as some perf builds might get missing due to failure. https://chromium.googlesource.com/chromium/src/+log/3cbd8cf73b549a6856627d48fda6ed464df7e83c..a40ed9ed4f1f62df4505c40fc65891ac8896d7d4 From the CL above, suspecting the owner @allada - Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner. Review-Url: https://codereview.chromium.org/2497373002 Thanks!
,
Nov 18 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a5cad337d45510b109937cf71a8a928d3a8022b9 commit a5cad337d45510b109937cf71a8a928d3a8022b9 Author: allada <allada@chromium.org> Date: Fri Nov 18 20:24:52 2016 [Devtools] Fixed bug on hover waterfall in network panel This patch fixes a bug with the header of waterfall column in network panel was clipping the arrow and hiding the times in the header. See: http://imgur.com/a/7rP4E R=dgozman BUG= 665697 Review-Url: https://codereview.chromium.org/2513753002 Cr-Commit-Position: refs/heads/master@{#433290} [modify] https://crrev.com/a5cad337d45510b109937cf71a8a928d3a8022b9/third_party/WebKit/Source/devtools/front_end/network/networkLogView.css
,
Nov 28 2016
Just for update, Still able to reproduce the issue on Ubuntu 14.04,Win 10.0 using latest chrome version 57.0.2935.0. allada@ Could you please look into this issue. Thanks!
,
Nov 29 2016
I cannot reproduce, can you please do another screen capture?
,
Dec 19 2016
Tested in chrome latest canary #57.0.2956.0 on Ubuntu 14.04,Win 10.0 & Mac 10.12.2 and not able to reproduce the issue.Please find the screen shot for reference. @susanjunia : Could you please re-check once and confirm. Thanks!
,
Jan 2 2017
Issue no more seen on win10 chrome version 57.0.2969.0 allada@, Could you please merge this to M56 if no more work is pending.
,
Jan 5 2017
,
Jan 5 2017
,
Jan 5 2017
Your change meets the bar and is auto-approved for M56. Please go ahead and merge the CL manually. Please contact milestone owner if you have questions. Owners: amineer@(clank), cmasso@(bling), gkihumba@(cros), bustamante@(desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jan 5 2017
,
Jan 5 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c84f978a29d920265974dc8320693f495a8c0c26 commit c84f978a29d920265974dc8320693f495a8c0c26 Author: allada <allada@chromium.org> Date: Thu Jan 05 03:05:53 2017 [Devtools] Fixed bug on hover waterfall in network panel This patch fixes a bug with the header of waterfall column in network panel was clipping the arrow and hiding the times in the header. See: http://imgur.com/a/7rP4E R=dgozman BUG= 665697 NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2513753002 Cr-Commit-Position: refs/heads/master@{#433290} (cherry picked from commit a5cad337d45510b109937cf71a8a928d3a8022b9) Review-Url: https://codereview.chromium.org/2611093002 Cr-Commit-Position: refs/branch-heads/2924@{#676} Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059} [modify] https://crrev.com/c84f978a29d920265974dc8320693f495a8c0c26/third_party/WebKit/Source/devtools/front_end/network/networkLogView.css
,
Jan 11 2017
Verified on Mac OS 10.12.2 , windows 10 , ubuntu 14.04 using chrome M56 #56.0.2924.59 and issue is fixed. Focus is fully seen in Network tab after capuring screenshot in DevTools . Attached sreenshot for reference. Adding TE-Verified Labels. Thanks! |
||||||||||||||
►
Sign in to add a comment |
||||||||||||||
Comment 1 by susanjun...@techmahindra.com
, Nov 16 2016