New issue
Advanced search Search tips

Issue 665676 link

Starred by 1 user
Status: WontFix
Owner:
yosin@chromium.org
Closed: May 2017
Cc:
hayato@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 3
Type: Task



Sign in to add a comment

We should have ContainerNode version of Node::checkSlotChangeBeforeRemoved() for nodeChildrenWIllBeRemoved()

Project Member Reported by yosin@chromium.org, Nov 16 2016 
Node::checkSlotChangeBeforeRemoved() is called for all child nodes in 
Document::nodeChildrenWIllBeRemoved(). It takes time if there are too many
child nodes.

We should have ContainerNode::checkSLotChangeBeforeRemoved() to avoid
iterating over all child nodes.

Comment 1 by dtapu...@chromium.org, Nov 17 2016

Components: Blink>DOM

Comment 2 by dominicc@chromium.org, Dec 12 2016

Components: -Blink>DOM Blink>DOM>ShadowDOM
Owner: hayato@chromium.org
Status: Assigned (was: Untriaged)

Comment 3 by dominicc@chromium.org, Dec 12 2016

Cc: hayato@chromium.org
Labels: OS-Android OS-Chrome OS-Linux OS-Mac OS-Windows
Owner: yosin@chromium.org
Actually, let me assign this back to you yosin. Sounds like an interesting idea, do you have data?

Comment 4 by hayato@chromium.org, Dec 12 2016 

> We should have ContainerNode::checkSLotChangeBeforeRemoved() to avoid
> iterating over all child nodes.

yosin@, could you elaborate? How does this improve?

Comment 5 by yosin@chromium.org, Mar 25 2017

Labels: Type-Task

Comment 6 by yosin@chromium.org, May 26 2017

Status: WontFix (was: Assigned)
Mark "WontFix" since it doesn't improve performance.

Because of we need to dispatch "slotchange" event for each child of removing
container node.
►

Sign in to add a comment