Issue metadata
Sign in to add a comment
|
Duplicate text drawn on canvas with particular images
Reported by
mpariz...@pdftron.com,
Nov 16 2016
|
||||||||||||||||||||||
Issue descriptionUserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/54.0.2840.99 Safari/537.36 Steps to reproduce the problem: 1. Open attached HTML page in Chrome or go to pdftron.com/webviewer/bugdemo2 2. The word "Test" should be displayed in black near the bottom middle of the canvas. 3. However notice that in the top left corner you'll see the word "Test" written on a black background when it shouldn't be there at all. What is the expected behavior? "Test" should not appear at all in the top left corner. If you open the sample page in Firefox or IE the problem will not occur. What went wrong? It's hard to say, but it seems to be related to the text that is being drawn on the canvas and something to do with the image as well. If I change to a simpler image or remove the drawImage then the problem doesn't occur. Did this work before? N/A Does this work in other browsers? Yes Chrome version: 54.0.2840.99 Channel: stable OS Version: 10.0 Flash Version: Shockwave Flash 23.0 r0 If you refresh several times then the problem will eventually disappear. To make it happen again just open the page in a new tab.
,
Nov 16 2016
Florin, could you help diagose this? I suspect it is this change: vjiaoblack Added the framework for having canvas/recorder/picture record depth_set's. But I am not certain about it.
,
Nov 16 2016
I'm having trouble repro-ing this on Linux. Can someone with a successful repro post their chrome://gpu/ settings so I try to match?
,
Nov 16 2016
I have double checked, it is windows only. If the changes in the above skia-deps-roll is not obvious, then I can try manual builds to bisect those changes.
,
Nov 16 2016
Nothing in that range jumps out at me, +csmartdalton just in case. (note that vjiaoblack's CL was reverted in the same roll, so likely not the culprit).
,
Nov 16 2016
csmartdalton@: could you please take a look and see if there is anything obvious.
,
Nov 23 2016
FYI There's a warning that "Email to this user bounced" for csmartdalton@chromium.org
,
Nov 23 2016
Per offline discussion with csmartdalton@, his changes should be unrelated. I will investigate.
,
Nov 28 2016
junov@: could you take a look? The skia roll has 15 CLs, I have manually reverted bunch of them. The following ones I have not reverted them: Retract PipelineBuilder from GrClip::apply by robertphillips (no longer revertable on tip-of-tree) SkRasterPipeline: simplify impl and remove need to rewire stages by mtklein (no longer revertable on tip-of-tree) and the 4 CLs by csmartdalton@ because he mentioned that his change should not impact chrome.
,
Nov 28 2016
Based on the initial comments, it sounds like this could be a flaky repro. krajshree@ do you mind double-checking the bisect to make sure we're focusing on the correct range?
,
Nov 29 2016
Ran the hasbisect-per-revision again and got the same results as in comment #1. Bisect Information: ===================== Good build: 54.0.2795.0 Revision(405182) Bad Build : 54.0.2797.0 Revision(405656) Change Log URL: https://chromium.googlesource.com/chromium/src/+log/4600da1be6cc2719af18c4cbdc07101e1ba77127..a96a1fa7525f6e15a4669da14be166ec422fd9bd Form the above CL got the below Blink CL: https://chromium.googlesource.com/skia.git/+log/9199a9fef989..82945560e61f From the above change log suspecting below change Review url: https://codereview.chromium.org/2127233002 bsalomon@ - Could you please check whether this is caused with respect to vjiaoblack@ change, if not please help us in assigning it to the right owner. Note: Could not find chromium id for vjiaoblack@, hence assigned to one of his/her reviewer. Thanks...!!
,
Nov 30 2016
Issue is seen on latest canary 57.0.2937.0. bsalomon@/fmalita@ : Could you please take a look into it. Added Releaseblock-beta against M57 as its a recent regression, please modify if not appropriate.
,
Nov 30 2016
I tried to reproduce this with no success on Linux and Mac yesterday. Will try some more today.
,
Dec 1 2016
This issue is specific to Windows only.
,
Dec 1 2016
Ah, sorry for not reading this closely enough. Starting a windows build now.
,
Dec 5 2016
Friendly ping to get an update on this as per C#15.
,
Dec 5 2016
I synced back to a96a1fa7525f6e15a4669da14be166ec422fd9bd and have a repro on Windows
,
Dec 5 2016
The following revision refers to this bug: https://skia.googlesource.com/skia.git/+/fe647b2d9ae04e94f030e5ee6e0e81e88c533ca9 commit fe647b2d9ae04e94f030e5ee6e0e81e88c533ca9 Author: Brian Salomon <bsalomon@google.com> Date: Mon Dec 05 18:14:44 2016 Make flag values in GrResourceProvider and GrTextureProvider consistent BUG= chromium:665673 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=5602 Change-Id: I41522aa24cd4b4a7e085132dd9bcbfdd66bd9617 Reviewed-on: https://skia-review.googlesource.com/5602 Reviewed-by: Chris Dalton <csmartdalton@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com> [modify] https://crrev.com/fe647b2d9ae04e94f030e5ee6e0e81e88c533ca9/include/gpu/GrTextureProvider.h [modify] https://crrev.com/fe647b2d9ae04e94f030e5ee6e0e81e88c533ca9/src/gpu/GrResourceProvider.h [modify] https://crrev.com/fe647b2d9ae04e94f030e5ee6e0e81e88c533ca9/src/gpu/GrTextureProvider.cpp
,
Dec 5 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/16580f855ff7298570ca7ba9eb766e854f9e6f54 commit 16580f855ff7298570ca7ba9eb766e854f9e6f54 Author: skia-deps-roller <skia-deps-roller@chromium.org> Date: Mon Dec 05 22:42:05 2016 Roll src/third_party/skia/ 287f6512f..45565b676 (2 commits). https://skia.googlesource.com/skia.git/+log/287f6512f34d..45565b676c86 $ git log 287f6512f..45565b676 --date=short --no-merges --format='%ad %ae %s' 2016-12-05 scroggo GIF: Internal cleanup - remove color map parameter 2016-12-05 bsalomon Make flag values in GrResourceProvider and GrTextureProvider consistent BUG= 665673 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel TBR=herb@google.com Review-Url: https://codereview.chromium.org/2553883002 Cr-Commit-Position: refs/heads/master@{#436434} [modify] https://crrev.com/16580f855ff7298570ca7ba9eb766e854f9e6f54/DEPS
,
Dec 6 2016
This is a serious rendering bug with a very safe, trivial fix. Requesting a merge to M55.
,
Dec 6 2016
[Automated comment] DEPS changes referenced in bugdroid comments, needs manual review.
,
Dec 6 2016
Changing the request to M56.
,
Dec 9 2016
Verified the issue on windows 10 using chrome version #57.0.2946.0 as per comment #0 Observed that "Test" displayed in black near the bottom middle of the canvas. Hence, the fix is working as expected. Attaching screen cast for reference. Hence, adding the verified labels. Thanks...!!
,
Dec 14 2016
Cc'ing Ligi@ for help in getting this merged to M-56 as per C#22.
,
Dec 16 2016
This bug requires manual review: DEPS changes referenced in bugdroid comments. Please contact the milestone owner if you have questions. Owners: amineer@(clank), cmasso@(bling), gkihumba@(cros), bustamante@(desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Dec 19 2016
Adjusting blocker label to get into triaging bucket of M-56 and for merging the same.
,
Dec 21 2016
This change meets the bar and is approved for merge into M56
,
Dec 22 2016
The following revision refers to this bug: https://skia.googlesource.com/skia.git/+/4c1c7811cb0fb09506d039e3a2a9afc2805946b0 commit 4c1c7811cb0fb09506d039e3a2a9afc2805946b0 Author: Brian Salomon <bsalomon@google.com> Date: Thu Dec 22 14:26:29 2016 Make flag values in GrResourceProvider and GrTextureProvider consistent Cherry pick to M56 BUG= chromium:665673 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=5602 Change-Id: I41522aa24cd4b4a7e085132dd9bcbfdd66bd9617 Reviewed-on: https://skia-review.googlesource.com/5602 Reviewed-by: Chris Dalton <csmartdalton@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com> Reviewed-on: https://skia-review.googlesource.com/6411 Reviewed-by: Brian Salomon <bsalomon@google.com> [modify] https://crrev.com/4c1c7811cb0fb09506d039e3a2a9afc2805946b0/include/gpu/GrTextureProvider.h [modify] https://crrev.com/4c1c7811cb0fb09506d039e3a2a9afc2805946b0/src/gpu/GrResourceProvider.h [modify] https://crrev.com/4c1c7811cb0fb09506d039e3a2a9afc2805946b0/src/gpu/GrTextureProvider.cpp
,
Dec 22 2016
,
Dec 22 2016
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by krajshree@chromium.org
, Nov 16 2016Owner: skia-deps-roller@chromium.org
Status: Assigned (was: Unconfirmed)