Add pixel bounds to display::Display. |
|||||
Issue descriptionScreenWin is the only place that we have platform specific display - ScreenWinDisplay. ScreenWinDisplay has one additional information compared to display::Display - pixel bounds. It would make sense to update display::Display with this new information because 1) we can then get rid of ScreenWinDisplay and update ScreenWin to deal with normal display::Display 2) will most likely be useful for mustash/hi-dpi work. This came up with this CL https://codereview.chromium.org/2489873002/.
,
Nov 16 2016
You probably only need to add pixel size, not pixel bounds, but otherwise this sounds good. The origin would be something like a location in a framebuffer, if it's defined at all, and not something that clients should be aware of.
,
Nov 16 2016
The actual bounds are necessary for Windows. We have to calculate the DIP equivalent positioning ourselves to maintain a euclidean space since Windows does not do that for us. This is the primary reason for ScreenWinDisplay. We felt that other platforms didn't need this as it was a Windows specific need.
,
Nov 18 2016
,
Nov 18 2016
Not sure this is critical for M56. Removing label.
,
Nov 20 2017
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue. Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Aug 15
Ria, this would be nice to have but I don't think it's absolutely necessary anymore. I'm closing out, if you feel we should do it please reopen. |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by sadrul@chromium.org
, Nov 16 2016Status: Available (was: Untriaged)