Add UMA stats to Bookmark Manager |
|||||
Issue descriptionBefore implementing the new bookmark manager UI, we should add stats to the old bookmark manager to understand usage patterns and scalability issues.
,
Nov 16 2016
Per request from tbuckley@, can you also add a stat for drag-and-drop usage?
,
Nov 18 2016
There exist some stats already, but some are only on Mac (???) The plan will be to use UMA sequencing to look at BookmarkManager_StartDrag, sequenced with BookmarkManager_Drop and BookmarkBar_DragEnd to understand where bookmark manager drags are going.
,
Nov 23 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6e523087878a0b07c4781fa4b793638a3829b075 commit 6e523087878a0b07c4781fa4b793638a3829b075 Author: calamity <calamity@chromium.org> Date: Wed Nov 23 21:34:43 2016 Add bookmark bar/manager actions to track drag and drop. This CL adds UMA that will allow analysis of bookmark drag and drop source and targets. BUG= 665660 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2512903002 Cr-Commit-Position: refs/heads/master@{#434253} [modify] https://crrev.com/6e523087878a0b07c4781fa4b793638a3829b075/chrome/browser/resources/bookmark_manager/js/dnd.js [modify] https://crrev.com/6e523087878a0b07c4781fa4b793638a3829b075/chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc [modify] https://crrev.com/6e523087878a0b07c4781fa4b793638a3829b075/tools/metrics/actions/actions.xml
,
Nov 23 2016
How will we understand what is happening with a drag? Some questions I'd hope to answer with this: - are multiple items being dragged? - are dragged items changing their position in the hierarchy vs position in the list? - if changing hierarchy are they being dragged into a folder in the sidenav vs in the list area? - are they dragging into/from the bookmarks bar?
,
Nov 24 2016
- are multiple items being dragged? Needs a histogram. Straightforward (I think). - are dragged items changing their position in the hierarchy vs position in the list? Hmmm. Sort of tricky. Might be able to add a UMA action about this. I'll look into it. - if changing hierarchy are they being dragged into a folder in the sidenav vs in the list area? I can only think of hierarchy-change list drops happening by dragging from the bookmarks bar into the bookmark manager, is that what you mean? side nav vs list drops should be easy enough to log a UMA action for. - are they dragging into/from the bookmarks bar? The UMA sequence of BookmarkManager/Bar_StartDrag => BookmarkManager/Bar_EndDrag will tell us this.
,
Nov 24 2016
> I can only think of hierarchy-change list drops happening by dragging from the bookmarks bar into the bookmark manager, is that what you mean? side nav vs list drops should be easy enough to log a UMA action for. By hierarchy change I mean moving a bookmark to a different folder. This can happen entirely within the WebUI by either (1) dragging a bookmark in the list area onto a folder in the list area or (2) dragging a bookmark in the list area onto a folder in the sidenav. It'd be great to know if one is more common than the other.
,
Dec 6 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7be20a0c34d3811e658da9e932a868dddb635d80 commit 7be20a0c34d3811e658da9e932a868dddb635d80 Author: calamity <calamity@chromium.org> Date: Tue Dec 06 04:33:00 2016 Add better Bookmark Manager drag and drop stats. This CL changes the drag stats in bookmark manager to be more granular and adds a histogram to track the number of bookmarks being dragged at once. BUG= 665660 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2539363002 Cr-Commit-Position: refs/heads/master@{#436524} [modify] https://crrev.com/7be20a0c34d3811e658da9e932a868dddb635d80/chrome/browser/resources/bookmark_manager/js/dnd.js [modify] https://crrev.com/7be20a0c34d3811e658da9e932a868dddb635d80/tools/metrics/actions/actions.xml [modify] https://crrev.com/7be20a0c34d3811e658da9e932a868dddb635d80/tools/metrics/histograms/histograms.xml
,
Dec 16 2016
Stats mentioned here have been implemented. Data is available for canary but usage numbers are relatively low.
,
Dec 16 2016
Awesome, can't wait to see the stats!
,
Jan 4 2017
Reopening to add better depth-tracking stats.
,
Jan 4 2017
For reference, opening a bookmark via double-click in the bookmark manager is actually logged into Bookmarks.LaunchLocation under the bookmark manager bucket. By checking the 'Count unique users per bucket' checkbox, you can view how many users opened a bookmark for the day, and then compare it to UMA counts for StartDragFromList/Tree.
,
Jul 26 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a2233c811198ceca25212363f2098dfa2ea30b24 commit a2233c811198ceca25212363f2098dfa2ea30b24 Author: Tim Sergeant <tsergeant@chromium.org> Date: Wed Jul 26 03:02:47 2017 MD Bookmarks: Record metrics for commands and keyboard shortcuts This CL adds metrics for whenever a command is handled in the bookmark manager, breaking out keyboard shortcuts and recording them separately. Bug: 665660 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I3ddf5890f899f61e2a3b21e34436bf57819ed6bd Reviewed-on: https://chromium-review.googlesource.com/578632 Reviewed-by: Robert Kaplow <rkaplow@chromium.org> Reviewed-by: calamity <calamity@chromium.org> Commit-Queue: Tim Sergeant <tsergeant@chromium.org> Cr-Commit-Position: refs/heads/master@{#489539} [modify] https://crrev.com/a2233c811198ceca25212363f2098dfa2ea30b24/chrome/browser/resources/md_bookmarks/command_manager.js [modify] https://crrev.com/a2233c811198ceca25212363f2098dfa2ea30b24/chrome/browser/resources/md_bookmarks/constants.js [modify] https://crrev.com/a2233c811198ceca25212363f2098dfa2ea30b24/chrome/browser/resources/md_bookmarks/util.js [modify] https://crrev.com/a2233c811198ceca25212363f2098dfa2ea30b24/chrome/browser/ui/webui/md_bookmarks/md_bookmarks_ui.cc [modify] https://crrev.com/a2233c811198ceca25212363f2098dfa2ea30b24/chrome/test/data/webui/md_bookmarks/command_manager_test.js [modify] https://crrev.com/a2233c811198ceca25212363f2098dfa2ea30b24/tools/metrics/histograms/enums.xml [modify] https://crrev.com/a2233c811198ceca25212363f2098dfa2ea30b24/tools/metrics/histograms/histograms.xml
,
Jan 18 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ed17532fe3afceefa60990cec176720d610123fa commit ed17532fe3afceefa60990cec176720d610123fa Author: Christopher Lam <calamity@chromium.org> Date: Thu Jan 18 14:54:49 2018 [MD Bookmarks] Add BookmarkManager.CommandMenuOpened histogram. This CL adds a histogram to track where the bookmarks context menu was opened from. Bug: 665660 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ib32aa173d06245f2dac4c04767264ff82c627345 Reviewed-on: https://chromium-review.googlesource.com/861369 Commit-Queue: calamity <calamity@chromium.org> Reviewed-by: Tim Sergeant <tsergeant@chromium.org> Reviewed-by: Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#530141} [modify] https://crrev.com/ed17532fe3afceefa60990cec176720d610123fa/chrome/browser/resources/md_bookmarks/command_manager.js [modify] https://crrev.com/ed17532fe3afceefa60990cec176720d610123fa/chrome/browser/resources/md_bookmarks/constants.js [modify] https://crrev.com/ed17532fe3afceefa60990cec176720d610123fa/tools/metrics/histograms/enums.xml [modify] https://crrev.com/ed17532fe3afceefa60990cec176720d610123fa/tools/metrics/histograms/histograms.xml
,
Jan 18 2018
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by bugdroid1@chromium.org
, Nov 16 2016