New issue
Advanced search Search tips

Issue 665659 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug-Regression



Sign in to add a comment

DevTools crashes when starts timeline recording with v8 runtime callstats experiment.

Project Member Reported by alph@chromium.org, Nov 16 2016

Issue description

DevTools crashes when starts timeline recording with v8 runtime callstats experiment.
 

Comment 1 by alph@chromium.org, Nov 16 2016

Components: Platform>DevTools>Performance

Comment 2 by alph@chromium.org, Nov 16 2016

Cc: cbruni@chromium.org
Caused by this change https://codereview.chromium.org/2490643002
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 16 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/ca3f487979324c92f86e3ce88e8be9ac8579ecaa

commit ca3f487979324c92f86e3ce88e8be9ac8579ecaa
Author: alph <alph@chromium.org>
Date: Wed Nov 16 19:12:50 2016

[runtime stats] Fix crash after r41001

The timer can be missing in the timers stack when RCS is started dynamically.

BUG= chromium:665659 
TBR=cbruni@chromium.org

Review-Url: https://codereview.chromium.org/2505813002
Cr-Commit-Position: refs/heads/master@{#41049}

[modify] https://crrev.com/ca3f487979324c92f86e3ce88e8be9ac8579ecaa/src/counters.cc

Project Member

Comment 4 by bugdroid1@chromium.org, Nov 23 2016

Labels: merge-merged-5.6
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/81bfa2ea9e4a2ecbf10a22e265b9f27cd8e7ea02

commit 81bfa2ea9e4a2ecbf10a22e265b9f27cd8e7ea02
Author: Michael Hablich <hablich@chromium.org>
Date: Wed Nov 23 16:43:23 2016

Merged: [runtime stats] Fix crash after r41001

Revision: ca3f487979324c92f86e3ce88e8be9ac8579ecaa

BUG= chromium:665659 
LOG=N
NOTRY=true
NOPRESUBMIT=true
NOTREECHECKS=true
R=cbruni@chromium.org, alph@chromium.org

Review URL: https://codereview.chromium.org/2527463003 .

Cr-Commit-Position: refs/branch-heads/5.6@{#17}
Cr-Branched-From: bdd3886218dfe76e8560eb8a18401942452ae859-refs/heads/5.6.326@{#1}
Cr-Branched-From: 879f6599eee6e1dfcbe9a24bf688b261c03e9558-refs/heads/master@{#41014}

[modify] https://crrev.com/81bfa2ea9e4a2ecbf10a22e265b9f27cd8e7ea02/src/counters.cc

Comment 5 by alph@chromium.org, Nov 23 2016

Status: Fixed (was: Assigned)

Sign in to add a comment