New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 665657 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Nov 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

coreboot-utils fails to build with latest llvm

Project Member Reported by manojgupta@chromium.org, Nov 16 2016

Issue description

Fails to build because of the following warning.

cbfs-payload-linux.c:255:43: note: add parentheses around left hand side expression to silence this warning
if ((hdr->protocol_version >= 0x200) && (!hdr->loadflags & 1)) {



 
Description: Show this description
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 18 2016

Labels: merge-merged-chromeos-2016.05
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/coreboot/+/35c4935f2a89c3d3b45213372bcf0474a60eda43

commit 35c4935f2a89c3d3b45213372bcf0474a60eda43
Author: Manoj Gupta <manojgupta@google.com>
Date: Mon Nov 14 19:19:30 2016

Fix coreboot-utils to build with latest llvm

cbfs-payload-linux.c:255:43: note: add parentheses around left
hand side expression to silence this warning

if ((hdr->protocol_version >= 0x200) && (!hdr->loadflags & 1)) {

BUG= chromium:665657 
TEST=coreboot-utils builds

Change-Id: I8758e7d158ca32e87107797f2a33b9d9a0e4676f
Reviewed-on: https://chromium-review.googlesource.com/411335
Commit-Ready: Manoj Gupta <manojgupta@chromium.org>
Tested-by: Manoj Gupta <manojgupta@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/35c4935f2a89c3d3b45213372bcf0474a60eda43/util/cbfstool/cbfs-payload-linux.c

Status: Fixed (was: Assigned)

Comment 4 by dchan@google.com, Mar 4 2017

Labels: VerifyIn-58
Status: Verified (was: Fixed)

Sign in to add a comment