New issue
Advanced search Search tips

Issue 665649 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Feature



Sign in to add a comment

minijail should bring up loopback interface in new net namespaces by default

Project Member Reported by vapier@chromium.org, Nov 15 2016

Issue description

can't think of a reason to not always makes lo available
 
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 19 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/e92f13937b1f096c490784b492a5f83c1d4ae99f

commit e92f13937b1f096c490784b492a5f83c1d4ae99f
Author: Mike Frysinger <vapier@chromium.org>
Date: Thu Nov 17 19:47:55 2016

minijail: bring in network namespace loopback support

Changes:
7559dfe9ed16 minijail: bring up loopback interface in new net namespaces
531ec3747e71 build: pass down CC from make env

BUG= chromium:665649 
TEST=`sudo ./minijail0 -r -v -p -e /sbin/ip a s` shows loopback as up

Change-Id: I1041da97fdf14aab741c35d8c36a24ebcc6589b1
Reviewed-on: https://chromium-review.googlesource.com/412420
Commit-Ready: Mike Frysinger <vapier@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Dylan Reid <dgreid@chromium.org>

[rename] https://crrev.com/e92f13937b1f096c490784b492a5f83c1d4ae99f/chromeos-base/chromeos-minijail/chromeos-minijail-0.0.1-r1471.ebuild

Comment 2 by vapier@chromium.org, Nov 20 2016

Status: Fixed (was: Started)
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 20 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/21d455364ac7091e72bcce63f4f137daeeb765ef

commit 21d455364ac7091e72bcce63f4f137daeeb765ef
Author: Nicolas Boichat <drinkcat@chromium.org>
Date: Sun Nov 20 10:24:42 2016

Revert "minijail: bring in network namespace loopback support"

This reverts commit e92f13937b1f096c490784b492a5f83c1d4ae99f, which
appears to be causing failures in x86-mario-paladin.

BUG= chromium:665649 
BUG= chromium:667075 
TEST=x86-mario-paladin VMTest security_SandboxedServices passes.

Change-Id: Icfc559ef58dbe07843df1153425007a3c811deeb
Reviewed-on: https://chromium-review.googlesource.com/413160
Commit-Queue: Nicolas Boichat <drinkcat@chromium.org>
Commit-Queue: Sean Kau <skau@chromium.org>
Tested-by: Nicolas Boichat <drinkcat@chromium.org>
Trybot-Ready: Nicolas Boichat <drinkcat@chromium.org>
Reviewed-by: Nicolas Boichat <drinkcat@chromium.org>
Reviewed-by: Sean Kau <skau@chromium.org>

[rename] https://crrev.com/21d455364ac7091e72bcce63f4f137daeeb765ef/chromeos-base/chromeos-minijail/chromeos-minijail-0.0.1-r1470.ebuild

Status: Assigned (was: Fixed)
Fix probably broke x86-mario vmtest ( Issue 667075 ), and was reverted. Reopening.

Comment 5 by vapier@chromium.org, Nov 23 2016

there is no watchdog in the vm, so it's curious how it even passed in the first place.  maybe a weird combination of races.

updated minijail works fine for me on my actual mario device.
Project Member

Comment 6 by bugdroid1@chromium.org, Dec 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/0a157aaf3b45f79d914bf19980cb97ffce674245

commit 0a157aaf3b45f79d914bf19980cb97ffce674245
Author: Mike Frysinger <vapier@chromium.org>
Date: Thu Nov 17 19:47:55 2016

minijail: bring in network namespace loopback support [reland]

We've updated daisydog's init process to deal with failing in VMs,
so the issue raised in chromium:667075 should be fixed now.

Changes:
7559dfe9ed16 minijail: bring up loopback interface in new net namespaces
531ec3747e71 build: pass down CC from make env

BUG= chromium:665649 
BUG= chromium:667075 
TEST=`sudo ./minijail0 -r -v -p -e /sbin/ip a s` shows loopback as up

Change-Id: If8960e31b110f3a38ab2ef45810c42866ae1bfe7
Reviewed-on: https://chromium-review.googlesource.com/420383
Commit-Ready: Mike Frysinger <vapier@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Dylan Reid <dgreid@chromium.org>
Reviewed-by: Nicolas Boichat <drinkcat@chromium.org>

[rename] https://crrev.com/0a157aaf3b45f79d914bf19980cb97ffce674245/chromeos-base/chromeos-minijail/chromeos-minijail-0.0.1-r1471.ebuild

Comment 7 by vapier@chromium.org, Dec 15 2016

Status: Fixed (was: Assigned)
should be all set now

Comment 8 by dchan@google.com, Mar 4 2017

Labels: VerifyIn-58

Comment 9 by dchan@google.com, Apr 17 2017

Labels: VerifyIn-59

Comment 10 by dchan@google.com, May 30 2017

Labels: VerifyIn-60
Labels: VerifyIn-61

Comment 12 by dchan@chromium.org, Oct 14 2017

Status: Archived (was: Fixed)
Components: OS>Systems>Containers
Components: OS>Systems>Minijail
Status: Fixed (was: Archived)

Sign in to add a comment