adhd does not build with latest llvm |
||||
Issue descriptionLatest clang flags error when address of a member in packed structure is taken and is possibly unaligned. libcras/cras_client.c:1349:41: error: taking address of packed member 'update_count' of class or structure 'cras_server_state' may result in an unaligned pointer value [-Werror,-Waddress-of-packed-member]
,
Nov 21 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/adhd/+/28b9838811438097f3cf4445cb71b633868746e1 commit 28b9838811438097f3cf4445cb71b633868746e1 Author: Manoj Gupta <manojgupta@google.com> Date: Fri Nov 18 23:12:17 2016 Fix adhd to build with latest llvm. Clang bug https://llvm.org/bugs/show_bug.cgi?id=31050 is fixed. So remove some unnecessary pointer casts that had to be added to avoid the following warning from clang. clang error taking address of packed member 'update_count' of class or structure 'cras_server_state' may result in an unaligned pointer value [-Werror,-Waddress-of-packed-member] BUG= chromium:665647 TEST=adhd now builds with clang Change-Id: If7e09a133c4d41f9a8197b435687fd8cb756b58a Reviewed-on: https://chromium-review.googlesource.com/413052 Commit-Ready: Manoj Gupta <manojgupta@chromium.org> Tested-by: Manoj Gupta <manojgupta@chromium.org> Reviewed-by: Chinyue Chen <chinyue@chromium.org> [modify] https://crrev.com/28b9838811438097f3cf4445cb71b633868746e1/cras/src/libcras/cras_client.c [modify] https://crrev.com/28b9838811438097f3cf4445cb71b633868746e1/cras/src/server/cras_system_state.c
,
Nov 21 2016
,
Mar 4 2017
,
Mar 17 2017
|
||||
►
Sign in to add a comment |
||||
Comment 1 by bugdroid1@chromium.org
, Nov 19 2016