New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 665644 link

Starred by 1 user
Status: Verified
Owner:
lijeffrey@chromium.org
Closed: Nov 2016
Cc:
chanli@chromium.org
st...@chromium.org
█ robert...@chromium.org
lijeffrey@chromium.org
liaoyuke@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

[Findit] Refactor trigger swarming task pipelines

Project Member Reported by lijeffrey@chromium.org, Nov 15 2016 
trigger_swarming_task_pipeline.py and trigger_flake_swarming_task_pipeline.py should inherit from trigger_base_swarming_task_pipeline.py and corresponding unit tests cleaned up. This way error detection/handling in swarming tasks can be in 1 central location as well.

Comment 1 by lijeffrey@chromium.org, Nov 15 2016

Components: -Tools>Test>FindIt Tools>Test>FindIt>Waterfall Tools>Test>FindIt>Flakiness
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 16 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra.git/+/8f071f6aa177ac0fedc48a130bb63fa65e43f1b3

commit 8f071f6aa177ac0fedc48a130bb63fa65e43f1b3
Author: lijeffrey <lijeffrey@chromium.org>
Date: Wed Nov 16 04:08:08 2016

trigger_swarming_task_pipeline.py uses many methods that were supposed to have been refactored out into trigger_base_swarming_task_pipeline to be shared with trigger_flake_swarming_task_pipelines. This change refactors the 3 pipelines to share common code and cleans up the corresponding unit tests.

BUG= 665644 

Review-Url: https://codereview.chromium.org/2508603002

[modify] https://crrev.com/8f071f6aa177ac0fedc48a130bb63fa65e43f1b3/appengine/findit/model/test/wf_swarming_task_test.py
[modify] https://crrev.com/8f071f6aa177ac0fedc48a130bb63fa65e43f1b3/appengine/findit/model/wf_swarming_task.py
[add] https://crrev.com/8f071f6aa177ac0fedc48a130bb63fa65e43f1b3/appengine/findit/waterfall/test/trigger_base_swarming_task_result_pipeline_test.py
[modify] https://crrev.com/8f071f6aa177ac0fedc48a130bb63fa65e43f1b3/appengine/findit/waterfall/test/trigger_flake_swarming_task_pipeline_test.py
[modify] https://crrev.com/8f071f6aa177ac0fedc48a130bb63fa65e43f1b3/appengine/findit/waterfall/test/trigger_swarming_task_pipeline_test.py
[modify] https://crrev.com/8f071f6aa177ac0fedc48a130bb63fa65e43f1b3/appengine/findit/waterfall/trigger_flake_swarming_task_pipeline.py
[modify] https://crrev.com/8f071f6aa177ac0fedc48a130bb63fa65e43f1b3/appengine/findit/waterfall/trigger_swarming_task_pipeline.py

Comment 3 by lijeffrey@chromium.org, Nov 16 2016

Status: Verified (was: Started)
►

Sign in to add a comment