New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 665642 link

Starred by 1 user
Status: Fixed
Owner:
estevenson@chromium.org
Closed: Nov 2016
Cc:
█ xunji...@chromium.org
agrieve@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: ----



Sign in to add a comment

java_cpp_enum.py doesn't handle comments when stripped prefixes are used

Project Member Reported by estevenson@chromium.org, Nov 15 2016 
When the GENERATED_JAVA_PREFIX_TO_STRIP directive is used, comments aren't copied to the generated Java file. This happens because comment dict keys aren't updated when the stripping is completed.
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 16 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/50fea5f2ba37fc191a580b18a223c457047cda71

commit 50fea5f2ba37fc191a580b18a223c457047cda71
Author: estevenson <estevenson@chromium.org>
Date: Wed Nov 16 16:00:36 2016

Fix comment preservation in java_cpp_enum.py.

Currently, comments aren't preserved when prefix stripping is used.
This CL modifies java_cpp_enum.py to preserve comments whether or
not prefix stripping occurs.

BUG= 665642 

Review-Url: https://codereview.chromium.org/2503763004
Cr-Commit-Position: refs/heads/master@{#432504}

[modify] https://crrev.com/50fea5f2ba37fc191a580b18a223c457047cda71/build/android/gyp/java_cpp_enum.py
[modify] https://crrev.com/50fea5f2ba37fc191a580b18a223c457047cda71/build/android/gyp/java_cpp_enum_tests.py

Comment 2 Deleted

Comment 3 by amineer@chromium.org, Nov 16 2016 

[Bulk edit]

Branch issues caused these items to be erroneously tagged as merged to branch 2922, please ignore.

Comment 4 by mmoss@chromium.org, Nov 16 2016

Labels: -merge-merged-2922

Comment 5 by estevenson@chromium.org, Nov 17 2016

Status: Fixed (was: Started)
►

Sign in to add a comment