New issue
Advanced search Search tips

Issue 665634 link

Starred by 1 user
Status: WontFix
Owner: ----
Closed: Aug 14
Cc:
shuchen@chromium.org
xiy...@chromium.org
penghuang@chromium.org
sadrul@chromium.org
sky@chromium.org
mustash-bugs@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 641049



Sign in to add a comment

IME for Mash: Remove duplicate/similar mojo/cpp files

Project Member Reported by moshayedi@chromium.org, Nov 15 2016 
In mojo interfaces we have:
 - services/ui/public/interfaces/ime.mojom
 - ui/platform_window/mojo/text_input_state.mojom
 - components/arc/common/ime.mojom

In cpp files we have:
 - ui/aura/mus/input_method_mus.cc
 - ui/views/mus/input_method_mus.cc

Each two of them have some common/similar codes.

Remove unnecessary duplicates as much as possible.

Comment 1 Deleted

Comment 2 by sky@chromium.org, Jul 24 2017

Owner: e...@chromium.org

Comment 3 by e...@chromium.org, Sep 12 2017

Owner: thanhph@chromium.org
More IME bugs.

Comment 4 by lafo...@chromium.org, Feb 26 2018

Components: -Internals>MUS Internals>Services>WindowService

Comment 5 by lafo...@chromium.org, Feb 26 2018

Components: -MUS

Comment 6 by jamescook@chromium.org, Aug 14

Cc: xiy...@chromium.org shuchen@chromium.org
Components: UI>Input>Text>IME
Labels: -Proj-Mustash Proj-Mash-MultiProcess Proj-Mash-SingleProcess
Owner: ----
Status: Available (was: Assigned)
Summary: IME for Mash: Remove duplicate/similar mojo/cpp files (was: IME for Mus: Remove duplicate/similar mojo/cpp files)
xiyuan, do you know if we'll use the old IME code or the new code for SingleProcessMash?

+shuchen FYI - this might need cleanup

Comment 7 by xiy...@chromium.org, Aug 14 

The current IME support is based on old code. The mojo-based IMF is under development.

For mojo interfaces:
- components/arc/common/ime.mojom is for ARC and has a different purpose.
- services/ui/public/interfaces/ime.mojom is the current mojo interface to use
- text_input_state.mojom provides shared ime related data structure.

The don't have overlap and probably should be kept.

For C++:
we now have only one ui/aura/mus/input_method_mus.cc.

Not sure what's left  to be done for this issue.

Comment 8 by sky@chromium.org, Aug 14

Status: WontFix (was: Available)
If we don't have concrete things we want to do now, lets close this. We can file new bugs if we have things we want to do.
►

Sign in to add a comment