Issue 665603 link

Starred by 1 user

Issue metadata

Status:	Fixed
Owner:	█ jwd@chromium.org Last visit > 30 days ago
Closed:	Dec 2016
Cc:	skare@chromium.org isherman@chromium.org asvitk...@chromium.org █ rkaplow@chromium.org
Components:	Internals>Metrics
EstimatedDays:	----
NextAction:	----
OS:	All
Pri:	2
Type:	Feature
M-57

SHA1EntropyProvider should use randomization_seed.

Project Member Reported by jwd@chromium.org, Nov 15 2016

Issue description

This will make it have the same behaviour as the PermutedEntropyProvider, and will give a mechanism to allow people running variations to re-shuffle group selection.

Project Member

Comment 1 by bugdroid1@chromium.org, Nov 21 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c6e07e224e5d6cc495f8c6d86ae2741abede6b06

commit c6e07e224e5d6cc495f8c6d86ae2741abede6b06
Author: jwd <jwd@chromium.org>
Date: Mon Nov 21 16:36:54 2016

Making the SHA1 entropy provider use the randomization_seed.

BUG= 665603 

Review-Url: https://codereview.chromium.org/2503683005
Cr-Commit-Position: refs/heads/master@{#433561}

[modify] https://crrev.com/c6e07e224e5d6cc495f8c6d86ae2741abede6b06/components/variations/entropy_provider.cc
[modify] https://crrev.com/c6e07e224e5d6cc495f8c6d86ae2741abede6b06/components/variations/entropy_provider.h
[modify] https://crrev.com/c6e07e224e5d6cc495f8c6d86ae2741abede6b06/components/variations/entropy_provider_unittest.cc

Comment 2 by jwd@chromium.org, Dec 9 2016

Status: Fixed (was: Started)

Comment 3 by jwd@chromium.org, Dec 9 2016

Labels: -M-56 M-57

►

Issue 665603 link

Issue metadata

SHA1EntropyProvider should use randomization_seed.

Issue description

Comment 1 by bugdroid1@chromium.org, Nov 21 2016

Comment 1 Deleted

Comment 2 by jwd@chromium.org, Dec 9 2016

Comment 2 Deleted

Comment 3 by jwd@chromium.org, Dec 9 2016

Comment 3 Deleted

Sign in to add a comment