Looks like the analyze step is constantly failing:

https://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linux/builds/261085/steps/analyze/logs/stdio

{
  "error": "Invalid targets", 
  "invalid_targets": [
    "//chromecast/app:cast_shell_unittests", 
    "//chromecast/browser:cast_shell_browsertests"
  ]
}

Didn't mean to delete last comment, in which I've cc'd Pawel to find right person to assign this too. I am not sure who is current analyze owner.

Yeah, analyze is failing with "Error: Invalid targets". But the analyze step itself isn't turning red, and instead the error is surfacing directly inside the "steps" step. More than just the analyze step is broken here.

It looks like mb.py is exiting 0? https://cs.chromium.org/chromium/build/scripts/slave/recipe_modules/filter/api.py?q=analyze+api.py&sq=package:chromium&l=206

Maybe we can change the presentation status here: https://cs.chromium.org/chromium/build/scripts/slave/recipe_modules/filter/api.py?q=analyze+api.py&sq=package:chromium&l=223

CL: https://chromium-review.googlesource.com/411291

 Issue 665594  has been merged into this issue.

Issue 665559 has been merged into this issue.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build.git/+/78632624a04f54c12996e8d7a80a027eb4d9d9db

commit 78632624a04f54c12996e8d7a80a027eb4d9d9db
Author: Robert Iannucci <iannucci@chromium.org>
Date: Tue Nov 15 22:26:18 2016

Make analyze step actually turn red on failure

BUG= 665595 

Change-Id: I5031c59a9407e19ba2de2deafc00b478c167ac86
Reviewed-on: https://chromium-review.googlesource.com/411291
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Aaron Gable <agable@chromium.org>

[modify] https://crrev.com/78632624a04f54c12996e8d7a80a027eb4d9d9db/scripts/slave/recipe_modules/filter/api.py
[modify] https://crrev.com/78632624a04f54c12996e8d7a80a027eb4d9d9db/scripts/slave/recipe_modules/filter/example.expected/analyzes_error.json

Ok now it shows up with a failed analyze step: https://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linux/builds/261261

er, actually not

It looks the the problem might actually be fixed at HEAD now?

Ok, NOW it's showing up red: https://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linux/builds/261329

Doesn't look fixed at HEAD.

mb.py is exiting with a zero code because (arguably) it's doing what it's supposed to do. The recipe should be failing when it is getting "invalid targets" in the results.

Though I could be convinced that mb should return a 1 in this case too if that was useful.

That's fine, the recipe now makes the step red, so it should be more apparent. That said, I'm not sure who can/should fix the actual problem (e.g. there are bad targets).

(removing trooper label, cc'ing sheriffs)

I'm on it, and reverting the problematic change right now (https://codereview.chromium.org/2499563002/).

Change reverted, bot is passing the analyze step now on new builds ...