New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Starred by 0 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment
link

Issue 665593: Migrate NaCl to PolyGerrit

Reported by aga...@chromium.org, Nov 15 2016 Project Member

Issue description

Comment 1 by aga...@chromium.org, Nov 15 2016

Status: Started (was: Assigned)
I've emailed bradnelson, but have not yet received a go-ahead.

Comment 2 by aga...@chromium.org, Nov 18 2016

Cc: bradnelson@chromium.org
Got approval from bradnelson. Here are the CLs:

enable gerrit for all nacl repos: https://chromium-review.googlesource.com/#/c/412924/
enable gerrit cq for main repo: https://chromium-review.googlesource.com/#/c/412925/

Comment 3 by aga...@chromium.org, Nov 18 2016

Here's the similar CL to enable Gerrit for webports: https://chromium-review.googlesource.com/c/412963/

I also have CLs to enable the Gerrit CQ for both webports and nacl/src/nacl, and will upload those once the configuration changes have landed.

Comment 5 by bugdroid1@chromium.org, Nov 22 2016

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/native_client/src/native_client.git/+/0846b7b2d30809fd8b1cc29ff80a769fb741bc59

commit 0846b7b2d30809fd8b1cc29ff80a769fb741bc59
Author: Aaron Gable <agable@chromium.org>
Date: Fri Nov 18 23:15:51 2016

Enable Gerrit CQ for native_client

BUG= chromium:665593 

Change-Id: I1473191a3a1146da860a7309690add1058ca9988
Reviewed-on: https://chromium-review.googlesource.com/412927
Reviewed-by: Brad Nelson <bradnelson@chromium.org>

[modify] https://crrev.com/0846b7b2d30809fd8b1cc29ff80a769fb741bc59/infra/config/cq.cfg

Comment 6 by bugdroid1@chromium.org, Nov 22 2016

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7b998bc01e4af4f1309b8d1e241ccbf2fc6cdbbc

commit 7b998bc01e4af4f1309b8d1e241ccbf2fc6cdbbc
Author: nacl-deps-roller <nacl-deps-roller@chromium.org>
Date: Tue Nov 22 08:03:44 2016

Roll src/native_client/ 163dfeb43..0846b7b2d (1 commit).

https://chromium.googlesource.com/native_client/src/native_client.git/+log/163dfeb43e76..0846b7b2d308

$ git log 163dfeb43..0846b7b2d --date=short --no-merges --format='%ad %ae %s'
2016-11-18 agable Enable Gerrit CQ for native_client

BUG= 665593 

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_dbg_32_ng,linux_nacl_sdk_build
TBR=mseaborn@chromium.org

Review-Url: https://codereview.chromium.org/2521903002
Cr-Commit-Position: refs/heads/master@{#433813}

[modify] https://crrev.com/7b998bc01e4af4f1309b8d1e241ccbf2fc6cdbbc/DEPS

Comment 7 by bugdroid1@chromium.org, Nov 22 2016

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/webports/+/72409725be9b4885275b36ab4a613f5fe64193d7

commit 72409725be9b4885275b36ab4a613f5fe64193d7
Author: Aaron Gable <agable@chromium.org>
Date: Fri Nov 18 23:16:19 2016

Enable Gerrit CQ for webports

BUG= chromium:665593 

Change-Id: Ibc858bf72ace06763262216155a9499914db7cfd
Reviewed-on: https://chromium-review.googlesource.com/412928
Reviewed-by: Aaron Gable <agable@chromium.org>
Commit-Queue: Aaron Gable <agable@chromium.org>

[modify] https://crrev.com/72409725be9b4885275b36ab4a613f5fe64193d7/infra/config/cq.cfg

Comment 8 by bugdroid1@chromium.org, Nov 22 2016

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/webports/+/72409725be9b4885275b36ab4a613f5fe64193d7

commit 72409725be9b4885275b36ab4a613f5fe64193d7
Author: Aaron Gable <agable@chromium.org>
Date: Fri Nov 18 23:16:19 2016

Enable Gerrit CQ for webports

BUG= chromium:665593 

Change-Id: Ibc858bf72ace06763262216155a9499914db7cfd
Reviewed-on: https://chromium-review.googlesource.com/412928
Reviewed-by: Aaron Gable <agable@chromium.org>
Commit-Queue: Aaron Gable <agable@chromium.org>

[modify] https://crrev.com/72409725be9b4885275b36ab4a613f5fe64193d7/infra/config/cq.cfg

Comment 10 by benhenry@chromium.org, Jan 18 2017

Ping - please provide an update to your high priority bug. This bug is stale. Is it really P-1?

Comment 11 by aga...@chromium.org, Jan 19 2017

Date set: Tues, Jan 24
PSA sent: Should be a reply to https://groups.google.com/d/msg/native-client-dev/W9H064DHCWU/wvDrZb75AQAJ, apparently currently being held in the moderation queue.

Comment 13 by bugdroid1@chromium.org, Jan 24 2017

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/webports/+/bdbaf7e395cf46b2b608b2d0d3bc76d533fb7e03

commit bdbaf7e395cf46b2b608b2d0d3bc76d533fb7e03
Author: Aaron Gable <agable@chromium.org>
Date: Thu Jan 19 19:37:10 2017

Make Gerrit the default for webports code reviews

BUG= 665593 

Change-Id: I0c4336043a75220f175cbdbde24d1067f97083e3
Reviewed-on: https://chromium-review.googlesource.com/430221
Reviewed-by: Sam Clegg <sbc@chromium.org>
Reviewed-by: Brad Nelson <bradnelson@chromium.org>

[modify] https://crrev.com/bdbaf7e395cf46b2b608b2d0d3bc76d533fb7e03/codereview.settings

Comment 14 by bugdroid1@chromium.org, Jan 24 2017

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/webports/+/bdbaf7e395cf46b2b608b2d0d3bc76d533fb7e03

commit bdbaf7e395cf46b2b608b2d0d3bc76d533fb7e03
Author: Aaron Gable <agable@chromium.org>
Date: Thu Jan 19 19:37:10 2017

Make Gerrit the default for webports code reviews

BUG= 665593 

Change-Id: I0c4336043a75220f175cbdbde24d1067f97083e3
Reviewed-on: https://chromium-review.googlesource.com/430221
Reviewed-by: Sam Clegg <sbc@chromium.org>
Reviewed-by: Brad Nelson <bradnelson@chromium.org>

[modify] https://crrev.com/bdbaf7e395cf46b2b608b2d0d3bc76d533fb7e03/codereview.settings

Comment 15 by aga...@chromium.org, Jan 24 2017

Status: Fixed (was: Started)
All CLs landed, Final PSA sent.

Comment 16 by bugdroid1@chromium.org, Aug 1 2017

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/native_client/src/build_overrides/+/d56d0aa73300038348206b7503934d3706131d09

commit d56d0aa73300038348206b7503934d3706131d09
Author: Aaron Gable <agable@chromium.org>
Date: Wed Jul 26 22:11:12 2017

Upload nacl build_overrides changes to Gerrit by default

R=bradnelson@chromium.org

Bug:  665593 
Change-Id: I46eb4435070d6a740e073af8fae85a1409e7161b

[modify] https://crrev.com/d56d0aa73300038348206b7503934d3706131d09/codereview.settings

Comment 17 by bugdroid1@chromium.org, Aug 1 2017

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/native_client/pnacl-subzero/+/83670e622ac9f4285356063e076e0638e3e3ba17

commit 83670e622ac9f4285356063e076e0638e3e3ba17
Author: Aaron Gable <agable@chromium.org>
Date: Tue Aug 01 20:04:08 2017

Upload pnacl-subzero changes to Gerrit by default

R=bradnelson@chromium.org

Bug:  665593 
Change-Id: I1b9a5fd31c5e426bd193a32a2feb291eb17af5a6
Reviewed-on: https://chromium-review.googlesource.com/587993
Reviewed-by: Brad Nelson <bradnelson@chromium.org>

[modify] https://crrev.com/83670e622ac9f4285356063e076e0638e3e3ba17/codereview.settings

Comment 18 by bugdroid1@chromium.org, Aug 1 2017

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/native_client/pnacl-libcxx/+/7b39bf72661c1ad72fefd21cd6392e6a259a61cb

commit 7b39bf72661c1ad72fefd21cd6392e6a259a61cb
Author: Aaron Gable <agable@chromium.org>
Date: Wed Jul 26 22:10:55 2017

Upload pnacl-libcxx changes to Gerrit by default

R=bradnelson@chromium.org

Bug:  665593 
Change-Id: Idd9869876636d1391afbdec633fc799bbb919743

[modify] https://crrev.com/7b39bf72661c1ad72fefd21cd6392e6a259a61cb/codereview.settings

Sign in to add a comment