Issue 665590 link

Starred by 1 user

Issue metadata

Status:	Fixed
Owner:	mef@chromium.org
Closed:	Nov 2016
Cc:	█ kapishnikov@chromium.org ios-bugs@chromium.org
Components:	Internals>Network>Library
EstimatedDays:	----
NextAction:	----
OS:	iOS
Pri:	2
Type:	Bug

[Cronet] setRequestFilterBlock doesn't copy block if called after [Cronet start] on iOS.

Project Member Reported by mef@chromium.org, Nov 15 2016

Issue description

Cronet on iOS allows caller to specify block used to filter requests which should be handled by Cronet.

It could be passed before or after Cronet start, but is only retained in first case, so doing it afterwards causes a crash.

Project Member

Comment 1 by bugdroid1@chromium.org, Nov 16 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f62ae16d39451b1d505268d0bcf157a35b86fe84

commit f62ae16d39451b1d505268d0bcf157a35b86fe84
Author: mef <mef@chromium.org>
Date: Wed Nov 16 18:42:01 2016

[Cronet] Retain block passed to setRequestFilterBlock on iOS.

BUG= 665590 

Review-Url: https://codereview.chromium.org/2510463002
Cr-Commit-Position: refs/heads/master@{#432571}

[modify] https://crrev.com/f62ae16d39451b1d505268d0bcf157a35b86fe84/components/cronet/ios/Cronet.mm
[modify] https://crrev.com/f62ae16d39451b1d505268d0bcf157a35b86fe84/components/cronet/ios/test/cronet_http_test.mm
[modify] https://crrev.com/f62ae16d39451b1d505268d0bcf157a35b86fe84/components/cronet/ios/test/test_server.cc

Comment 2 by mef@chromium.org, Nov 22 2016

Status: Fixed (was: Started)

►

Issue 665590 link

Issue metadata

[Cronet] setRequestFilterBlock doesn't copy block if called after [Cronet start] on iOS.

Issue description

Comment 1 by bugdroid1@chromium.org, Nov 16 2016

Comment 1 Deleted

Comment 2 by mef@chromium.org, Nov 22 2016

Comment 2 Deleted

Sign in to add a comment