Migrate PDFium to PolyGerrit |
|||
Issue descriptionRepos: https://pdfium.googlesource.com/pdfium/+/master/codereview.settings https://pdfium.googlesource.com/pdfium_tests/+/master/codereview.settings Point of contact: dsinclair@ Lists: pdf-eng@ pdfium@googlegroups.com
,
Nov 15 2016
Note that pdfium_tests does not have a CQ, so either the CQ label should only be added in the pdfium repo, or everything should be handled at the All-Projects level and then suppressed in pdfium_tests.
,
Nov 17 2016
Enable gerrit review for all projects: https://pdfium.googlesource.com/All-Projects/+/720537e771ed423b9d60f475485f71d3883847ce/project.config Enable CQ label for pdfium: https://pdfium-review.googlesource.com/2010 Enable submit for pdfium_tests: https://pdfium-review.googlesource.com/2011
,
Nov 17 2016
Turning on Gerrit CQ: https://pdfium-review.googlesource.com/2012
,
Nov 17 2016
dsinclair@: Please take a look at https://pdfium-review.googlesource.com/c/2012/, the first pdfium review on Gerrit! You should be able to sign in, (make sure you're using PolyGerrit by clicking the link in the footer if you're not), and give the CL the CR+1 label. Once that's done, I'll send the PSA to the team. Let me know if you have any issues signing in and reviewing the change.
,
Nov 18 2016
The following revision refers to this bug: https://pdfium.googlesource.com/pdfium.git/+/8629ef80661f1fc5e77878ebfc542766df50f5d3 commit 8629ef80661f1fc5e77878ebfc542766df50f5d3 Author: Aaron Gable <agable@chromium.org> Date: Thu Nov 17 22:28:09 2016 Teach CQ to watch for PDFium CLs on Gerrit BUG= chromium:665583 Change-Id: Ief6e67dfdc71f0d16039118129109fe3541593a2 Reviewed-on: https://pdfium-review.googlesource.com/2012 Reviewed-by: dan sinclair <dsinclair@chromium.org> [modify] https://crrev.com/8629ef80661f1fc5e77878ebfc542766df50f5d3/infra/config/cq.cfg
,
Nov 18 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e181124a0144449b735b079d984aa3da6e46ba12 commit e181124a0144449b735b079d984aa3da6e46ba12 Author: pdfium-deps-roller <pdfium-deps-roller@chromium.org> Date: Fri Nov 18 21:34:04 2016 Roll src/third_party/pdfium/ 0201377b6..8629ef806 (1 commit). https://pdfium.googlesource.com/pdfium.git/+log/0201377b6c4b..8629ef80661f $ git log 0201377b6..8629ef806 --date=short --no-merges --format='%ad %ae %s' 2016-11-17 agable Teach CQ to watch for PDFium CLs on Gerrit BUG= 665583 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls TBR=dsinclair@chromium.org Review-Url: https://codereview.chromium.org/2513053002 Cr-Commit-Position: refs/heads/master@{#433303} [modify] https://crrev.com/e181124a0144449b735b079d984aa3da6e46ba12/DEPS
,
Nov 19 2016
,
Jan 18 2017
Ping - please provide an update to your high priority bug. This bug is stale. Is it really P-1?
,
Jan 19 2017
(Other PSA sent at the same time as the one above, which I forgot to mark here: https://groups.google.com/a/google.com/forum/#!topic/pdf-eng/kcGWgXZ-f5Q)
,
Jan 19 2017
Date set: Tues, Jan 24 PSA sent: https://groups.google.com/d/msg/pdfium/T51DncbjorA/C2D0BKJ4FwAJ
,
Jan 24 2017
Changes landed, final PSA sent (on the same thread).
,
Jan 24 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/15266c12e33354dc8d8b06c1c2ca58513ae31080 commit 15266c12e33354dc8d8b06c1c2ca58513ae31080 Author: pdfium-deps-roller <pdfium-deps-roller@chromium.org> Date: Tue Jan 24 21:28:16 2017 Roll src/third_party/pdfium/ 8804940c9..6e162b54f (5 commits). https://pdfium.googlesource.com/pdfium.git/+log/8804940c9a39..6e162b54f708 $ git log 8804940c9..6e162b54f --date=short --no-merges --format='%ad %ae %s' 2017-01-24 dsinclair Fixup coverage build 2017-01-24 halcanary No need to define SK_SCALAR_IS_FLOAT 2017-01-24 tsepez Replace some loose (ptr, len) pairs with CFX_ByteStringC in fpdfapi. 2017-01-19 agable Make Gerrit the default for pdfium code reviews 2017-01-24 tsepez Undefined shift in CPDF_PSEngine::DoOperator BUG= 665583 , 641551 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls TBR=dsinclair@chromium.org Review-Url: https://codereview.chromium.org/2654623003 Cr-Commit-Position: refs/heads/master@{#445821} [modify] https://crrev.com/15266c12e33354dc8d8b06c1c2ca58513ae31080/DEPS |
|||
►
Sign in to add a comment |
|||
Comment 1 by aga...@chromium.org
, Nov 15 2016