New issue
Advanced search Search tips

Issue 665582 link

Starred by 1 user
Status: Fixed
Owner:
steve...@chromium.org
Closed: Oct 2017
Cc:
xiy...@chromium.org
msw@chromium.org
mustash-bugs@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug

Blocking:
issue 758365



Sign in to add a comment

mash: Migrate SystemTrayClient::SignOut to a login or user service

Project Member Reported by jamescook@chromium.org, Nov 15 2016 
I'm moving SystemTrayDelegate::SignOut to SystemTrayClient as part of the servicification of ash. I'm keeping it where it is because that's where ash deals with chrome application lifetime, but it really should be part of a login or user account service.

Comment 1 by xiy...@chromium.org, Nov 15 2016

Cc: -xiy...@chromium.org
Owner: xiy...@chromium.org
Status: Assigned (was: Untriaged)
I'll take this.

Comment 2 by steve...@chromium.org, Oct 4 2017

Blocking: 758365
Cc: xiy...@chromium.org msw@chromium.org
Owner: steve...@chromium.org
I'm going to go ahead and do this to improve the fix for  issue 758365

Comment 3 by steve...@chromium.org, Oct 4 2017

Status: Started (was: Assigned)

Comment 4 by steve...@chromium.org, Oct 4 2017 

It seems like SessionControllerClient is the logical place to put 'RequestSignOut'? It already has 'RequestLockScreen' and 'SwitchActiveUser'.

Comment 5 by xiy...@chromium.org, Oct 4 2017 

SGTM to add RequestSignOut to SessionController/Client.
Project Member

Comment 6 by bugdroid1@chromium.org, Oct 4 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/40ab7f76c55635190680c68a93e727b3684e1d37

commit 40ab7f76c55635190680c68a93e727b3684e1d37
Author: Steven Bennetts <stevenjb@chromium.org>
Date: Wed Oct 04 23:32:27 2017

Mash: Move SignOut from system_tray.mojom -> session_controller.mojom

This also moves the 'RequestSignOut' interface used within Ash to
LockStateController which is a more logical place for the UI to
call into, and sets the code up for some day handing signout directly.

Bug:  665582 
Change-Id: I8624a071a825a33f95ba2b33a0ff1809e477754e
Reviewed-on: https://chromium-review.googlesource.com/701497
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506566}
[modify] https://crrev.com/40ab7f76c55635190680c68a93e727b3684e1d37/ash/public/interfaces/session_controller.mojom
[modify] https://crrev.com/40ab7f76c55635190680c68a93e727b3684e1d37/ash/public/interfaces/system_tray.mojom
[modify] https://crrev.com/40ab7f76c55635190680c68a93e727b3684e1d37/ash/session/session_controller.cc
[modify] https://crrev.com/40ab7f76c55635190680c68a93e727b3684e1d37/ash/session/session_controller.h
[modify] https://crrev.com/40ab7f76c55635190680c68a93e727b3684e1d37/ash/session/test_session_controller_client.cc
[modify] https://crrev.com/40ab7f76c55635190680c68a93e727b3684e1d37/ash/session/test_session_controller_client.h
[modify] https://crrev.com/40ab7f76c55635190680c68a93e727b3684e1d37/ash/system/session/logout_button_tray.cc
[modify] https://crrev.com/40ab7f76c55635190680c68a93e727b3684e1d37/ash/system/session/logout_confirmation_controller.cc
[modify] https://crrev.com/40ab7f76c55635190680c68a93e727b3684e1d37/ash/system/tray/system_tray_controller.cc
[modify] https://crrev.com/40ab7f76c55635190680c68a93e727b3684e1d37/ash/system/tray/system_tray_controller.h
[modify] https://crrev.com/40ab7f76c55635190680c68a93e727b3684e1d37/ash/system/user/user_view.cc
[modify] https://crrev.com/40ab7f76c55635190680c68a93e727b3684e1d37/chrome/browser/ui/ash/session_controller_client.cc
[modify] https://crrev.com/40ab7f76c55635190680c68a93e727b3684e1d37/chrome/browser/ui/ash/session_controller_client.h
[modify] https://crrev.com/40ab7f76c55635190680c68a93e727b3684e1d37/chrome/browser/ui/ash/system_tray_client.cc
[modify] https://crrev.com/40ab7f76c55635190680c68a93e727b3684e1d37/chrome/browser/ui/ash/system_tray_client.h

Comment 7 by steve...@chromium.org, Oct 4 2017

Status: Fixed (was: Started)

Comment 8 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Comment 9 by dchan@chromium.org, Jan 23 2018

Status: Fixed (was: Archived)

Comment 10 by lafo...@chromium.org, Feb 26 2018

Components: -MUS Internals>Services>WindowService
►

Sign in to add a comment