New issue
Advanced search Search tips

Issue 665574 link

Starred by 2 users
Status: Fixed
Owner:
thomasanderson@chromium.org
Closed: Nov 2016
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug

Blocking:
issue 713751



Sign in to add a comment

Linux Aura: Various cursors are incorrect or do not integrate with the system cursor theme

Project Member Reported by thomasanderson@chromium.org, Nov 15 2016 
Version 54.0.2840.100 (64-bit)
OS: Ubuntu 14.04

When dragging an object:
* The drag hand doesn't use the system cursor hand when available
* There's no cursor for moving an object
* The cursor for copying doesn't use the system cursor when available
* There's no cursor for linking an object

Webcursors:
* 'progress' and 'wait' are the same cursor
* 'alias', 'copy', 'move', 'grab', 'grabbing', 'nesw-resize', 'nwse-resize', and 'cell' don't use the system cursor when available
* 'no-drop' and 'not-allowed' are the same cursor

Please see the attached video for a demonstration of the above
cursors.mp4
3.1 MB View Download

Comment 1 by thomasanderson@chromium.org, Nov 15 2016 

X-reffing video for https://codereview.chromium.org/2504743002
cursor_patch.mp4
2.1 MB View Download
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 18 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/16c9f899aa654b5cb868242f2a19ab375b8397f9

commit 16c9f899aa654b5cb868242f2a19ab375b8397f9
Author: thomasanderson <thomasanderson@google.com>
Date: Fri Nov 18 08:33:38 2016

Linux Aura: Fixes and improvements for cursor loader

This CL:
* Adds 4 new cursor types for DND
    (On Linux, 'dnd-move' != 'move', 'dnd-link' != 'alias',
     'dnd-copy' != 'copy', 'dnd-none' != 'move')
* Tries to lookup the cursor in the native cursor theme before trying a
  chromium-supplied fallback cursor
* Removes desktop_cursor_loader_updater
* Removes XCursorCache

See videos in
https://bugs.chromium.org/p/chromium/issues/detail?id=665574
https://bugs.chromium.org/p/chromium/issues/detail?id=665574#c1

BUG= 665574 

Review-Url: https://codereview.chromium.org/2504743002
Cr-Commit-Position: refs/heads/master@{#433150}

[modify] https://crrev.com/16c9f899aa654b5cb868242f2a19ab375b8397f9/ui/aura/test/aura_test_helper.cc
[modify] https://crrev.com/16c9f899aa654b5cb868242f2a19ab375b8397f9/ui/base/cursor/cursor.h
[modify] https://crrev.com/16c9f899aa654b5cb868242f2a19ab375b8397f9/ui/base/cursor/cursor_loader_x11.cc
[modify] https://crrev.com/16c9f899aa654b5cb868242f2a19ab375b8397f9/ui/base/cursor/cursor_loader_x11.h
[modify] https://crrev.com/16c9f899aa654b5cb868242f2a19ab375b8397f9/ui/base/x/x11_util.cc
[modify] https://crrev.com/16c9f899aa654b5cb868242f2a19ab375b8397f9/ui/base/x/x11_util.h
[modify] https://crrev.com/16c9f899aa654b5cb868242f2a19ab375b8397f9/ui/views/BUILD.gn
[delete] https://crrev.com/863f2af2768cddc229e8822c622fa7dd539de290/ui/views/widget/desktop_aura/desktop_cursor_loader_updater.h
[delete] https://crrev.com/863f2af2768cddc229e8822c622fa7dd539de290/ui/views/widget/desktop_aura/desktop_cursor_loader_updater_auralinux.cc
[delete] https://crrev.com/863f2af2768cddc229e8822c622fa7dd539de290/ui/views/widget/desktop_aura/desktop_cursor_loader_updater_auralinux.h
[delete] https://crrev.com/863f2af2768cddc229e8822c622fa7dd539de290/ui/views/widget/desktop_aura/desktop_cursor_loader_updater_aurawin.cc
[delete] https://crrev.com/863f2af2768cddc229e8822c622fa7dd539de290/ui/views/widget/desktop_aura/desktop_cursor_loader_updater_chromeos.cc
[modify] https://crrev.com/16c9f899aa654b5cb868242f2a19ab375b8397f9/ui/views/widget/desktop_aura/desktop_drag_drop_client_aurax11.cc
[modify] https://crrev.com/16c9f899aa654b5cb868242f2a19ab375b8397f9/ui/views/widget/desktop_aura/desktop_drag_drop_client_aurax11_unittest.cc
[modify] https://crrev.com/16c9f899aa654b5cb868242f2a19ab375b8397f9/ui/views/widget/desktop_aura/desktop_native_cursor_manager.cc
[modify] https://crrev.com/16c9f899aa654b5cb868242f2a19ab375b8397f9/ui/views/widget/desktop_aura/desktop_native_cursor_manager.h
[modify] https://crrev.com/16c9f899aa654b5cb868242f2a19ab375b8397f9/ui/views/widget/desktop_aura/desktop_native_widget_aura.cc
[modify] https://crrev.com/16c9f899aa654b5cb868242f2a19ab375b8397f9/ui/views/widget/desktop_aura/desktop_window_tree_host_win.cc

Comment 3 by thomasanderson@chromium.org, Nov 18 2016

Status: Fixed (was: Started)

Comment 4 by rbyers@chromium.org, Jun 7 2017

Labels: M-57
Looks like this probably landed in Chrome 57, right?

Comment 5 by rbyers@chromium.org, Jun 7 2017

Blocking: 713751
►

Sign in to add a comment