"Download pending" notification shows "0 sec left" |
|||||||
Issue descriptionVersion: 56.0.2919.0 OS: Android When we show a "download pending" notification, we currently show "0 sec left" although we have not yet started the download. I believe the original mocks had no duration listed during the download pending. Is this the desired behavior?
,
Nov 16 2016
I was using a pixel with N (screenshot attached.) Patrick, which device did you see this on?
,
Nov 16 2016
An old Nexus 6.
,
Nov 17 2016
,
Nov 17 2016
the screenshot shows the notification is "downloading..", thats because for offline pages, we currently don't know how long it will take to download the page.
,
Nov 18 2016
I think the issue is not the "download pending..." string, but rather the "0 sec left" string which is visible in the screenshot and not accurate.
,
Nov 18 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ba84a485f4f812beb9631d22320a68939aaac15f commit ba84a485f4f812beb9631d22320a68939aaac15f Author: qinmin <qinmin@chromium.org> Date: Fri Nov 18 18:14:16 2016 Don't show the remaining time for offline page downloads For offline page downloads, we don't know the remaining time. Just show the downloading string should be fine. BUG= 665553 Review-Url: https://codereview.chromium.org/2514603002 Cr-Commit-Position: refs/heads/master@{#433238} [modify] https://crrev.com/ba84a485f4f812beb9631d22320a68939aaac15f/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java
,
Nov 18 2016
,
Nov 21 2016
Verified in latest M57 build -57.0.2926.0 build
,
Nov 23 2016
The fix missed the branch point, requesting merge
,
Nov 23 2016
Your change meets the bar and is auto-approved for M56 (branch: 2924)
,
Nov 23 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fd6493d1cefd182cefa9f22d58534cf7ce00647b commit fd6493d1cefd182cefa9f22d58534cf7ce00647b Author: Min Qin <qinmin@chromium.org> Date: Wed Nov 23 19:15:14 2016 Don't show the remaining time for offline page downloads For offline page downloads, we don't know the remaining time. Just show the downloading string should be fine. BUG= 665553 TBR=dfalcantara@chromium.org Review-Url: https://codereview.chromium.org/2514603002 Cr-Commit-Position: refs/heads/master@{#433238} (cherry picked from commit ba84a485f4f812beb9631d22320a68939aaac15f) Review URL: https://codereview.chromium.org/2523603005 . Cr-Commit-Position: refs/branch-heads/2924@{#82} Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059} [modify] https://crrev.com/fd6493d1cefd182cefa9f22d58534cf7ce00647b/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java
,
Dec 1 2016
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by qin...@chromium.org
, Nov 15 2016