Create Telemetry benchmark for large trace import time in Chrome |
|||||||
Issue descriptionRecently, there's been a noticeable slow-down in trace importing. This is to-be-expected given that we don't have any monitoring in place to track how long large traces take to import. I think that it makes sense to create a Telemetry benchmark that imports a constant large trace file and outputs as a metric the import time of that trace file. This will guarantee minimal noise in the benchmark.
,
Nov 15 2016
I remember we do not have a way of testing trace viewer changes on our bots, right? Would love to have that, too.
,
Nov 15 2016
We already have a TBMv2 metric for measuring stats to do with trace-viewer: https://github.com/catapult-project/catapult/blob/master/tracing/tracing/metrics/tracing_metric.html and benchmarks that use it. It seems like the right approach here is to add the metric that Charlie is talking about to tracing_metric and add a story that accounts for the behavior Charlie's talking about to an existing page set used by the tracing benchmarks.
,
Nov 15 2016
If we just write a normal Telemetry benchmark, won't the Catapult roller automatically handle this for us? It might only be able to narrow it down to one or two CLs, but that seems like it'd be adequate in almost all cases.
,
Nov 15 2016
Frankly, I would love to be able to try Catapult changes on the Chromium CQ without having to land and revert, but that's orthogonal to this FR.
,
Nov 15 2016
Fadi & Peiyong were working on this.
,
Nov 15 2016
,
Nov 22 2016
,
Nov 22 2016
Setting lpy as the owner since it's definitely triaged if someone's actively working on it.
,
Jan 13 2017
lpy@, any progress on this?
,
Jan 14 2017
I am not actively working on this.
,
Jan 17 2017
Any idea when you might be able to get around to this? Are you still planning on working on it? If not, can you unassign yourself?
,
Jan 22 2017
unassign myself since I am not actively working on this.
,
Jan 26 2017
,
Jan 27 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/eedd7c15d7970a5b81a2e6060c8f18d5242885a4 commit eedd7c15d7970a5b81a2e6060c8f18d5242885a4 Author: catapult-deps-roller <catapult-deps-roller@chromium.org> Date: Fri Jan 27 04:03:47 2017 Roll src/third_party/catapult/ 683b84f3b..fbdf6f597 (2 commits). https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/683b84f3b681..fbdf6f597f89 $ git log 683b84f3b..fbdf6f597 --date=short --no-merges --format='%ad %ae %s' 2017-01-26 charliea Record the time required to import the trace in the model stats. 2017-01-26 simonhatch Dashboard - Workaround startup.warm.* producing no values with --pageset-repeat=1. BUG= 665550 ,677843 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=catapult-sheriff@chromium.org Review-Url: https://codereview.chromium.org/2655853008 Cr-Commit-Position: refs/heads/master@{#446585} [modify] https://crrev.com/eedd7c15d7970a5b81a2e6060c8f18d5242885a4/DEPS
,
Feb 22 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7913c5d416e724b67e22afdcc929e1cd8d00cc9b commit 7913c5d416e724b67e22afdcc929e1cd8d00cc9b Author: catapult-deps-roller <catapult-deps-roller@chromium.org> Date: Wed Feb 22 16:54:56 2017 Roll src/third_party/catapult/ 0cc3f7ab5..bbfc356b5 (1 commit). https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/0cc3f7ab57ee..bbfc356b5b6e $ git log 0cc3f7ab5..bbfc356b5 --date=short --no-merges --format='%ad %ae %s' 2017-02-22 charliea Create a trace import duration metric Created with: roll-dep src/third_party/catapult BUG= 665550 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=catapult-sheriff@chromium.org Review-Url: https://codereview.chromium.org/2710923004 Cr-Commit-Position: refs/heads/master@{#452091} [modify] https://crrev.com/7913c5d416e724b67e22afdcc929e1cd8d00cc9b/DEPS
,
Feb 22 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7913c5d416e724b67e22afdcc929e1cd8d00cc9b commit 7913c5d416e724b67e22afdcc929e1cd8d00cc9b Author: catapult-deps-roller <catapult-deps-roller@chromium.org> Date: Wed Feb 22 16:54:56 2017 Roll src/third_party/catapult/ 0cc3f7ab5..bbfc356b5 (1 commit). https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/0cc3f7ab57ee..bbfc356b5b6e $ git log 0cc3f7ab5..bbfc356b5 --date=short --no-merges --format='%ad %ae %s' 2017-02-22 charliea Create a trace import duration metric Created with: roll-dep src/third_party/catapult BUG= 665550 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=catapult-sheriff@chromium.org Review-Url: https://codereview.chromium.org/2710923004 Cr-Commit-Position: refs/heads/master@{#452091} [modify] https://crrev.com/7913c5d416e724b67e22afdcc929e1cd8d00cc9b/DEPS
,
Feb 23 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6d81065580b4df8485a2222b03caad4b60ccfdb9 commit 6d81065580b4df8485a2222b03caad4b60ccfdb9 Author: charliea <charliea@chromium.org> Date: Thu Feb 23 16:06:24 2017 Enable the tracingMetric on the system_health.common benchmarks This will allow us to monitor the performance of importing traces. BUG= chromium:665550 Review-Url: https://codereview.chromium.org/2714533002 Cr-Commit-Position: refs/heads/master@{#452507} [modify] https://crrev.com/6d81065580b4df8485a2222b03caad4b60ccfdb9/tools/perf/benchmarks/system_health.py
,
Jun 22 2017
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by charliea@chromium.org
, Nov 15 2016