New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 665532 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

[Sync] Remove unnecessary PROXY_TABS checking

Project Member Reported by s...@chromium.org, Nov 15 2016

Issue description

Now that https://codereview.chromium.org/2504433002 has landed, we have a bunch of exsiting code that checks to ensure PROXY_TABS is enabled before using open tabs data, which can now be safely removed.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 5 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b43a8d106da8d916b4edc7c10da350cc2a11585a

commit b43a8d106da8d916b4edc7c10da350cc2a11585a
Author: skym <skym@chromium.org>
Date: Mon Dec 05 17:56:32 2016

[Sync] Removing complexity around PROXY_TABS now that empty sessions are provided when disabled.

Now that https://codereview.chromium.org/2504433002/ has landed,
sessions data is always empty when PROXY_TABS aka open tabs is
disabled. This makes the isTabSyncEnabled boolean that is passed
through the UI logic unnecessary.

It is imaginable to have a scenario where you would want to
differentiate between having no sessions data and have PROXY_TABS being
disabled. However, it doesn't seem that we currently do this anywhere,
and the percentage of the population that disables PROXY_TABS is so
small, it may never make sense to do this. Worst case we can add this
logic back.

BUG= 665532 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2517243002
Cr-Commit-Position: refs/heads/master@{#436345}

[modify] https://crrev.com/b43a8d106da8d916b4edc7c10da350cc2a11585a/chrome/browser/resources/history/other_devices.js
[modify] https://crrev.com/b43a8d106da8d916b4edc7c10da350cc2a11585a/chrome/browser/resources/md_history/app.crisper.js
[modify] https://crrev.com/b43a8d106da8d916b4edc7c10da350cc2a11585a/chrome/browser/resources/md_history/app.js
[modify] https://crrev.com/b43a8d106da8d916b4edc7c10da350cc2a11585a/chrome/browser/resources/md_history/history.js
[modify] https://crrev.com/b43a8d106da8d916b4edc7c10da350cc2a11585a/chrome/browser/resources/md_history/lazy_load.crisper.js
[modify] https://crrev.com/b43a8d106da8d916b4edc7c10da350cc2a11585a/chrome/browser/resources/md_history/synced_device_manager.js
[modify] https://crrev.com/b43a8d106da8d916b4edc7c10da350cc2a11585a/chrome/browser/ui/webui/foreign_session_handler.cc
[modify] https://crrev.com/b43a8d106da8d916b4edc7c10da350cc2a11585a/chrome/browser/ui/webui/foreign_session_handler.h
[modify] https://crrev.com/b43a8d106da8d916b4edc7c10da350cc2a11585a/chrome/test/data/webui/md_history/history_metrics_test.js
[modify] https://crrev.com/b43a8d106da8d916b4edc7c10da350cc2a11585a/chrome/test/data/webui/md_history/history_synced_tabs_test.js

Comment 2 by s...@chromium.org, Dec 5 2016

Status: Fixed (was: Assigned)

Sign in to add a comment