New issue
Advanced search Search tips

Issue 665520 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 602688



Sign in to add a comment

Fully support queries in the passthrough command decoder

Project Member Reported by geoffl...@chromium.org, Nov 15 2016

Issue description

The passthrough command decoder needs to properly implement queries by polling their results and writing them to shared memory.

A few query types need to be emulated entirely in the command decoder (GL_COMMANDS_ISSUED_CHROMIUM, GL_LATENCY_QUERY_CHROMIUM, GL_ASYNC_PIXEL_PACK_COMPLETED_CHROMIUM, GL_GET_ERROR_QUERY_CHROMIUM) and will require validation in BeginQuery and EndQuery.
 
Cc: cwallez@chromium.org jmad...@chromium.org
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/73582148251d24005ee3ab08fcdb75757ae9fb9d

commit 73582148251d24005ee3ab08fcdb75757ae9fb9d
Author: geofflang <geofflang@chromium.org>
Date: Tue Nov 22 14:59:04 2016

Implement basic query functionality in the passthrough command buffer.

Store errors in a local set in the passthrough command buffer, allowing us to
track if an error was generated for specific calls that need to be emulated.

BUG=602688
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2502423003
Cr-Commit-Position: refs/heads/master@{#433858}

[modify] https://crrev.com/73582148251d24005ee3ab08fcdb75757ae9fb9d/gpu/command_buffer/service/gles2_cmd_decoder_passthrough.cc
[modify] https://crrev.com/73582148251d24005ee3ab08fcdb75757ae9fb9d/gpu/command_buffer/service/gles2_cmd_decoder_passthrough.h
[modify] https://crrev.com/73582148251d24005ee3ab08fcdb75757ae9fb9d/gpu/command_buffer/service/gles2_cmd_decoder_passthrough_doer_prototypes.h
[modify] https://crrev.com/73582148251d24005ee3ab08fcdb75757ae9fb9d/gpu/command_buffer/service/gles2_cmd_decoder_passthrough_doers.cc
[modify] https://crrev.com/73582148251d24005ee3ab08fcdb75757ae9fb9d/gpu/command_buffer/service/gles2_cmd_decoder_passthrough_handlers.cc
Status: Fixed (was: Started)

Sign in to add a comment