New issue
Advanced search Search tips

Issue 665518 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 602688



Sign in to add a comment

Complete the mailbox entry points in the passthrough command buffer

Project Member Reported by geoffl...@chromium.org, Nov 15 2016

Issue description

The mailbox entry points in the passthrough command buffer do not do any validation and the ones related to the back/front buffers are still unimplemented.

Add validation to the various entry points (DoProduceTextureCHROMIUM, DoProduceTextureDirectCHROMIUM, DoConsumeTextureCHROMIUM, DoCreateAndConsumeTextureINTERNAL)

Implement TakeFrontBuffer and ReturnFrontBuffer.

Test with gl_tests --use-passthrough-cmd-decoder


 
Blockedon: -602688
Blocking: 602688
Cc: cwallez@chromium.org jmad...@chromium.org
Project Member

Comment 4 by bugdroid1@chromium.org, Dec 14 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3069d53ce60072bff30c9c824b946ee2f64ed4be

commit 3069d53ce60072bff30c9c824b946ee2f64ed4be
Author: cwallez <cwallez@chromium.org>
Date: Wed Dec 14 19:19:57 2016

WebGL CTS: Remove passing expectations for passthrough D3D11

BUG=chromium:602688
BUG= chromium:665518 
BUG=angleproject:1523
BUG= angleproject:1635 
BUG= angleproject:1639 
TBR=zmo@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2577723002
Cr-Commit-Position: refs/heads/master@{#438581}

[modify] https://crrev.com/3069d53ce60072bff30c9c824b946ee2f64ed4be/content/test/gpu/gpu_tests/webgl_conformance_expectations.py

Project Member

Comment 5 by bugdroid1@chromium.org, Aug 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7d9cc1464f836e6d8c1ab9396a48c656df153d58

commit 7d9cc1464f836e6d8c1ab9396a48c656df153d58
Author: Geoff Lang <geofflang@chromium.org>
Date: Thu Aug 10 17:44:08 2017

Skip gl_tests that are expected to fail with the passthrough cmd decoder

BUG= 754000 
BUG= 665518 
BUG= angleproject:1932 
BUG= 754008 

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Id2a3649aaa676f8ce72a838fc7cb269a84237474
Reviewed-on: https://chromium-review.googlesource.com/608805
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#493452}
[modify] https://crrev.com/7d9cc1464f836e6d8c1ab9396a48c656df153d58/gpu/command_buffer/tests/gl_copy_texture_CHROMIUM_unittest.cc
[modify] https://crrev.com/7d9cc1464f836e6d8c1ab9396a48c656df153d58/gpu/command_buffer/tests/gl_manager.h
[modify] https://crrev.com/7d9cc1464f836e6d8c1ab9396a48c656df153d58/gpu/command_buffer/tests/gl_map_buffer_range_unittest.cc
[modify] https://crrev.com/7d9cc1464f836e6d8c1ab9396a48c656df153d58/gpu/command_buffer/tests/gl_texture_mailbox_unittest.cc

Status: Fixed (was: Available)

Sign in to add a comment