"org.chromium.chrome.browser.customtabs.CustomTabActivityTest#testPostMessageBasic" is flaky |
|||
Issue description"org.chromium.chrome.browser.customtabs.CustomTabActivityTest#testPostMessageBasic" is flaky. This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label. We have detected 3 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyXAsSBUZsYWtlIlFvcmcuY2hyb21pdW0uY2hyb21lLmJyb3dzZXIuY3VzdG9tdGFicy5DdXN0b21UYWJBY3Rpdml0eVRlc3QjdGVzdFBvc3RNZXNzYWdlQmFzaWMM. Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
,
Nov 15 2016
,
Nov 15 2016
,
Nov 16 2016
,
Nov 16 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/95e00cf8c6cc687b227d0c3e291b95df211d6d6b commit 95e00cf8c6cc687b227d0c3e291b95df211d6d6b Author: yusufo <yusufo@chromium.org> Date: Wed Nov 16 00:14:02 2016 Fail gracefully if the postMessage channel is closed Although we check for the channel being available before posting the task on UI thread, it is still possible to get a navigation block the thread and close the channel before the task is completed. The testPostMessageBasic case actually enforces this, so ends up flaking. Avoid crashes and fail gracefully here. BUG= 665513 Review-Url: https://codereview.chromium.org/2503943002 Cr-Commit-Position: refs/heads/master@{#432305} [modify] https://crrev.com/95e00cf8c6cc687b227d0c3e291b95df211d6d6b/chrome/android/java/src/org/chromium/chrome/browser/customtabs/PostMessageHandler.java |
|||
►
Sign in to add a comment |
|||
Comment 1 by jbudorick@chromium.org
, Nov 15 2016Status: Assigned (was: Untriaged)