"PicasaDataProviderNoDatabaseGetAlbumsImagesTest.NoDatabaseGetAlbumsImages" is flaky |
||||||
Issue description"PicasaDataProviderNoDatabaseGetAlbumsImagesTest.NoDatabaseGetAlbumsImages" is flaky. This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label. We have detected 3 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyVAsSBUZsYWtlIklQaWNhc2FEYXRhUHJvdmlkZXJOb0RhdGFiYXNlR2V0QWxidW1zSW1hZ2VzVGVzdC5Ob0RhdGFiYXNlR2V0QWxidW1zSW1hZ2VzDA. Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
,
Nov 16 2016
emircan: I think your recent patch (https://codereview.chromium.org/2427053002) is the culprit for these flaking tests. Can you confirm? Thanks, Tommy
,
Nov 17 2016
I don't think it is related. That CL only affects real-time video encode, i.e. Hangouts for codec H264. The log message [INFO:media_foundation_video_encode_accelerator_win.cc(307)]] indicates that hardware encoder isn't available on this platform, and that check is done during the start of GPU process each time. Assigning it back for further triage.
,
Nov 18 2016
,
Nov 19 2016
Hi fdoray: I'm pretty sure I've identified the CL here as the beginning of these flakes. https://codereview.chromium.org/2514113003/ Sorry! Tommy
,
Nov 21 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6f5a068ec88b1f533a4bbd040f5dd6352ff112b5 commit 6f5a068ec88b1f533a4bbd040f5dd6352ff112b5 Author: fdoray <fdoray@chromium.org> Date: Mon Nov 21 21:05:18 2016 Always delete media galleries FilePathWatchers on the FILE thread. This CL uses content::BrowserThread::DeleteOnFileThread to guarantee that FilePathWatchers created by StartFilePathWatchOnMediaTaskRunner() are always deleted on the thread from which they were created (i.e. the FILE thread). BUG= 665511 Review-Url: https://codereview.chromium.org/2518053002 Cr-Commit-Position: refs/heads/master@{#433649} [modify] https://crrev.com/6f5a068ec88b1f533a4bbd040f5dd6352ff112b5/chrome/browser/media_galleries/fileapi/file_path_watcher_util.cc [modify] https://crrev.com/6f5a068ec88b1f533a4bbd040f5dd6352ff112b5/chrome/browser/media_galleries/fileapi/file_path_watcher_util.h [modify] https://crrev.com/6f5a068ec88b1f533a4bbd040f5dd6352ff112b5/chrome/browser/media_galleries/fileapi/iapps_data_provider.cc [modify] https://crrev.com/6f5a068ec88b1f533a4bbd040f5dd6352ff112b5/chrome/browser/media_galleries/fileapi/iapps_data_provider.h [modify] https://crrev.com/6f5a068ec88b1f533a4bbd040f5dd6352ff112b5/chrome/browser/media_galleries/fileapi/itunes_file_util_unittest.cc [modify] https://crrev.com/6f5a068ec88b1f533a4bbd040f5dd6352ff112b5/chrome/browser/media_galleries/fileapi/picasa_data_provider.cc [modify] https://crrev.com/6f5a068ec88b1f533a4bbd040f5dd6352ff112b5/chrome/browser/media_galleries/fileapi/picasa_data_provider.h [modify] https://crrev.com/6f5a068ec88b1f533a4bbd040f5dd6352ff112b5/chrome/browser/media_galleries/fileapi/picasa_data_provider_browsertest.cc
,
Nov 22 2016
Great. It looks like the test itself got disabled here: https://codereview.chromium.org/2520623006/ So once you are confident that the problem is fixed, you may want to revert the above patch.
,
Dec 5 2016
No flakes since the fix landed. |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by horo@chromium.org
, Nov 16 2016Owner: tommycli@chromium.org
Status: Assigned (was: Untriaged)