New issue
Advanced search Search tips

Issue 665504 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug

Blocking:
issue 578029



Sign in to add a comment

Loading priority of remote web fonts should be set to VeryLow on slow connections

Project Member Reported by tbansal@chromium.org, Nov 15 2016

Issue description

When the network is detected to be slow, Blink immediately changes to
using fallback font. That means that the WebFont is no longer required for
text paint. In such case, the loading priority of web fonts should be set to VeryLow to free up the network pipeline for other higher priority resources.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5ea0c57befbcadba648b21447e83d5d4a280c885

commit 5ea0c57befbcadba648b21447e83d5d4a280c885
Author: tbansal <tbansal@chromium.org>
Date: Tue Nov 15 20:54:52 2016

Set WebFont priority to very low if the network is detected to be slow

When the network is detected to be slow, Blink immediately changes to
using fallback font. This CL changes the Blink resource priority of the
WebFont resource to VeryLow since the font is no longer required for
text paint.

BUG= 665504 

Review-Url: https://codereview.chromium.org/2494243003
Cr-Commit-Position: refs/heads/master@{#432254}

[modify] https://crrev.com/5ea0c57befbcadba648b21447e83d5d4a280c885/third_party/WebKit/Source/core/css/RemoteFontFaceSource.cpp
[modify] https://crrev.com/5ea0c57befbcadba648b21447e83d5d4a280c885/third_party/WebKit/Source/core/css/RemoteFontFaceSource.h
[modify] https://crrev.com/5ea0c57befbcadba648b21447e83d5d4a280c885/third_party/WebKit/Source/core/fetch/FontResource.cpp
[modify] https://crrev.com/5ea0c57befbcadba648b21447e83d5d4a280c885/third_party/WebKit/Source/core/fetch/FontResource.h

Status: Fixed (was: Started)
Components: Internals>Network>NetworkQuality
Labels: -nqe
Project Member

Comment 5 by bugdroid1@chromium.org, Mar 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fd4fb29de4630be62b296e01987d7bd09d0e4a6e

commit fd4fb29de4630be62b296e01987d7bd09d0e4a6e
Author: tbansal <tbansal@chromium.org>
Date: Wed Mar 22 08:05:36 2017

Lower the webfont loading priority only if the user is in V2 field trial

Currently, the loading priority of web fonts is changed to Low if the
user is on 2G network (regardless of if Chrome is a part of
WebFontsInterventionV2 field trial or not). This CL adds an additional
constraint so that the loading priority is changed only if Chrome is
part of V2 field trial. This makes it possible to quantify the effect
of changing the loading priority as part of the WebFontsInterventionV2
field trial.

BUG= 665504 

Review-Url: https://codereview.chromium.org/2763523002
Cr-Commit-Position: refs/heads/master@{#458681}

[modify] https://crrev.com/fd4fb29de4630be62b296e01987d7bd09d0e4a6e/third_party/WebKit/Source/core/css/RemoteFontFaceSource.cpp

Labels: -M-56 Merge-Request-58
Status: Started (was: Fixed)
Requesting M-58 merge-approval for CL in #5 above.
Project Member

Comment 7 by sheriffbot@chromium.org, Mar 23 2017

Labels: -Merge-Request-58 Hotlist-Merge-Approved Merge-Approved-58
Your change meets the bar and is auto-approved for M58. Please go ahead and merge the CL to branch 3029 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 8 by bugdroid1@chromium.org, Mar 23 2017

Labels: -merge-approved-58 merge-merged-3029
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d9e025babf3ed584560c602f7a1adbd7a9d5f8c2

commit d9e025babf3ed584560c602f7a1adbd7a9d5f8c2
Author: Tarun Bansal <tbansal@google.com>
Date: Thu Mar 23 20:25:29 2017

Lower the webfont loading priority only if the user is in V2 field trial

Currently, the loading priority of web fonts is changed to Low if the
user is on 2G network (regardless of if Chrome is a part of
WebFontsInterventionV2 field trial or not). This CL adds an additional
constraint so that the loading priority is changed only if Chrome is
part of V2 field trial. This makes it possible to quantify the effect
of changing the loading priority as part of the WebFontsInterventionV2
field trial.

BUG= 665504 

Review-Url: https://codereview.chromium.org/2763523002
Cr-Commit-Position: refs/heads/master@{#458681}
(cherry picked from commit fd4fb29de4630be62b296e01987d7bd09d0e4a6e)

Review-Url: https://codereview.chromium.org/2769183003 .
Cr-Commit-Position: refs/branch-heads/3029@{#393}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}

[modify] https://crrev.com/d9e025babf3ed584560c602f7a1adbd7a9d5f8c2/third_party/WebKit/Source/core/css/RemoteFontFaceSource.cpp

Labels: M-58
Status: Fixed (was: Started)

Sign in to add a comment