New issue
Advanced search Search tips

Issue 665494 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Update and improve layout test documentation.

Project Member Reported by qyears...@chromium.org, Nov 15 2016

Issue description

In https://codereview.chromium.org/2476573006 pwnall@ moved the layout test documentation to markdown in the Chromium source tree, at:

https://chromium.googlesource.com/chromium/src/+/master/docs/testing/layout_tests.md

This documentation is old, so some parts may be out of date, and there are also some areas that could potentially be expanded, including:
 - How to write a good layout test
 - How to convert from js-test.js to testharness.js
 - How to convert a pixel test to a reference test
 - How do we automatically import and/or export web platform tests?
 - How do platform-specific baseline directories and fallback search paths work?
 

Comment 1 by pwnall@chromium.org, Nov 15 2016

This CL does some of the update work: http://crrev.com/2492733003
Excellent :-D
Project Member

Comment 4 by bugdroid1@chromium.org, Nov 29 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4ea2eb3e13b7d1ee654d54528c96fb73371ee1bf

commit 4ea2eb3e13b7d1ee654d54528c96fb73371ee1bf
Author: pwnall <pwnall@chromium.org>
Date: Tue Nov 29 02:47:25 2016

New documentation on writing LayoutTests.

This CL pulls out the content on writing LayoutTests from
layout_tests.md, and does a significant overhaul of it.

BUG= 665494 

Review-Url: https://codereview.chromium.org/2492733003
Cr-Commit-Position: refs/heads/master@{#434842}

[modify] https://crrev.com/4ea2eb3e13b7d1ee654d54528c96fb73371ee1bf/docs/testing/layout_tests.md
[add] https://crrev.com/4ea2eb3e13b7d1ee654d54528c96fb73371ee1bf/docs/testing/writing_layout_tests.md

Project Member

Comment 5 by bugdroid1@chromium.org, Jan 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d2b7d6442f83d3259ef811b9257612b42a76d0a7

commit d2b7d6442f83d3259ef811b9257612b42a76d0a7
Author: dpranke <dpranke@chromium.org>
Date: Sun Jan 15 04:00:24 2017

Tweak the descriptions of the various types of layout tests.

This CL adjusts the work in r434842 to better describe the
differences between pixel tests and render tree tests and when
you want one or the other. It also gets rid of the "DumpRenderTree"
terminology since we don't really use that any more.

R=pwnall@chromium.org, me@gsnedders.com
BUG= 665494 

Review-Url: https://codereview.chromium.org/2547463003
Cr-Commit-Position: refs/heads/master@{#443810}

[modify] https://crrev.com/d2b7d6442f83d3259ef811b9257612b42a76d0a7/docs/testing/writing_layout_tests.md

Project Member

Comment 6 by bugdroid1@chromium.org, Jan 30 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4f0acca4ba39b6731f7566b8c8af674a22cd78e3

commit 4f0acca4ba39b6731f7566b8c8af674a22cd78e3
Author: qyearsley <qyearsley@chromium.org>
Date: Mon Jan 30 08:18:43 2017

Check in documentation for WPT import/export to //docs.

Copied from:
https://sites.google.com/a/chromium.org/dev/blink/importing-the-w3c-tests
and then edited and updated.

BUG= 665494 

Review-Url: https://codereview.chromium.org/2660083002
Cr-Commit-Position: refs/heads/master@{#446964}

[add] https://crrev.com/4f0acca4ba39b6731f7566b8c8af674a22cd78e3/docs/testing/web_platform_tests.md

Project Member

Comment 7 by bugdroid1@chromium.org, Feb 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7b458d5fa7e1508c470290d951c44a17e2827cf6

commit 7b458d5fa7e1508c470290d951c44a17e2827cf6
Author: qyearsley <qyearsley@chromium.org>
Date: Thu Feb 02 17:51:15 2017

Remove extra brackets in docs/testing/web_platform_tests.md.

This is a follow-up to https://crrev.com/2660083002/.

BUG= 665494 

Review-Url: https://codereview.chromium.org/2668283002
Cr-Commit-Position: refs/heads/master@{#447794}

[modify] https://crrev.com/7b458d5fa7e1508c470290d951c44a17e2827cf6/docs/testing/web_platform_tests.md

Owner: pwnall@chromium.org
Status: Fixed (was: Available)
This issue is very non-specific and doesn't have a clearly defined end point.

Documentation can always be improved; some ideas of particular things to add for layout tests are still:
 - How to write a good layout test
 - How to convert from js-test.js to testharness.js

But I'll close this bug now, especially since pwnall@'s change helped improve documentation.

Sign in to add a comment