New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 665493 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner: ----
Closed: Nov 7
Cc:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

Use AsyncTask#executeOnExecutor() instead of execute().

Project Member Reported by lizeb@chromium.org, Nov 15 2016

Issue description

AsyncTask#execute() doesn't execute the tasks on a thread pool but on a single background thread, leading to potential queuing, since AsyncTasks are typically used for long-running background operations.

Chrome has a lot of these calls, and most of them should be able to run on the concurrent executor. For the other ones, documenting that the serial executor is needed is better.
See https://cs.chromium.org/chromium/src/chrome/android/java/src/org/chromium/chrome/browser/share/ShareHelper.java?q=%22.execute()%22+lang:java&sq=package:chromium&l=272&dr=C

One such instance is in ShareHelper.
 
Is this worth writing a presubmit check for as well?
Labels: -Performance Performance-Browser
Project Member

Comment 3 by sheriffbot@chromium.org, May 2 2018

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Status: WontFix (was: Untriaged)
This regression has been open for half a year. It's not very actionable and the regression has been in all Chrome user's hands for months.

Sign in to add a comment