interface ShapeDetection [1] has parameters (handle<shared_buffer> frame_data, uint32 width, uint32 height), consider using mojo::Bitmap [2] for this. [1] https://cs.chromium.org/chromium/src/third_party/WebKit/public/platform/modules/shapedetection/shapedetection.mojom?q=shapedetection.mojom&sq=package:chromium&dr&l=21 [2] https://cs.chromium.org/chromium/src/skia/public/interfaces/bitmap.mojom?rcl=0&l=35
mcasas@, I've assigned you as owner for tracking purposes. I don't think anyone else is likely to act on this.
I am new to chromium project and I'm interested in trying this out. Can I work on it?
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/33adf4c85dd553eb607bcf9c02c5fa60c8738a68 commit 33adf4c85dd553eb607bcf9c02c5fa60c8738a68 Author: junwei.fu <junwei.fu@intel.com> Date: Wed Jan 25 22:25:08 2017 ShapeDetection: use mojom::Bitmap for mojo interface. This CL uses mojo::Bitmap for mojo ShapeDetection interfaces definition, so that the Detect API is completely flexible and friendly. BUG= 665488 TEST(Layout)= third_party/WebKit/LayoutTests/fast/shapedetection/shapedetection-creation.html third_party/WebKit/LayoutTests/fast/shapedetection/shapedetection-empty-input.html third_party/WebKit/LayoutTests/shapedetection/detection-HTMLCanvasElement.html third_party/WebKit/LayoutTests/shapedetection/detection-HTMLImageElement.html third_party/WebKit/LayoutTests/shapedetection/detection-HTMLVideoElement.html third_party/WebKit/LayoutTests/shapedetection/detection-ImageBitmap.html third_party/WebKit/LayoutTests/shapedetection/detection-ImageData.html Review-Url: https://codereview.chromium.org/2629433003 Cr-Commit-Position: refs/heads/master@{#446142} [modify] https://crrev.com/33adf4c85dd553eb607bcf9c02c5fa60c8738a68/AUTHORS [modify] https://crrev.com/33adf4c85dd553eb607bcf9c02c5fa60c8738a68/chrome/android/BUILD.gn [modify] https://crrev.com/33adf4c85dd553eb607bcf9c02c5fa60c8738a68/chrome/android/java/src/org/chromium/chrome/browser/shapedetection/BarcodeDetectionImpl.java [modify] https://crrev.com/33adf4c85dd553eb607bcf9c02c5fa60c8738a68/chrome/android/java/src/org/chromium/chrome/browser/shapedetection/TextDetectionImpl.java [modify] https://crrev.com/33adf4c85dd553eb607bcf9c02c5fa60c8738a68/content/public/android/BUILD.gn [modify] https://crrev.com/33adf4c85dd553eb607bcf9c02c5fa60c8738a68/content/public/android/java/src/org/chromium/content/browser/shapedetection/FaceDetectionImpl.java [modify] https://crrev.com/33adf4c85dd553eb607bcf9c02c5fa60c8738a68/services/shape_detection/public/interfaces/BUILD.gn [modify] https://crrev.com/33adf4c85dd553eb607bcf9c02c5fa60c8738a68/services/shape_detection/public/interfaces/barcodedetection.mojom [modify] https://crrev.com/33adf4c85dd553eb607bcf9c02c5fa60c8738a68/services/shape_detection/public/interfaces/facedetection.mojom [modify] https://crrev.com/33adf4c85dd553eb607bcf9c02c5fa60c8738a68/services/shape_detection/public/interfaces/textdetection.mojom [modify] https://crrev.com/33adf4c85dd553eb607bcf9c02c5fa60c8738a68/third_party/WebKit/LayoutTests/shapedetection/resources/mock-barcodedetection.js [modify] https://crrev.com/33adf4c85dd553eb607bcf9c02c5fa60c8738a68/third_party/WebKit/LayoutTests/shapedetection/resources/mock-facedetection.js [modify] https://crrev.com/33adf4c85dd553eb607bcf9c02c5fa60c8738a68/third_party/WebKit/LayoutTests/shapedetection/resources/mock-textdetection.js [modify] https://crrev.com/33adf4c85dd553eb607bcf9c02c5fa60c8738a68/third_party/WebKit/Source/modules/shapedetection/BUILD.gn [modify] https://crrev.com/33adf4c85dd553eb607bcf9c02c5fa60c8738a68/third_party/WebKit/Source/modules/shapedetection/BarcodeDetector.cpp [modify] https://crrev.com/33adf4c85dd553eb607bcf9c02c5fa60c8738a68/third_party/WebKit/Source/modules/shapedetection/BarcodeDetector.h [modify] https://crrev.com/33adf4c85dd553eb607bcf9c02c5fa60c8738a68/third_party/WebKit/Source/modules/shapedetection/DEPS [modify] https://crrev.com/33adf4c85dd553eb607bcf9c02c5fa60c8738a68/third_party/WebKit/Source/modules/shapedetection/FaceDetector.cpp [modify] https://crrev.com/33adf4c85dd553eb607bcf9c02c5fa60c8738a68/third_party/WebKit/Source/modules/shapedetection/FaceDetector.h [modify] https://crrev.com/33adf4c85dd553eb607bcf9c02c5fa60c8738a68/third_party/WebKit/Source/modules/shapedetection/ShapeDetector.cpp [modify] https://crrev.com/33adf4c85dd553eb607bcf9c02c5fa60c8738a68/third_party/WebKit/Source/modules/shapedetection/ShapeDetector.h [modify] https://crrev.com/33adf4c85dd553eb607bcf9c02c5fa60c8738a68/third_party/WebKit/Source/modules/shapedetection/TextDetector.cpp [modify] https://crrev.com/33adf4c85dd553eb607bcf9c02c5fa60c8738a68/third_party/WebKit/Source/modules/shapedetection/TextDetector.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2a78436aaa2277759c1d9f11b719b72cb95456b4 commit 2a78436aaa2277759c1d9f11b719b72cb95456b4 Author: maniscalco <maniscalco@chromium.org> Date: Wed Jan 25 22:42:28 2017 Revert of ShapeDetection: use mojom::Bitmap for mojo interface. (patchset #5 id:280001 of https://codereview.chromium.org/2629433003/ ) Reason for revert: Suspected of breaking the build: https://build.chromium.org/p/chromium.gpu/builders/GPU%20Mac%20Builder/builds/81497 Original issue's description: > ShapeDetection: use mojom::Bitmap for mojo interface. > > This CL uses mojo::Bitmap for mojo ShapeDetection interfaces definition, > so that the Detect API is completely flexible and friendly. > > BUG= 665488 > TEST(Layout)= > third_party/WebKit/LayoutTests/fast/shapedetection/shapedetection-creation.html > third_party/WebKit/LayoutTests/fast/shapedetection/shapedetection-empty-input.html > third_party/WebKit/LayoutTests/shapedetection/detection-HTMLCanvasElement.html > third_party/WebKit/LayoutTests/shapedetection/detection-HTMLImageElement.html > third_party/WebKit/LayoutTests/shapedetection/detection-HTMLVideoElement.html > third_party/WebKit/LayoutTests/shapedetection/detection-ImageBitmap.html > third_party/WebKit/LayoutTests/shapedetection/detection-ImageData.html > > Review-Url: https://codereview.chromium.org/2629433003 > Cr-Commit-Position: refs/heads/master@{#446142} > Committed: https://chromium.googlesource.com/chromium/src/+/33adf4c85dd553eb607bcf9c02c5fa60c8738a68 TBR=rockot@chromium.org,aelias@chromium.org,ben@chromium.org,dominickn@chromium.org,dtrainor@chromium.org,haraken@chromium.org,leon.han@intel.com,mcasas@chromium.org,mlamouri@chromium.org,timvolodine@chromium.org,tsepez@chromium.org,xianglu@chromium.org,yzshen@chromium.org,junwei.fu@intel.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= 665488 Review-Url: https://codereview.chromium.org/2655533005 Cr-Commit-Position: refs/heads/master@{#446145} [modify] https://crrev.com/2a78436aaa2277759c1d9f11b719b72cb95456b4/AUTHORS [modify] https://crrev.com/2a78436aaa2277759c1d9f11b719b72cb95456b4/chrome/android/BUILD.gn [modify] https://crrev.com/2a78436aaa2277759c1d9f11b719b72cb95456b4/chrome/android/java/src/org/chromium/chrome/browser/shapedetection/BarcodeDetectionImpl.java [modify] https://crrev.com/2a78436aaa2277759c1d9f11b719b72cb95456b4/chrome/android/java/src/org/chromium/chrome/browser/shapedetection/TextDetectionImpl.java [modify] https://crrev.com/2a78436aaa2277759c1d9f11b719b72cb95456b4/content/public/android/BUILD.gn [modify] https://crrev.com/2a78436aaa2277759c1d9f11b719b72cb95456b4/content/public/android/java/src/org/chromium/content/browser/shapedetection/FaceDetectionImpl.java [modify] https://crrev.com/2a78436aaa2277759c1d9f11b719b72cb95456b4/services/shape_detection/public/interfaces/BUILD.gn [modify] https://crrev.com/2a78436aaa2277759c1d9f11b719b72cb95456b4/services/shape_detection/public/interfaces/barcodedetection.mojom [modify] https://crrev.com/2a78436aaa2277759c1d9f11b719b72cb95456b4/services/shape_detection/public/interfaces/facedetection.mojom [modify] https://crrev.com/2a78436aaa2277759c1d9f11b719b72cb95456b4/services/shape_detection/public/interfaces/textdetection.mojom [modify] https://crrev.com/2a78436aaa2277759c1d9f11b719b72cb95456b4/third_party/WebKit/LayoutTests/shapedetection/resources/mock-barcodedetection.js [modify] https://crrev.com/2a78436aaa2277759c1d9f11b719b72cb95456b4/third_party/WebKit/LayoutTests/shapedetection/resources/mock-facedetection.js [modify] https://crrev.com/2a78436aaa2277759c1d9f11b719b72cb95456b4/third_party/WebKit/LayoutTests/shapedetection/resources/mock-textdetection.js [modify] https://crrev.com/2a78436aaa2277759c1d9f11b719b72cb95456b4/third_party/WebKit/Source/modules/shapedetection/BUILD.gn [modify] https://crrev.com/2a78436aaa2277759c1d9f11b719b72cb95456b4/third_party/WebKit/Source/modules/shapedetection/BarcodeDetector.cpp [modify] https://crrev.com/2a78436aaa2277759c1d9f11b719b72cb95456b4/third_party/WebKit/Source/modules/shapedetection/BarcodeDetector.h [modify] https://crrev.com/2a78436aaa2277759c1d9f11b719b72cb95456b4/third_party/WebKit/Source/modules/shapedetection/DEPS [modify] https://crrev.com/2a78436aaa2277759c1d9f11b719b72cb95456b4/third_party/WebKit/Source/modules/shapedetection/FaceDetector.cpp [modify] https://crrev.com/2a78436aaa2277759c1d9f11b719b72cb95456b4/third_party/WebKit/Source/modules/shapedetection/FaceDetector.h [modify] https://crrev.com/2a78436aaa2277759c1d9f11b719b72cb95456b4/third_party/WebKit/Source/modules/shapedetection/ShapeDetector.cpp [modify] https://crrev.com/2a78436aaa2277759c1d9f11b719b72cb95456b4/third_party/WebKit/Source/modules/shapedetection/ShapeDetector.h [modify] https://crrev.com/2a78436aaa2277759c1d9f11b719b72cb95456b4/third_party/WebKit/Source/modules/shapedetection/TextDetector.cpp [modify] https://crrev.com/2a78436aaa2277759c1d9f11b719b72cb95456b4/third_party/WebKit/Source/modules/shapedetection/TextDetector.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ab1a9331a441fa315edb669486ac1964788e47c7 commit ab1a9331a441fa315edb669486ac1964788e47c7 Author: junwei.fu <junwei.fu@intel.com> Date: Wed Feb 15 06:10:19 2017 RELAND: ShapeDetection: use mojom::Bitmap for mojo interface. Original CL got reverted due to conflit with another landed CL that need to use mojom::bitmap. Original CL description ------------------------------------------------ ShapeDetection: use mojom::Bitmap for mojo interface. This CL uses mojo::Bitmap for mojo ShapeDetection interfaces definition, so that the Detect API is completely flexible and friendly. BUG= 665488 TEST(Layout)= third_party/WebKit/LayoutTests/fast/shapedetection/shapedetection-creation.html third_party/WebKit/LayoutTests/fast/shapedetection/shapedetection-empty-input.html third_party/WebKit/LayoutTests/shapedetection/detection-HTMLCanvasElement.html third_party/WebKit/LayoutTests/shapedetection/detection-HTMLImageElement.html third_party/WebKit/LayoutTests/shapedetection/detection-HTMLVideoElement.html third_party/WebKit/LayoutTests/shapedetection/detection-ImageBitmap.html third_party/WebKit/LayoutTests/shapedetection/detection-ImageData.html Review-Url: https://codereview.chromium.org/2629433003 Cr-Commit-Position: refs/heads/master@{#446142} (cherry picked from commit 33adf4c85dd553eb607bcf9c02c5fa60c8738a68) Conflicts: third_party/WebKit/Source/modules/shapedetection/FaceDetector.cpp third_party/WebKit/Source/modules/shapedetection/TextDetector.cpp CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.mac:mac_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2681913003 Cr-Commit-Position: refs/heads/master@{#450582} [modify] https://crrev.com/ab1a9331a441fa315edb669486ac1964788e47c7/AUTHORS [modify] https://crrev.com/ab1a9331a441fa315edb669486ac1964788e47c7/chrome/android/BUILD.gn [modify] https://crrev.com/ab1a9331a441fa315edb669486ac1964788e47c7/chrome/android/java/src/org/chromium/chrome/browser/shapedetection/BarcodeDetectionImpl.java [modify] https://crrev.com/ab1a9331a441fa315edb669486ac1964788e47c7/chrome/android/java/src/org/chromium/chrome/browser/shapedetection/TextDetectionImpl.java [modify] https://crrev.com/ab1a9331a441fa315edb669486ac1964788e47c7/content/public/android/BUILD.gn [modify] https://crrev.com/ab1a9331a441fa315edb669486ac1964788e47c7/content/public/android/java/src/org/chromium/content/browser/shapedetection/FaceDetectionImpl.java [modify] https://crrev.com/ab1a9331a441fa315edb669486ac1964788e47c7/services/shape_detection/DEPS [modify] https://crrev.com/ab1a9331a441fa315edb669486ac1964788e47c7/services/shape_detection/barcode_detection_impl_mac.h [modify] https://crrev.com/ab1a9331a441fa315edb669486ac1964788e47c7/services/shape_detection/barcode_detection_impl_mac.mm [modify] https://crrev.com/ab1a9331a441fa315edb669486ac1964788e47c7/services/shape_detection/barcode_detection_impl_mac_unittest.mm [modify] https://crrev.com/ab1a9331a441fa315edb669486ac1964788e47c7/services/shape_detection/detection_utils_mac.h [modify] https://crrev.com/ab1a9331a441fa315edb669486ac1964788e47c7/services/shape_detection/detection_utils_mac.mm [modify] https://crrev.com/ab1a9331a441fa315edb669486ac1964788e47c7/services/shape_detection/face_detection_impl_mac.h [modify] https://crrev.com/ab1a9331a441fa315edb669486ac1964788e47c7/services/shape_detection/face_detection_impl_mac.mm [modify] https://crrev.com/ab1a9331a441fa315edb669486ac1964788e47c7/services/shape_detection/face_detection_impl_mac_unittest.mm [modify] https://crrev.com/ab1a9331a441fa315edb669486ac1964788e47c7/services/shape_detection/public/interfaces/BUILD.gn [modify] https://crrev.com/ab1a9331a441fa315edb669486ac1964788e47c7/services/shape_detection/public/interfaces/barcodedetection.mojom [modify] https://crrev.com/ab1a9331a441fa315edb669486ac1964788e47c7/services/shape_detection/public/interfaces/facedetection.mojom [modify] https://crrev.com/ab1a9331a441fa315edb669486ac1964788e47c7/services/shape_detection/public/interfaces/textdetection.mojom [modify] https://crrev.com/ab1a9331a441fa315edb669486ac1964788e47c7/third_party/WebKit/LayoutTests/shapedetection/resources/mock-barcodedetection.js [modify] https://crrev.com/ab1a9331a441fa315edb669486ac1964788e47c7/third_party/WebKit/LayoutTests/shapedetection/resources/mock-facedetection.js [modify] https://crrev.com/ab1a9331a441fa315edb669486ac1964788e47c7/third_party/WebKit/LayoutTests/shapedetection/resources/mock-textdetection.js [modify] https://crrev.com/ab1a9331a441fa315edb669486ac1964788e47c7/third_party/WebKit/Source/modules/shapedetection/BUILD.gn [modify] https://crrev.com/ab1a9331a441fa315edb669486ac1964788e47c7/third_party/WebKit/Source/modules/shapedetection/BarcodeDetector.cpp [modify] https://crrev.com/ab1a9331a441fa315edb669486ac1964788e47c7/third_party/WebKit/Source/modules/shapedetection/BarcodeDetector.h [modify] https://crrev.com/ab1a9331a441fa315edb669486ac1964788e47c7/third_party/WebKit/Source/modules/shapedetection/DEPS [modify] https://crrev.com/ab1a9331a441fa315edb669486ac1964788e47c7/third_party/WebKit/Source/modules/shapedetection/FaceDetector.cpp [modify] https://crrev.com/ab1a9331a441fa315edb669486ac1964788e47c7/third_party/WebKit/Source/modules/shapedetection/FaceDetector.h [modify] https://crrev.com/ab1a9331a441fa315edb669486ac1964788e47c7/third_party/WebKit/Source/modules/shapedetection/ShapeDetector.cpp [modify] https://crrev.com/ab1a9331a441fa315edb669486ac1964788e47c7/third_party/WebKit/Source/modules/shapedetection/ShapeDetector.h [modify] https://crrev.com/ab1a9331a441fa315edb669486ac1964788e47c7/third_party/WebKit/Source/modules/shapedetection/TextDetector.cpp [modify] https://crrev.com/ab1a9331a441fa315edb669486ac1964788e47c7/third_party/WebKit/Source/modules/shapedetection/TextDetector.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7b9838f84b0aef41622e9468ded89d0e52a3280f commit 7b9838f84b0aef41622e9468ded89d0e52a3280f Author: perkj <perkj@chromium.org> Date: Wed Feb 15 07:35:29 2017 Revert of RELAND: ShapeDetection: use mojom::Bitmap for mojo interface. (patchset #4 id:180001 of https://codereview.chromium.org/2681913003/ ) Reason for revert: Sorry - but this breaks blink layout tests on mac: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.11/builds/16336 Original issue's description: > RELAND: ShapeDetection: use mojom::Bitmap for mojo interface. > > Original CL got reverted due to conflit with another landed CL that need > to use mojom::bitmap. > > Original CL description ------------------------------------------------ > ShapeDetection: use mojom::Bitmap for mojo interface. > > This CL uses mojo::Bitmap for mojo ShapeDetection interfaces definition, > so that the Detect API is completely flexible and friendly. > > BUG= 665488 > TEST(Layout)= > third_party/WebKit/LayoutTests/fast/shapedetection/shapedetection-creation.html > third_party/WebKit/LayoutTests/fast/shapedetection/shapedetection-empty-input.html > third_party/WebKit/LayoutTests/shapedetection/detection-HTMLCanvasElement.html > third_party/WebKit/LayoutTests/shapedetection/detection-HTMLImageElement.html > third_party/WebKit/LayoutTests/shapedetection/detection-HTMLVideoElement.html > third_party/WebKit/LayoutTests/shapedetection/detection-ImageBitmap.html > third_party/WebKit/LayoutTests/shapedetection/detection-ImageData.html > > Review-Url: https://codereview.chromium.org/2629433003 > Cr-Commit-Position: refs/heads/master@{#446142} > (cherry picked from commit 33adf4c85dd553eb607bcf9c02c5fa60c8738a68) > > Conflicts: > third_party/WebKit/Source/modules/shapedetection/FaceDetector.cpp > third_party/WebKit/Source/modules/shapedetection/TextDetector.cpp > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.mac:mac_optional_gpu_tests_rel > > Review-Url: https://codereview.chromium.org/2681913003 > Cr-Commit-Position: refs/heads/master@{#450582} > Committed: https://chromium.googlesource.com/chromium/src/+/ab1a9331a441fa315edb669486ac1964788e47c7 TBR=rockot@chromium.org,dtrainor@chromium.org,haraken@chromium.org,leon.han@intel.com,mcasas@chromium.org,tsepez@chromium.org,xianglu@chromium.org,reed@google.com,bsalomon@google.com,junwei.fu@intel.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= 665488 Review-Url: https://codereview.chromium.org/2696143002 Cr-Commit-Position: refs/heads/master@{#450625} [modify] https://crrev.com/7b9838f84b0aef41622e9468ded89d0e52a3280f/AUTHORS [modify] https://crrev.com/7b9838f84b0aef41622e9468ded89d0e52a3280f/chrome/android/BUILD.gn [modify] https://crrev.com/7b9838f84b0aef41622e9468ded89d0e52a3280f/chrome/android/java/src/org/chromium/chrome/browser/shapedetection/BarcodeDetectionImpl.java [modify] https://crrev.com/7b9838f84b0aef41622e9468ded89d0e52a3280f/chrome/android/java/src/org/chromium/chrome/browser/shapedetection/TextDetectionImpl.java [modify] https://crrev.com/7b9838f84b0aef41622e9468ded89d0e52a3280f/content/public/android/BUILD.gn [modify] https://crrev.com/7b9838f84b0aef41622e9468ded89d0e52a3280f/content/public/android/java/src/org/chromium/content/browser/shapedetection/FaceDetectionImpl.java [modify] https://crrev.com/7b9838f84b0aef41622e9468ded89d0e52a3280f/services/shape_detection/DEPS [modify] https://crrev.com/7b9838f84b0aef41622e9468ded89d0e52a3280f/services/shape_detection/barcode_detection_impl_mac.h [modify] https://crrev.com/7b9838f84b0aef41622e9468ded89d0e52a3280f/services/shape_detection/barcode_detection_impl_mac.mm [modify] https://crrev.com/7b9838f84b0aef41622e9468ded89d0e52a3280f/services/shape_detection/barcode_detection_impl_mac_unittest.mm [modify] https://crrev.com/7b9838f84b0aef41622e9468ded89d0e52a3280f/services/shape_detection/detection_utils_mac.h [modify] https://crrev.com/7b9838f84b0aef41622e9468ded89d0e52a3280f/services/shape_detection/detection_utils_mac.mm [modify] https://crrev.com/7b9838f84b0aef41622e9468ded89d0e52a3280f/services/shape_detection/face_detection_impl_mac.h [modify] https://crrev.com/7b9838f84b0aef41622e9468ded89d0e52a3280f/services/shape_detection/face_detection_impl_mac.mm [modify] https://crrev.com/7b9838f84b0aef41622e9468ded89d0e52a3280f/services/shape_detection/face_detection_impl_mac_unittest.mm [modify] https://crrev.com/7b9838f84b0aef41622e9468ded89d0e52a3280f/services/shape_detection/public/interfaces/BUILD.gn [modify] https://crrev.com/7b9838f84b0aef41622e9468ded89d0e52a3280f/services/shape_detection/public/interfaces/barcodedetection.mojom [modify] https://crrev.com/7b9838f84b0aef41622e9468ded89d0e52a3280f/services/shape_detection/public/interfaces/facedetection.mojom [modify] https://crrev.com/7b9838f84b0aef41622e9468ded89d0e52a3280f/services/shape_detection/public/interfaces/textdetection.mojom [modify] https://crrev.com/7b9838f84b0aef41622e9468ded89d0e52a3280f/third_party/WebKit/LayoutTests/shapedetection/resources/mock-barcodedetection.js [modify] https://crrev.com/7b9838f84b0aef41622e9468ded89d0e52a3280f/third_party/WebKit/LayoutTests/shapedetection/resources/mock-facedetection.js [modify] https://crrev.com/7b9838f84b0aef41622e9468ded89d0e52a3280f/third_party/WebKit/LayoutTests/shapedetection/resources/mock-textdetection.js [modify] https://crrev.com/7b9838f84b0aef41622e9468ded89d0e52a3280f/third_party/WebKit/Source/modules/shapedetection/BUILD.gn [modify] https://crrev.com/7b9838f84b0aef41622e9468ded89d0e52a3280f/third_party/WebKit/Source/modules/shapedetection/BarcodeDetector.cpp [modify] https://crrev.com/7b9838f84b0aef41622e9468ded89d0e52a3280f/third_party/WebKit/Source/modules/shapedetection/BarcodeDetector.h [modify] https://crrev.com/7b9838f84b0aef41622e9468ded89d0e52a3280f/third_party/WebKit/Source/modules/shapedetection/DEPS [modify] https://crrev.com/7b9838f84b0aef41622e9468ded89d0e52a3280f/third_party/WebKit/Source/modules/shapedetection/FaceDetector.cpp [modify] https://crrev.com/7b9838f84b0aef41622e9468ded89d0e52a3280f/third_party/WebKit/Source/modules/shapedetection/FaceDetector.h [modify] https://crrev.com/7b9838f84b0aef41622e9468ded89d0e52a3280f/third_party/WebKit/Source/modules/shapedetection/ShapeDetector.cpp [modify] https://crrev.com/7b9838f84b0aef41622e9468ded89d0e52a3280f/third_party/WebKit/Source/modules/shapedetection/ShapeDetector.h [modify] https://crrev.com/7b9838f84b0aef41622e9468ded89d0e52a3280f/third_party/WebKit/Source/modules/shapedetection/TextDetector.cpp [modify] https://crrev.com/7b9838f84b0aef41622e9468ded89d0e52a3280f/third_party/WebKit/Source/modules/shapedetection/TextDetector.h
junwei.fu@intel.com what's the situation here? You seemed to have cracked it.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b1caeee1ee08c8b3bcaa423c8aa4a9f06e9ce40a commit b1caeee1ee08c8b3bcaa423c8aa4a9f06e9ce40a Author: junwei.fu <junwei.fu@intel.com> Date: Mon Mar 20 00:45:12 2017 RELAND: ShapeDetection: use mojom::Bitmap for mojo interface. Original CL got reverted due to shapedetection/detection-on-worker.html fail to fetch source for module skia/public/interfaces/bitmap.mojom. This CL includes the generated JS bindings for skia/public/interfaces/bitmap.mojom in the layout tests archive. Original CL description ------------------------------------------------ ShapeDetection: use mojom::Bitmap for mojo interface. This CL uses mojo::Bitmap for mojo ShapeDetection interfaces definition, so that the Detect API is completely flexible and friendly. BUG= 665488 TEST(Layout)= third_party/WebKit/LayoutTests/fast/shapedetection/shapedetection-creation.html third_party/WebKit/LayoutTests/fast/shapedetection/shapedetection-empty-input.html third_party/WebKit/LayoutTests/shapedetection/detection-HTMLCanvasElement.html third_party/WebKit/LayoutTests/shapedetection/detection-HTMLImageElement.html third_party/WebKit/LayoutTests/shapedetection/detection-HTMLVideoElement.html third_party/WebKit/LayoutTests/shapedetection/detection-ImageBitmap.html third_party/WebKit/LayoutTests/shapedetection/detection-ImageData.html Review-Url: https://codereview.chromium.org/2629433003 Cr-Commit-Position: refs/heads/master@{#446142} (cherry picked from commit 33adf4c85dd553eb607bcf9c02c5fa60c8738a68) Conflicts: third_party/WebKit/Source/modules/shapedetection/FaceDetector.cpp third_party/WebKit/Source/modules/shapedetection/TextDetector.cpp CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.mac:mac_optional_gpu_tests_rel TBR=rockot@chromium.org, dtrainor@chromium.org, haraken@chromium.org, bsalomon@google.com, tsepez@chromium.org since the gist of the CL hasn't changed. Review-Url: https://codereview.chromium.org/2681913003 Cr-Original-Commit-Position: refs/heads/master@{#450582} Review-Url: https://codereview.chromium.org/2753413002 Cr-Commit-Position: refs/heads/master@{#458010} [modify] https://crrev.com/b1caeee1ee08c8b3bcaa423c8aa4a9f06e9ce40a/AUTHORS [modify] https://crrev.com/b1caeee1ee08c8b3bcaa423c8aa4a9f06e9ce40a/BUILD.gn [modify] https://crrev.com/b1caeee1ee08c8b3bcaa423c8aa4a9f06e9ce40a/chrome/android/BUILD.gn [modify] https://crrev.com/b1caeee1ee08c8b3bcaa423c8aa4a9f06e9ce40a/chrome/android/java/src/org/chromium/chrome/browser/shapedetection/BarcodeDetectionImpl.java [modify] https://crrev.com/b1caeee1ee08c8b3bcaa423c8aa4a9f06e9ce40a/chrome/android/java/src/org/chromium/chrome/browser/shapedetection/TextDetectionImpl.java [modify] https://crrev.com/b1caeee1ee08c8b3bcaa423c8aa4a9f06e9ce40a/content/public/android/BUILD.gn [modify] https://crrev.com/b1caeee1ee08c8b3bcaa423c8aa4a9f06e9ce40a/content/public/android/java/src/org/chromium/content/browser/shapedetection/FaceDetectionImpl.java [modify] https://crrev.com/b1caeee1ee08c8b3bcaa423c8aa4a9f06e9ce40a/services/shape_detection/DEPS [modify] https://crrev.com/b1caeee1ee08c8b3bcaa423c8aa4a9f06e9ce40a/services/shape_detection/barcode_detection_impl_mac.h [modify] https://crrev.com/b1caeee1ee08c8b3bcaa423c8aa4a9f06e9ce40a/services/shape_detection/barcode_detection_impl_mac.mm [modify] https://crrev.com/b1caeee1ee08c8b3bcaa423c8aa4a9f06e9ce40a/services/shape_detection/barcode_detection_impl_mac_unittest.mm [modify] https://crrev.com/b1caeee1ee08c8b3bcaa423c8aa4a9f06e9ce40a/services/shape_detection/detection_utils_mac.h [modify] https://crrev.com/b1caeee1ee08c8b3bcaa423c8aa4a9f06e9ce40a/services/shape_detection/detection_utils_mac.mm [modify] https://crrev.com/b1caeee1ee08c8b3bcaa423c8aa4a9f06e9ce40a/services/shape_detection/face_detection_impl_mac.h [modify] https://crrev.com/b1caeee1ee08c8b3bcaa423c8aa4a9f06e9ce40a/services/shape_detection/face_detection_impl_mac.mm [modify] https://crrev.com/b1caeee1ee08c8b3bcaa423c8aa4a9f06e9ce40a/services/shape_detection/face_detection_impl_mac_unittest.mm [modify] https://crrev.com/b1caeee1ee08c8b3bcaa423c8aa4a9f06e9ce40a/services/shape_detection/public/interfaces/BUILD.gn [modify] https://crrev.com/b1caeee1ee08c8b3bcaa423c8aa4a9f06e9ce40a/services/shape_detection/public/interfaces/barcodedetection.mojom [modify] https://crrev.com/b1caeee1ee08c8b3bcaa423c8aa4a9f06e9ce40a/services/shape_detection/public/interfaces/facedetection.mojom [modify] https://crrev.com/b1caeee1ee08c8b3bcaa423c8aa4a9f06e9ce40a/services/shape_detection/public/interfaces/textdetection.mojom [modify] https://crrev.com/b1caeee1ee08c8b3bcaa423c8aa4a9f06e9ce40a/services/shape_detection/text_detection_impl_mac.h [modify] https://crrev.com/b1caeee1ee08c8b3bcaa423c8aa4a9f06e9ce40a/services/shape_detection/text_detection_impl_mac.mm [modify] https://crrev.com/b1caeee1ee08c8b3bcaa423c8aa4a9f06e9ce40a/services/shape_detection/text_detection_impl_mac_unittest.mm [modify] https://crrev.com/b1caeee1ee08c8b3bcaa423c8aa4a9f06e9ce40a/third_party/WebKit/LayoutTests/shapedetection/resources/mock-barcodedetection.js [modify] https://crrev.com/b1caeee1ee08c8b3bcaa423c8aa4a9f06e9ce40a/third_party/WebKit/LayoutTests/shapedetection/resources/mock-facedetection.js [modify] https://crrev.com/b1caeee1ee08c8b3bcaa423c8aa4a9f06e9ce40a/third_party/WebKit/LayoutTests/shapedetection/resources/mock-textdetection.js [modify] https://crrev.com/b1caeee1ee08c8b3bcaa423c8aa4a9f06e9ce40a/third_party/WebKit/Source/modules/shapedetection/BUILD.gn [modify] https://crrev.com/b1caeee1ee08c8b3bcaa423c8aa4a9f06e9ce40a/third_party/WebKit/Source/modules/shapedetection/BarcodeDetector.cpp [modify] https://crrev.com/b1caeee1ee08c8b3bcaa423c8aa4a9f06e9ce40a/third_party/WebKit/Source/modules/shapedetection/BarcodeDetector.h [modify] https://crrev.com/b1caeee1ee08c8b3bcaa423c8aa4a9f06e9ce40a/third_party/WebKit/Source/modules/shapedetection/DEPS [modify] https://crrev.com/b1caeee1ee08c8b3bcaa423c8aa4a9f06e9ce40a/third_party/WebKit/Source/modules/shapedetection/FaceDetector.cpp [modify] https://crrev.com/b1caeee1ee08c8b3bcaa423c8aa4a9f06e9ce40a/third_party/WebKit/Source/modules/shapedetection/FaceDetector.h [modify] https://crrev.com/b1caeee1ee08c8b3bcaa423c8aa4a9f06e9ce40a/third_party/WebKit/Source/modules/shapedetection/ShapeDetector.cpp [modify] https://crrev.com/b1caeee1ee08c8b3bcaa423c8aa4a9f06e9ce40a/third_party/WebKit/Source/modules/shapedetection/ShapeDetector.h [modify] https://crrev.com/b1caeee1ee08c8b3bcaa423c8aa4a9f06e9ce40a/third_party/WebKit/Source/modules/shapedetection/TextDetector.cpp [modify] https://crrev.com/b1caeee1ee08c8b3bcaa423c8aa4a9f06e9ce40a/third_party/WebKit/Source/modules/shapedetection/TextDetector.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0919785cfd8b70ffe8814e146fbc500b3e284b2b commit 0919785cfd8b70ffe8814e146fbc500b3e284b2b Author: vasilii <vasilii@chromium.org> Date: Mon Mar 20 10:21:08 2017 Revert of RELAND: ShapeDetection: use mojom::Bitmap for mojo interface. (patchset #2 id:20001 of https://codereview.chromium.org/2753413002/ ) Reason for revert: Broke shapedetection/detection-on-worker.html shapedetection/detection-security-test.html reliably: 18:14:35.412 4150 [10306:39683:0319/181429.446067:1229254778376:WARNING:url_request_job_manager.cc(90)] Failed to map: layout-test-mojom://content/shell/renderer/layout_test/frame_interface_registry 18:14:35.413 4150 [10306:39683:0319/181429.446194:1229254899173:WARNING:url_request_job_manager.cc(90)] Failed to map: layout-test-mojom://content/shell/renderer/layout_test/interface_registry 18:14:35.413 4150 [10308:771:0319/181429.450430:1229259136455:ERROR:mojo_context_state.cc(199)] Failed to fetch source for module "content/shell/renderer/layout_test/frame_interface_registry" 18:14:35.413 4150 [10308:771:0319/181429.450505:1229259209121:ERROR:mojo_context_state.cc(199)] Failed to fetch source for module "content/shell/renderer/layout_test/interface_registry" 18:14:35.413 4150 [10308:771:0319/181429.452582:1229261287723:ERROR:mojo_context_state.cc(199)] Failed to fetch source for module "skia/public/interfaces/bitmap.mojom" 18:14:35.414 4111 [46631/51882] shapedetection/detection-security-test.html failed unexpectedly (test timed out) Original issue's description: > RELAND: ShapeDetection: use mojom::Bitmap for mojo interface. > > Original CL got reverted due to shapedetection/detection-on-worker.html > fail to fetch source for module skia/public/interfaces/bitmap.mojom. > > This CL includes the generated JS bindings for skia/public/interfaces/bitmap.mojom > in the layout tests archive. > > Original CL description ------------------------------------------------ > ShapeDetection: use mojom::Bitmap for mojo interface. > > This CL uses mojo::Bitmap for mojo ShapeDetection interfaces definition, > so that the Detect API is completely flexible and friendly. > > BUG= 665488 > TEST(Layout)= > third_party/WebKit/LayoutTests/fast/shapedetection/shapedetection-creation.html > third_party/WebKit/LayoutTests/fast/shapedetection/shapedetection-empty-input.html > third_party/WebKit/LayoutTests/shapedetection/detection-HTMLCanvasElement.html > third_party/WebKit/LayoutTests/shapedetection/detection-HTMLImageElement.html > third_party/WebKit/LayoutTests/shapedetection/detection-HTMLVideoElement.html > third_party/WebKit/LayoutTests/shapedetection/detection-ImageBitmap.html > third_party/WebKit/LayoutTests/shapedetection/detection-ImageData.html > > Review-Url: https://codereview.chromium.org/2629433003 > Cr-Commit-Position: refs/heads/master@{#446142} > (cherry picked from commit 33adf4c85dd553eb607bcf9c02c5fa60c8738a68) > > Conflicts: > third_party/WebKit/Source/modules/shapedetection/FaceDetector.cpp > third_party/WebKit/Source/modules/shapedetection/TextDetector.cpp > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.mac:mac_optional_gpu_tests_rel > > TBR=rockot@chromium.org, dtrainor@chromium.org, haraken@chromium.org, bsalomon@google.com, tsepez@chromium.org > since the gist of the CL hasn't changed. > > Review-Url: https://codereview.chromium.org/2681913003 > Cr-Original-Commit-Position: refs/heads/master@{#450582} > Review-Url: https://codereview.chromium.org/2753413002 > Cr-Commit-Position: refs/heads/master@{#458010} > Committed: https://chromium.googlesource.com/chromium/src/+/b1caeee1ee08c8b3bcaa423c8aa4a9f06e9ce40a TBR=bsalomon@google.com,dtrainor@chromium.org,haraken@chromium.org,rockot@chromium.org,tsepez@chromium.org,mcasas@chromium.org,dpranke@chromium.org,junwei.fu@intel.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= 665488 Review-Url: https://codereview.chromium.org/2755393002 Cr-Commit-Position: refs/heads/master@{#458033} [modify] https://crrev.com/0919785cfd8b70ffe8814e146fbc500b3e284b2b/AUTHORS [modify] https://crrev.com/0919785cfd8b70ffe8814e146fbc500b3e284b2b/BUILD.gn [modify] https://crrev.com/0919785cfd8b70ffe8814e146fbc500b3e284b2b/chrome/android/BUILD.gn [modify] https://crrev.com/0919785cfd8b70ffe8814e146fbc500b3e284b2b/chrome/android/java/src/org/chromium/chrome/browser/shapedetection/BarcodeDetectionImpl.java [modify] https://crrev.com/0919785cfd8b70ffe8814e146fbc500b3e284b2b/chrome/android/java/src/org/chromium/chrome/browser/shapedetection/TextDetectionImpl.java [modify] https://crrev.com/0919785cfd8b70ffe8814e146fbc500b3e284b2b/content/public/android/BUILD.gn [modify] https://crrev.com/0919785cfd8b70ffe8814e146fbc500b3e284b2b/content/public/android/java/src/org/chromium/content/browser/shapedetection/FaceDetectionImpl.java [modify] https://crrev.com/0919785cfd8b70ffe8814e146fbc500b3e284b2b/services/shape_detection/DEPS [modify] https://crrev.com/0919785cfd8b70ffe8814e146fbc500b3e284b2b/services/shape_detection/barcode_detection_impl_mac.h [modify] https://crrev.com/0919785cfd8b70ffe8814e146fbc500b3e284b2b/services/shape_detection/barcode_detection_impl_mac.mm [modify] https://crrev.com/0919785cfd8b70ffe8814e146fbc500b3e284b2b/services/shape_detection/barcode_detection_impl_mac_unittest.mm [modify] https://crrev.com/0919785cfd8b70ffe8814e146fbc500b3e284b2b/services/shape_detection/detection_utils_mac.h [modify] https://crrev.com/0919785cfd8b70ffe8814e146fbc500b3e284b2b/services/shape_detection/detection_utils_mac.mm [modify] https://crrev.com/0919785cfd8b70ffe8814e146fbc500b3e284b2b/services/shape_detection/face_detection_impl_mac.h [modify] https://crrev.com/0919785cfd8b70ffe8814e146fbc500b3e284b2b/services/shape_detection/face_detection_impl_mac.mm [modify] https://crrev.com/0919785cfd8b70ffe8814e146fbc500b3e284b2b/services/shape_detection/face_detection_impl_mac_unittest.mm [modify] https://crrev.com/0919785cfd8b70ffe8814e146fbc500b3e284b2b/services/shape_detection/public/interfaces/BUILD.gn [modify] https://crrev.com/0919785cfd8b70ffe8814e146fbc500b3e284b2b/services/shape_detection/public/interfaces/barcodedetection.mojom [modify] https://crrev.com/0919785cfd8b70ffe8814e146fbc500b3e284b2b/services/shape_detection/public/interfaces/facedetection.mojom [modify] https://crrev.com/0919785cfd8b70ffe8814e146fbc500b3e284b2b/services/shape_detection/public/interfaces/textdetection.mojom [modify] https://crrev.com/0919785cfd8b70ffe8814e146fbc500b3e284b2b/services/shape_detection/text_detection_impl_mac.h [modify] https://crrev.com/0919785cfd8b70ffe8814e146fbc500b3e284b2b/services/shape_detection/text_detection_impl_mac.mm [modify] https://crrev.com/0919785cfd8b70ffe8814e146fbc500b3e284b2b/services/shape_detection/text_detection_impl_mac_unittest.mm [modify] https://crrev.com/0919785cfd8b70ffe8814e146fbc500b3e284b2b/third_party/WebKit/LayoutTests/shapedetection/resources/mock-barcodedetection.js [modify] https://crrev.com/0919785cfd8b70ffe8814e146fbc500b3e284b2b/third_party/WebKit/LayoutTests/shapedetection/resources/mock-facedetection.js [modify] https://crrev.com/0919785cfd8b70ffe8814e146fbc500b3e284b2b/third_party/WebKit/LayoutTests/shapedetection/resources/mock-textdetection.js [modify] https://crrev.com/0919785cfd8b70ffe8814e146fbc500b3e284b2b/third_party/WebKit/Source/modules/shapedetection/BUILD.gn [modify] https://crrev.com/0919785cfd8b70ffe8814e146fbc500b3e284b2b/third_party/WebKit/Source/modules/shapedetection/BarcodeDetector.cpp [modify] https://crrev.com/0919785cfd8b70ffe8814e146fbc500b3e284b2b/third_party/WebKit/Source/modules/shapedetection/BarcodeDetector.h [modify] https://crrev.com/0919785cfd8b70ffe8814e146fbc500b3e284b2b/third_party/WebKit/Source/modules/shapedetection/DEPS [modify] https://crrev.com/0919785cfd8b70ffe8814e146fbc500b3e284b2b/third_party/WebKit/Source/modules/shapedetection/FaceDetector.cpp [modify] https://crrev.com/0919785cfd8b70ffe8814e146fbc500b3e284b2b/third_party/WebKit/Source/modules/shapedetection/FaceDetector.h [modify] https://crrev.com/0919785cfd8b70ffe8814e146fbc500b3e284b2b/third_party/WebKit/Source/modules/shapedetection/ShapeDetector.cpp [modify] https://crrev.com/0919785cfd8b70ffe8814e146fbc500b3e284b2b/third_party/WebKit/Source/modules/shapedetection/ShapeDetector.h [modify] https://crrev.com/0919785cfd8b70ffe8814e146fbc500b3e284b2b/third_party/WebKit/Source/modules/shapedetection/TextDetector.cpp [modify] https://crrev.com/0919785cfd8b70ffe8814e146fbc500b3e284b2b/third_party/WebKit/Source/modules/shapedetection/TextDetector.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build/+/890c03dc5c040219372674ac321765460e01d016 commit 890c03dc5c040219372674ac321765460e01d016 Author: junweifu <junwei.fu@intel.com> Date: Tue Mar 21 21:45:51 2017 Add gen/skia/public/interfaces to generated bindings paths Needed for the reland in https://codereview.chromium.org/2765723002/, which was reverted due to bitmap.mojom can't be fetched in layout test. BUG= 665488 Change-Id: Ia18d7dba5d7f15ddcae1d450a848adf2981767fe Reviewed-on: https://chromium-review.googlesource.com/457267 Reviewed-by: Dirk Pranke <dpranke@chromium.org> Commit-Queue: Dirk Pranke <dpranke@chromium.org> [modify] https://crrev.com/890c03dc5c040219372674ac321765460e01d016/scripts/slave/zip_build.py
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/11a82c3aaabd39fc3a0981a6e66bf870cc46d5e8 commit 11a82c3aaabd39fc3a0981a6e66bf870cc46d5e8 Author: junwei.fu <junwei.fu@intel.com> Date: Wed Mar 22 07:09:29 2017 RELAND: ShapeDetection: use mojom::Bitmap for mojo interface. Original CL got reverted due to shapedetection/detection-on-worker.html fail to fetch source for module skia/public/interfaces/bitmap.mojom. This CL add gen/skia/public/interfaces to generated bindings paths. Original CL description ------------------------------------------------ ShapeDetection: use mojom::Bitmap for mojo interface. This CL uses mojo::Bitmap for mojo ShapeDetection interfaces definition, so that the Detect API is completely flexible and friendly. BUG= 665488 TEST(Layout)= third_party/WebKit/LayoutTests/fast/shapedetection/shapedetection-creation.html third_party/WebKit/LayoutTests/fast/shapedetection/shapedetection-empty-input.html third_party/WebKit/LayoutTests/shapedetection/detection-HTMLCanvasElement.html third_party/WebKit/LayoutTests/shapedetection/detection-HTMLImageElement.html third_party/WebKit/LayoutTests/shapedetection/detection-HTMLVideoElement.html third_party/WebKit/LayoutTests/shapedetection/detection-ImageBitmap.html third_party/WebKit/LayoutTests/shapedetection/detection-ImageData.html Review-Url: https://codereview.chromium.org/2629433003 Cr-Commit-Position: refs/heads/master@{#446142} (cherry picked from commit 33adf4c85dd553eb607bcf9c02c5fa60c8738a68) Conflicts: third_party/WebKit/Source/modules/shapedetection/FaceDetector.cpp third_party/WebKit/Source/modules/shapedetection/TextDetector.cpp CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.mac:mac_optional_gpu_tests_rel TBR=rockot@chromium.org, dtrainor@chromium.org, haraken@chromium.org, bsalomon@google.com, tsepez@chromium.org since the gist of the CL hasn't changed. Review-Url: https://codereview.chromium.org/2681913003 Cr-Original-Original-Commit-Position: refs/heads/master@{#450582} Review-Url: https://codereview.chromium.org/2753413002 Cr-Original-Commit-Position: refs/heads/master@{#458010} Review-Url: https://codereview.chromium.org/2765723002 Cr-Commit-Position: refs/heads/master@{#458657} [modify] https://crrev.com/11a82c3aaabd39fc3a0981a6e66bf870cc46d5e8/AUTHORS [modify] https://crrev.com/11a82c3aaabd39fc3a0981a6e66bf870cc46d5e8/chrome/android/BUILD.gn [modify] https://crrev.com/11a82c3aaabd39fc3a0981a6e66bf870cc46d5e8/chrome/android/java/src/org/chromium/chrome/browser/shapedetection/BarcodeDetectionImpl.java [modify] https://crrev.com/11a82c3aaabd39fc3a0981a6e66bf870cc46d5e8/chrome/android/java/src/org/chromium/chrome/browser/shapedetection/TextDetectionImpl.java [modify] https://crrev.com/11a82c3aaabd39fc3a0981a6e66bf870cc46d5e8/content/public/android/BUILD.gn [modify] https://crrev.com/11a82c3aaabd39fc3a0981a6e66bf870cc46d5e8/content/public/android/java/src/org/chromium/content/browser/shapedetection/FaceDetectionImpl.java [modify] https://crrev.com/11a82c3aaabd39fc3a0981a6e66bf870cc46d5e8/services/shape_detection/DEPS [modify] https://crrev.com/11a82c3aaabd39fc3a0981a6e66bf870cc46d5e8/services/shape_detection/barcode_detection_impl_mac.h [modify] https://crrev.com/11a82c3aaabd39fc3a0981a6e66bf870cc46d5e8/services/shape_detection/barcode_detection_impl_mac.mm [modify] https://crrev.com/11a82c3aaabd39fc3a0981a6e66bf870cc46d5e8/services/shape_detection/barcode_detection_impl_mac_unittest.mm [modify] https://crrev.com/11a82c3aaabd39fc3a0981a6e66bf870cc46d5e8/services/shape_detection/detection_utils_mac.h [modify] https://crrev.com/11a82c3aaabd39fc3a0981a6e66bf870cc46d5e8/services/shape_detection/detection_utils_mac.mm [modify] https://crrev.com/11a82c3aaabd39fc3a0981a6e66bf870cc46d5e8/services/shape_detection/face_detection_impl_mac.h [modify] https://crrev.com/11a82c3aaabd39fc3a0981a6e66bf870cc46d5e8/services/shape_detection/face_detection_impl_mac.mm [modify] https://crrev.com/11a82c3aaabd39fc3a0981a6e66bf870cc46d5e8/services/shape_detection/face_detection_impl_mac_unittest.mm [modify] https://crrev.com/11a82c3aaabd39fc3a0981a6e66bf870cc46d5e8/services/shape_detection/public/interfaces/BUILD.gn [modify] https://crrev.com/11a82c3aaabd39fc3a0981a6e66bf870cc46d5e8/services/shape_detection/public/interfaces/barcodedetection.mojom [modify] https://crrev.com/11a82c3aaabd39fc3a0981a6e66bf870cc46d5e8/services/shape_detection/public/interfaces/facedetection.mojom [modify] https://crrev.com/11a82c3aaabd39fc3a0981a6e66bf870cc46d5e8/services/shape_detection/public/interfaces/textdetection.mojom [modify] https://crrev.com/11a82c3aaabd39fc3a0981a6e66bf870cc46d5e8/services/shape_detection/text_detection_impl_mac.h [modify] https://crrev.com/11a82c3aaabd39fc3a0981a6e66bf870cc46d5e8/services/shape_detection/text_detection_impl_mac.mm [modify] https://crrev.com/11a82c3aaabd39fc3a0981a6e66bf870cc46d5e8/services/shape_detection/text_detection_impl_mac_unittest.mm [modify] https://crrev.com/11a82c3aaabd39fc3a0981a6e66bf870cc46d5e8/third_party/WebKit/LayoutTests/shapedetection/resources/mock-barcodedetection.js [modify] https://crrev.com/11a82c3aaabd39fc3a0981a6e66bf870cc46d5e8/third_party/WebKit/LayoutTests/shapedetection/resources/mock-facedetection.js [modify] https://crrev.com/11a82c3aaabd39fc3a0981a6e66bf870cc46d5e8/third_party/WebKit/LayoutTests/shapedetection/resources/mock-textdetection.js [modify] https://crrev.com/11a82c3aaabd39fc3a0981a6e66bf870cc46d5e8/third_party/WebKit/Source/modules/shapedetection/BUILD.gn [modify] https://crrev.com/11a82c3aaabd39fc3a0981a6e66bf870cc46d5e8/third_party/WebKit/Source/modules/shapedetection/BarcodeDetector.cpp [modify] https://crrev.com/11a82c3aaabd39fc3a0981a6e66bf870cc46d5e8/third_party/WebKit/Source/modules/shapedetection/BarcodeDetector.h [modify] https://crrev.com/11a82c3aaabd39fc3a0981a6e66bf870cc46d5e8/third_party/WebKit/Source/modules/shapedetection/DEPS [modify] https://crrev.com/11a82c3aaabd39fc3a0981a6e66bf870cc46d5e8/third_party/WebKit/Source/modules/shapedetection/FaceDetector.cpp [modify] https://crrev.com/11a82c3aaabd39fc3a0981a6e66bf870cc46d5e8/third_party/WebKit/Source/modules/shapedetection/FaceDetector.h [modify] https://crrev.com/11a82c3aaabd39fc3a0981a6e66bf870cc46d5e8/third_party/WebKit/Source/modules/shapedetection/ShapeDetector.cpp [modify] https://crrev.com/11a82c3aaabd39fc3a0981a6e66bf870cc46d5e8/third_party/WebKit/Source/modules/shapedetection/ShapeDetector.h [modify] https://crrev.com/11a82c3aaabd39fc3a0981a6e66bf870cc46d5e8/third_party/WebKit/Source/modules/shapedetection/TextDetector.cpp [modify] https://crrev.com/11a82c3aaabd39fc3a0981a6e66bf870cc46d5e8/third_party/WebKit/Source/modules/shapedetection/TextDetector.h
Created a CL https://codereview.chromium.org/2771703002/ to address a missing part.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f59872240739c45017e90aa1be20548177d6df59 commit f59872240739c45017e90aa1be20548177d6df59 Author: mcasas <mcasas@chromium.org> Date: Thu Mar 23 00:51:37 2017 Shape Detection: initialize all mojo::Bitmap fields This CL initializes all the fields of the newly allocated skia::mojom::blink::Bitmap before sending it over mojo, otherwise I get [...:ERROR:validation_errors.cc(87)] Invalid message: VALIDATION_ERROR_DESERIALIZATION_FAILED when running a Chromium build with the demos - https://codepen.io/miguelao/full/ygxVqg - https://codepen.io/miguelao/full/wgrYjZ - https://codepen.io/miguelao/full/ORYbbm Interestingly, content_browsertests are passing both in the bots and locally. Perhaps a different deserialization validation logic is used in different cases? BUG= 665488 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.mac:mac_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2771703002 Cr-Commit-Position: refs/heads/master@{#458960} [modify] https://crrev.com/f59872240739c45017e90aa1be20548177d6df59/third_party/WebKit/Source/modules/shapedetection/ShapeDetector.cpp
After #16 landed in https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Linux%20Trusty%20MSAN/builds/882, MSAN is not going red anymore, I think the initialization did the trick.
< copy of https://bugs.chromium.org/p/chromium/issues/detail?id=707689#c6 > I'm running third_party/WebKit/Tools/Scripts/run-webkit-tests -t gn shapedetection/*.html --verbose --repeat-each=20 --order=random on master and on a side branch where I reverted https://chromium.googlesource.com/chromium/src.git/+/f59872240739c45017e90aa1be20548177d6df59 https://chromium.googlesource.com/chromium/src.git/+/11a82c3aaabd39fc3a0981a6e66bf870cc46d5e8 (https://crrev.com/2771703002 and https://crrev.com/2629433003, resp.) and it seems like reverting those two fixes the flake, but otherwise I'm not sure what's happening here.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7f2e5dcdcecc501ddf56396c2846d3ebfe4fa46f commit 7f2e5dcdcecc501ddf56396c2846d3ebfe4fa46f Author: mcasas <mcasas@chromium.org> Date: Thu Apr 06 21:58:38 2017 REVERT: ShapeDetection: use mojom::Bitmap for mojo interface. This CL reverts two landed CLs, namely: https://chromium.googlesource.com/chromium/src.git/+/f59872240739c45017e90aa1be20548177d6df59 https://chromium.googlesource.com/chromium/src.git/+/11a82c3aaabd39fc3a0981a6e66bf870cc46d5e8 (reviewed in https://crrev.com/2771703002 and https://crrev.com/2765723002, resp.), because they seemed to have introduced a flake in the associated LayoutTests. TBR=rockot@chromium.org, dtrainor@chromium.org, haraken@chromium.org, bsalomon@google.com, tsepez@chromium.org BUG= 665488 , 707689 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.mac:mac_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2799153005 Cr-Commit-Position: refs/heads/master@{#462639} [modify] https://crrev.com/7f2e5dcdcecc501ddf56396c2846d3ebfe4fa46f/AUTHORS [modify] https://crrev.com/7f2e5dcdcecc501ddf56396c2846d3ebfe4fa46f/chrome/android/BUILD.gn [modify] https://crrev.com/7f2e5dcdcecc501ddf56396c2846d3ebfe4fa46f/chrome/android/java/src/org/chromium/chrome/browser/shapedetection/BarcodeDetectionImpl.java [modify] https://crrev.com/7f2e5dcdcecc501ddf56396c2846d3ebfe4fa46f/chrome/android/java/src/org/chromium/chrome/browser/shapedetection/TextDetectionImpl.java [modify] https://crrev.com/7f2e5dcdcecc501ddf56396c2846d3ebfe4fa46f/content/public/android/BUILD.gn [modify] https://crrev.com/7f2e5dcdcecc501ddf56396c2846d3ebfe4fa46f/content/public/android/java/src/org/chromium/content/browser/shapedetection/FaceDetectionImpl.java [modify] https://crrev.com/7f2e5dcdcecc501ddf56396c2846d3ebfe4fa46f/services/shape_detection/DEPS [modify] https://crrev.com/7f2e5dcdcecc501ddf56396c2846d3ebfe4fa46f/services/shape_detection/barcode_detection_impl_mac.h [modify] https://crrev.com/7f2e5dcdcecc501ddf56396c2846d3ebfe4fa46f/services/shape_detection/barcode_detection_impl_mac.mm [modify] https://crrev.com/7f2e5dcdcecc501ddf56396c2846d3ebfe4fa46f/services/shape_detection/barcode_detection_impl_mac_unittest.mm [modify] https://crrev.com/7f2e5dcdcecc501ddf56396c2846d3ebfe4fa46f/services/shape_detection/detection_utils_mac.h [modify] https://crrev.com/7f2e5dcdcecc501ddf56396c2846d3ebfe4fa46f/services/shape_detection/detection_utils_mac.mm [modify] https://crrev.com/7f2e5dcdcecc501ddf56396c2846d3ebfe4fa46f/services/shape_detection/face_detection_impl_mac.h [modify] https://crrev.com/7f2e5dcdcecc501ddf56396c2846d3ebfe4fa46f/services/shape_detection/face_detection_impl_mac.mm [modify] https://crrev.com/7f2e5dcdcecc501ddf56396c2846d3ebfe4fa46f/services/shape_detection/face_detection_impl_mac_unittest.mm [modify] https://crrev.com/7f2e5dcdcecc501ddf56396c2846d3ebfe4fa46f/services/shape_detection/public/interfaces/BUILD.gn [modify] https://crrev.com/7f2e5dcdcecc501ddf56396c2846d3ebfe4fa46f/services/shape_detection/public/interfaces/barcodedetection.mojom [modify] https://crrev.com/7f2e5dcdcecc501ddf56396c2846d3ebfe4fa46f/services/shape_detection/public/interfaces/facedetection.mojom [modify] https://crrev.com/7f2e5dcdcecc501ddf56396c2846d3ebfe4fa46f/services/shape_detection/public/interfaces/textdetection.mojom [modify] https://crrev.com/7f2e5dcdcecc501ddf56396c2846d3ebfe4fa46f/services/shape_detection/text_detection_impl_mac.h [modify] https://crrev.com/7f2e5dcdcecc501ddf56396c2846d3ebfe4fa46f/services/shape_detection/text_detection_impl_mac.mm [modify] https://crrev.com/7f2e5dcdcecc501ddf56396c2846d3ebfe4fa46f/services/shape_detection/text_detection_impl_mac_unittest.mm [modify] https://crrev.com/7f2e5dcdcecc501ddf56396c2846d3ebfe4fa46f/third_party/WebKit/LayoutTests/shapedetection/resources/mock-barcodedetection.js [modify] https://crrev.com/7f2e5dcdcecc501ddf56396c2846d3ebfe4fa46f/third_party/WebKit/LayoutTests/shapedetection/resources/mock-facedetection.js [modify] https://crrev.com/7f2e5dcdcecc501ddf56396c2846d3ebfe4fa46f/third_party/WebKit/LayoutTests/shapedetection/resources/mock-textdetection.js [modify] https://crrev.com/7f2e5dcdcecc501ddf56396c2846d3ebfe4fa46f/third_party/WebKit/Source/modules/shapedetection/BUILD.gn [modify] https://crrev.com/7f2e5dcdcecc501ddf56396c2846d3ebfe4fa46f/third_party/WebKit/Source/modules/shapedetection/BarcodeDetector.cpp [modify] https://crrev.com/7f2e5dcdcecc501ddf56396c2846d3ebfe4fa46f/third_party/WebKit/Source/modules/shapedetection/BarcodeDetector.h [modify] https://crrev.com/7f2e5dcdcecc501ddf56396c2846d3ebfe4fa46f/third_party/WebKit/Source/modules/shapedetection/DEPS [modify] https://crrev.com/7f2e5dcdcecc501ddf56396c2846d3ebfe4fa46f/third_party/WebKit/Source/modules/shapedetection/FaceDetector.cpp [modify] https://crrev.com/7f2e5dcdcecc501ddf56396c2846d3ebfe4fa46f/third_party/WebKit/Source/modules/shapedetection/FaceDetector.h [modify] https://crrev.com/7f2e5dcdcecc501ddf56396c2846d3ebfe4fa46f/third_party/WebKit/Source/modules/shapedetection/ShapeDetector.cpp [modify] https://crrev.com/7f2e5dcdcecc501ddf56396c2846d3ebfe4fa46f/third_party/WebKit/Source/modules/shapedetection/ShapeDetector.h [modify] https://crrev.com/7f2e5dcdcecc501ddf56396c2846d3ebfe4fa46f/third_party/WebKit/Source/modules/shapedetection/TextDetector.cpp [modify] https://crrev.com/7f2e5dcdcecc501ddf56396c2846d3ebfe4fa46f/third_party/WebKit/Source/modules/shapedetection/TextDetector.h
hey junwei.fu@intel.com what's the situation with this migration?
The layout tests are still random time out on master branch that block the CL, i am trying to fix it.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/31eb1a542aea4050d9b17fd7255d366499dedede commit 31eb1a542aea4050d9b17fd7255d366499dedede Author: junwei.fu <junwei.fu@intel.com> Date: Fri Jun 02 07:35:56 2017 RELAND2: ShapeDetection: use mojom::Bitmap for mojo interface. Original CL got reverted due to test cases are concurrent in same script context, it will cause random crash/time out. CL [1] has resolved the random issue, so rebase the commit align with the latest code. Reland implementation of detecting on mac platform, layout tests files, interface definition in mojom file and implementation in /Source/modules/shapedetion. Implementation on Android platform is new code include all of java files. [1] https://chromium-review.googlesource.com/475077 Original CL description ------------------------------------------------ ShapeDetection: use mojom::Bitmap for mojo interface. This CL uses mojo::Bitmap for mojo ShapeDetection interfaces definition, so that the Detect API is completely flexible and friendly. BUG= 665488 TEST(Layout)= third_party/WebKit/LayoutTests/fast/shapedetection/shapedetection-creation.html third_party/WebKit/LayoutTests/fast/shapedetection/shapedetection-empty-input.html third_party/WebKit/LayoutTests/shapedetection/detection-HTMLCanvasElement.html third_party/WebKit/LayoutTests/shapedetection/detection-HTMLImageElement.html third_party/WebKit/LayoutTests/shapedetection/detection-HTMLVideoElement.html third_party/WebKit/LayoutTests/shapedetection/detection-ImageBitmap.html third_party/WebKit/LayoutTests/shapedetection/detection-ImageData.html Review-Url: https://codereview.chromium.org/2629433003 Cr-Commit-Position: refs/heads/master@{#446142} CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.mac:mac_optional_gpu_tests_rel TBR=rockot@chromium.org, dtrainor@chromium.org, haraken@chromium.org since the gist of the CL hasn't changed. Review-Url: https://codereview.chromium.org/2681913003 Cr-Original-Original-Original-Commit-Position: refs/heads/master@{#450582} Review-Url: https://codereview.chromium.org/2753413002 Cr-Original-Original-Commit-Position: refs/heads/master@{#458010} Review-Url: https://codereview.chromium.org/2765723002 Cr-Original-Commit-Position: refs/heads/master@{#458657} Review-Url: https://codereview.chromium.org/2875243002 Cr-Commit-Position: refs/heads/master@{#476598} [modify] https://crrev.com/31eb1a542aea4050d9b17fd7255d366499dedede/chrome/android/BUILD.gn [modify] https://crrev.com/31eb1a542aea4050d9b17fd7255d366499dedede/services/BUILD.gn [modify] https://crrev.com/31eb1a542aea4050d9b17fd7255d366499dedede/services/shape_detection/BUILD.gn [modify] https://crrev.com/31eb1a542aea4050d9b17fd7255d366499dedede/services/shape_detection/DEPS [modify] https://crrev.com/31eb1a542aea4050d9b17fd7255d366499dedede/services/shape_detection/android/java/src/org/chromium/shape_detection/BarcodeDetectionImpl.java [add] https://crrev.com/31eb1a542aea4050d9b17fd7255d366499dedede/services/shape_detection/android/java/src/org/chromium/shape_detection/BitmapUtils.java [modify] https://crrev.com/31eb1a542aea4050d9b17fd7255d366499dedede/services/shape_detection/android/java/src/org/chromium/shape_detection/FaceDetectionImpl.java [modify] https://crrev.com/31eb1a542aea4050d9b17fd7255d366499dedede/services/shape_detection/android/java/src/org/chromium/shape_detection/FaceDetectionImplGmsCore.java [delete] https://crrev.com/de8768ff87be6c854b998864584d0c7c2e3adfea/services/shape_detection/android/java/src/org/chromium/shape_detection/SharedBufferUtils.java [modify] https://crrev.com/31eb1a542aea4050d9b17fd7255d366499dedede/services/shape_detection/android/java/src/org/chromium/shape_detection/TextDetectionImpl.java [add] https://crrev.com/31eb1a542aea4050d9b17fd7255d366499dedede/services/shape_detection/android/junit/src/org/chromium/shape_detection/BitmapUtilsTest.java [delete] https://crrev.com/de8768ff87be6c854b998864584d0c7c2e3adfea/services/shape_detection/android/junit/src/org/chromium/shape_detection/SharedBufferUtilsTest.java [modify] https://crrev.com/31eb1a542aea4050d9b17fd7255d366499dedede/services/shape_detection/barcode_detection_impl_mac.h [modify] https://crrev.com/31eb1a542aea4050d9b17fd7255d366499dedede/services/shape_detection/barcode_detection_impl_mac.mm [modify] https://crrev.com/31eb1a542aea4050d9b17fd7255d366499dedede/services/shape_detection/barcode_detection_impl_mac_unittest.mm [modify] https://crrev.com/31eb1a542aea4050d9b17fd7255d366499dedede/services/shape_detection/detection_utils_mac.h [modify] https://crrev.com/31eb1a542aea4050d9b17fd7255d366499dedede/services/shape_detection/detection_utils_mac.mm [modify] https://crrev.com/31eb1a542aea4050d9b17fd7255d366499dedede/services/shape_detection/face_detection_impl_mac.h [modify] https://crrev.com/31eb1a542aea4050d9b17fd7255d366499dedede/services/shape_detection/face_detection_impl_mac.mm [modify] https://crrev.com/31eb1a542aea4050d9b17fd7255d366499dedede/services/shape_detection/face_detection_impl_mac_unittest.mm [modify] https://crrev.com/31eb1a542aea4050d9b17fd7255d366499dedede/services/shape_detection/public/interfaces/BUILD.gn [modify] https://crrev.com/31eb1a542aea4050d9b17fd7255d366499dedede/services/shape_detection/public/interfaces/barcodedetection.mojom [modify] https://crrev.com/31eb1a542aea4050d9b17fd7255d366499dedede/services/shape_detection/public/interfaces/facedetection.mojom [modify] https://crrev.com/31eb1a542aea4050d9b17fd7255d366499dedede/services/shape_detection/public/interfaces/textdetection.mojom [modify] https://crrev.com/31eb1a542aea4050d9b17fd7255d366499dedede/services/shape_detection/text_detection_impl_mac.h [modify] https://crrev.com/31eb1a542aea4050d9b17fd7255d366499dedede/services/shape_detection/text_detection_impl_mac.mm [modify] https://crrev.com/31eb1a542aea4050d9b17fd7255d366499dedede/services/shape_detection/text_detection_impl_mac_unittest.mm [modify] https://crrev.com/31eb1a542aea4050d9b17fd7255d366499dedede/third_party/WebKit/LayoutTests/shapedetection/resources/mock-barcodedetection.js [modify] https://crrev.com/31eb1a542aea4050d9b17fd7255d366499dedede/third_party/WebKit/LayoutTests/shapedetection/resources/mock-facedetection.js [modify] https://crrev.com/31eb1a542aea4050d9b17fd7255d366499dedede/third_party/WebKit/LayoutTests/shapedetection/resources/mock-textdetection.js [modify] https://crrev.com/31eb1a542aea4050d9b17fd7255d366499dedede/third_party/WebKit/Source/modules/shapedetection/BUILD.gn [modify] https://crrev.com/31eb1a542aea4050d9b17fd7255d366499dedede/third_party/WebKit/Source/modules/shapedetection/BarcodeDetector.cpp [modify] https://crrev.com/31eb1a542aea4050d9b17fd7255d366499dedede/third_party/WebKit/Source/modules/shapedetection/BarcodeDetector.h [modify] https://crrev.com/31eb1a542aea4050d9b17fd7255d366499dedede/third_party/WebKit/Source/modules/shapedetection/DEPS [modify] https://crrev.com/31eb1a542aea4050d9b17fd7255d366499dedede/third_party/WebKit/Source/modules/shapedetection/FaceDetector.cpp [modify] https://crrev.com/31eb1a542aea4050d9b17fd7255d366499dedede/third_party/WebKit/Source/modules/shapedetection/FaceDetector.h [modify] https://crrev.com/31eb1a542aea4050d9b17fd7255d366499dedede/third_party/WebKit/Source/modules/shapedetection/ShapeDetector.cpp [modify] https://crrev.com/31eb1a542aea4050d9b17fd7255d366499dedede/third_party/WebKit/Source/modules/shapedetection/ShapeDetector.h [modify] https://crrev.com/31eb1a542aea4050d9b17fd7255d366499dedede/third_party/WebKit/Source/modules/shapedetection/TextDetector.cpp [modify] https://crrev.com/31eb1a542aea4050d9b17fd7255d366499dedede/third_party/WebKit/Source/modules/shapedetection/TextDetector.h
Monitoring: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_tests&tests=shapedetection%2F and marking Fixed tentatively. junwei.fu@ can you also keep an eye on the flakiness board plz?
All of testing cases passed. Can i continue to switch shape detection layout test to use new binding? thanks.
#28 tests seem to be holding on, please continue cleaning up the LayoutTests, thanks!
Comment 1 by schenney@chromium.org
, Nov 18 2016Owner: mcasas@chromium.org
Status: Assigned (was: Untriaged)