Issue metadata
Sign in to add a comment
|
Print preview resetting destination to 'Save as PDF' every time a user prints. |
||||||||||||||||||||||||
Issue descriptionVersion: 55.0.2883.42 beta, 56.0.2905.0 dev. OS: Chrome OS Make/Model: Any Chromebook What steps will reproduce the problem? (1) Open any website and Hit ‘Ctrl + P’. (2) Change the destination printer in the print preview and print to it. (3) Try to print again, and the previous selected printer won’t show up in destination, but 'Save to PDF'. What is the expected result? The last printer used should remain selected in the destination. What happens instead? ‘Save as PDF’ is selected as destination printer. Additional information: * No policy for default printer is being used. * 'DeviceEphemeralUsersEnabled' is set to false, so we make sure that the local profiles are not deleted, which would make printers go back to ‘Save to PDF’ after a sign out and sign in flow. * If we set a policy for default printer at user level, it will respect the default printer pushed by policy. So, we can say that it’s affecting the default printing selection behavior when the 'DefaultPrinterSelection' is not set at user level. * It's not reproducible in current Stable, but this may hit user experience when v55 becomes stable. * I've not been able to test it out in the browser at the time, so I'm tagging with Chrome OS only in the mean time.
,
Nov 17 2016
We're seeing this at a large site in the UK as well.
,
Nov 17 2016
I see this on ChromeOS with M55 but not on Linux with M55. Can someone bisect? I will also try "ChromeOS on Linux" and see if I can reproduce it there. If yes, I can do the bisect on my workstation.
,
Nov 17 2016
+skau FYI
,
Nov 17 2016
I'll look into it. I recently made changes to this code.
,
Nov 17 2016
,
Nov 17 2016
I can reproduce this on my Linux workstation with a "ChromeOS" build of Chromium.
,
Nov 17 2016
,
Nov 17 2016
I see it on my samus running 55 beta. I'm bisecting the changes in print_preview.
,
Nov 17 2016
I wanted to bisect with: tools/bisect-builds.py -a chromeos, bug that failed and I filed bug 666448 . I think I can still work around that bug and bisect quickly without recompiling.
,
Nov 17 2016
I just tested Chrome OS R55-8871.0.0 corresponding to 55.0.2880 which was built on 10/07 so the bad CL is at least that old.
,
Nov 17 2016
Bisect says.. https://chromium.googlesource.com/chromium/src/+log/bd13481e9f233d666137f4db1179ccaf0221b752..6d799882e49984de8620d41c53893101eaed92f6
,
Nov 19 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b12aba73d3525867511b315a45d2dbc65acd2647 commit b12aba73d3525867511b315a45d2dbc65acd2647 Author: rbpotter <rbpotter@chromium.org> Date: Sat Nov 19 07:09:57 2016 Fix CrOS reverting to Save as PDF and random PDF preview fail Increasing number of saved destinations caused a bug on Chrome OS - destination always reverted to Save as PDF. Also caused random "PDF failed to load" preview errors. This occurred since the destinations were modified one after the other too quickly, which caused a race condition that crashed PDF preview. This error occurred ~1 in 10 times. BUG= 665455 , 666426 , 666595 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2516523002 Cr-Commit-Position: refs/heads/master@{#433408} [modify] https://crrev.com/b12aba73d3525867511b315a45d2dbc65acd2647/chrome/browser/resources/print_preview/data/app_state.js [modify] https://crrev.com/b12aba73d3525867511b315a45d2dbc65acd2647/chrome/browser/resources/print_preview/data/destination_store.js
,
Nov 21 2016
This should be fixed on trunk, but I can't verify at the moment remotely. Will do tomorrow when in the office and merge this into bug 666595 . We hope to cherry-pick the fix for M56 and M55.
,
Nov 21 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/889ca692836950b471a5bdc08608e2edcdf4696a commit 889ca692836950b471a5bdc08608e2edcdf4696a Author: Lei Zhang <thestig@chromium.org> Date: Mon Nov 21 06:58:39 2016 M56: Fix CrOS reverting to Save as PDF and random PDF preview fail Increasing number of saved destinations caused a bug on Chrome OS - destination always reverted to Save as PDF. Also caused random "PDF failed to load" preview errors. This occurred since the destinations were modified one after the other too quickly, which caused a race condition that crashed PDF preview. This error occurred ~1 in 10 times. BUG= 665455 , 666426 , 666595 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2516523002 Cr-Commit-Position: refs/heads/master@{#433408} (cherry picked from commit b12aba73d3525867511b315a45d2dbc65acd2647) Review URL: https://codereview.chromium.org/2514303002 . Cr-Commit-Position: refs/branch-heads/2924@{#19} Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059} [modify] https://crrev.com/889ca692836950b471a5bdc08608e2edcdf4696a/chrome/browser/resources/print_preview/data/app_state.js [modify] https://crrev.com/889ca692836950b471a5bdc08608e2edcdf4696a/chrome/browser/resources/print_preview/data/destination_store.js
,
Nov 21 2016
,
Nov 22 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/03dfb68a8d7f607a19a3a5f53319c02b899f7d3f commit 03dfb68a8d7f607a19a3a5f53319c02b899f7d3f Author: Lei Zhang <thestig@chromium.org> Date: Tue Nov 22 10:06:34 2016 M55: Fix CrOS reverting to Save as PDF and random PDF preview fail Increasing number of saved destinations caused a bug on Chrome OS - destination always reverted to Save as PDF. Also caused random "PDF failed to load" preview errors. This occurred since the destinations were modified one after the other too quickly, which caused a race condition that crashed PDF preview. This error occurred ~1 in 10 times. BUG= 665455 , 666426 , 666595 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2516523002 Cr-Commit-Position: refs/heads/master@{#433408} (cherry picked from commit b12aba73d3525867511b315a45d2dbc65acd2647) Review URL: https://codereview.chromium.org/2518303002 . Cr-Commit-Position: refs/branch-heads/2883@{#646} Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768} [modify] https://crrev.com/03dfb68a8d7f607a19a3a5f53319c02b899f7d3f/chrome/browser/resources/print_preview/data/app_state.js [modify] https://crrev.com/03dfb68a8d7f607a19a3a5f53319c02b899f7d3f/chrome/browser/resources/print_preview/data/destination_store.js
,
Nov 22 2016
|
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by kuscher@chromium.org
, Nov 15 2016Labels: -Pri-3 M-57 Pri-2
Owner: weifangsun@chromium.org
Status: Assigned (was: Untriaged)