New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 665448 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Nov 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 633979



Sign in to add a comment

Make CrashFileManager and CrashTestCase support different crash file directories.

Project Member Reported by gsennton@chromium.org, Nov 15 2016

Issue description

Currently CrashTestCase is only used by Chrome, and therefore uses the constant CrashFileManager.CRASH_DUMP_DIR to determine where to store minidumps.

For WebView we will want to use a different directory (or a sub-directory) to store Minidumps (so that the Chrome, and WebView upload mechanisms don't clash).

We could either pass a different 'cache dir' to CrashFileManager from WebView, or we could remake CrashFileManager to take an additional parameter being the crash sub-directory.

Either way, it would be nice to be able to use the test utility CrashTestCase for WebView-specific tests as well - but then we need to set the correct crash directory during CrashTestCase.setUp().
One way to do this is having CrashTestCase be overridable to use a different crash directory (i.e. 

CrashTestCase {
  setup() {
    mCrashDir = getCrashDir();
  }
}

and then create a WebView-specific CrashTestCase.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 29 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9cea744e442147ca0d9a7541ed7e79378aa0c9b6

commit 9cea744e442147ca0d9a7541ed7e79378aa0c9b6
Author: gsennton <gsennton@chromium.org>
Date: Tue Nov 29 09:18:03 2016

Make minidump uploading test logic more useful to WebView.

Make minidump uploading test utility more useful/accessible to WebView
to allow for testing the WebView-implementation of minidump uploading.

BUG= 665448 

Review-Url: https://codereview.chromium.org/2532133002
Cr-Commit-Position: refs/heads/master@{#434933}

[modify] https://crrev.com/9cea744e442147ca0d9a7541ed7e79378aa0c9b6/components/minidump_uploader/android/javatests/src/org/chromium/components/minidump_uploader/CrashTestCase.java
[modify] https://crrev.com/9cea744e442147ca0d9a7541ed7e79378aa0c9b6/components/minidump_uploader/android/javatests/src/org/chromium/components/minidump_uploader/MinidumpUploadCallableTest.java

Status: Fixed (was: Assigned)

Sign in to add a comment