New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 665446 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Dec 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Create a separate proguard-spec for Cronet API

Project Member Reported by kapishnikov@chromium.org, Nov 15 2016

Issue description

Create a separate proguard-spec for those embedders who want to use Cronet API only with Java engine without including the native Cronet engine.

E.g., embedders that don't include the native Cronet engine in their apps only need:

-keep class org.chromium.net.impl.CronetEngineBuilderImpl {
    public <init>(android.content.Context);
}

-keep class org.chromium.net.impl.JavaCronetEngine {
    public <init>(java.lang.String);
}

 
Related CL http://cr/139119092

Comment 2 by mge...@chromium.org, Nov 22 2016

Owner: kapishnikov@chromium.org
Status: Assigned (was: Untriaged)
Status: Started (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Dec 1 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cfb46293103925f18c3931a44044ee1a0776345c

commit cfb46293103925f18c3931a44044ee1a0776345c
Author: kapishnikov <kapishnikov@chromium.org>
Date: Thu Dec 01 17:21:38 2016

[Cronet] Add proguard files for different Cronet packaging

1. Created three proguard files:
1.1. cronet_impl_common_proguard.cfg - for apps that depend on cronet_impl_common_java.jar
1.2. cronet_impl_platform_proguard.cfg - for apps that depend on cronet_impl_platform_java.jar
1.3. cronet_impl_native_proguard.cfg - for apps that depend on cronet_impl_native_java.jar

2. Enabled proguarding of cronet_sample_apk even for debug builds.

3. Changed cronet_sample_apk & cronet_perf_test_apk to test with proguard
   configs that we ship.

BUG= 665446 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

Review-Url: https://codereview.chromium.org/2540773003
Cr-Commit-Position: refs/heads/master@{#435633}

[modify] https://crrev.com/cfb46293103925f18c3931a44044ee1a0776345c/components/cronet/android/BUILD.gn
[add] https://crrev.com/cfb46293103925f18c3931a44044ee1a0776345c/components/cronet/android/cronet_impl_common_proguard.cfg
[rename] https://crrev.com/cfb46293103925f18c3931a44044ee1a0776345c/components/cronet/android/cronet_impl_native_proguard.cfg
[add] https://crrev.com/cfb46293103925f18c3931a44044ee1a0776345c/components/cronet/android/cronet_impl_platform_proguard.cfg

Status: Fixed (was: Started)

Sign in to add a comment