New issue
Advanced search Search tips

Issue 665442 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

If client id is not set on Swarming UI, make a visible error

Project Member Reported by kjlubick@google.com, Nov 15 2016

Issue description

Possibly make the signin element go away and replace with error.

 

Comment 1 by kjlubick@google.com, Nov 15 2016

Summary: If client id is not set on Swarming UI, make a visible error (was: If client id is not set, make a visible error)

Comment 2 by kjlubick@google.com, Nov 15 2016

Cc: mar...@chromium.org
Also make 403s to get server details more obvious rather than a silent failure.

Comment 3 by kjlubick@google.com, Nov 16 2016

Status: Started (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Nov 17 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/external/github.com/luci/luci-py.git/+/feb72d34696812e45df91585a1bd28162e0b7b64

commit feb72d34696812e45df91585a1bd28162e0b7b64
Author: kjlubick <kjlubick@google.com>
Date: Thu Nov 17 20:06:02 2016

Move error-toast up and Give a warning if clientid is not set

This makes sure all pages have an error-toast element. This allows
server details problems (typically 403) easier to see and address,
especially when setting up a new instance.

The pages now will be bright red and easily visible if client id
is not set.  Again, this is useful for setting up a new instance.

BUG= 665442 

Review-Url: https://codereview.chromium.org/2511463003

[modify] https://crrev.com/feb72d34696812e45df91585a1bd28162e0b7b64/appengine/swarming/ui/build/elements.html
[modify] https://crrev.com/feb72d34696812e45df91585a1bd28162e0b7b64/appengine/swarming/ui/res/imp/botlist/bot-list.html
[modify] https://crrev.com/feb72d34696812e45df91585a1bd28162e0b7b64/appengine/swarming/ui/res/imp/botpage/bot-page.html
[modify] https://crrev.com/feb72d34696812e45df91585a1bd28162e0b7b64/appengine/swarming/ui/res/imp/common/swarming-app.html
[modify] https://crrev.com/feb72d34696812e45df91585a1bd28162e0b7b64/appengine/swarming/ui/res/imp/index/swarming-index-demo.html
[modify] https://crrev.com/feb72d34696812e45df91585a1bd28162e0b7b64/appengine/swarming/ui/res/imp/tasklist/task-list.html
[modify] https://crrev.com/feb72d34696812e45df91585a1bd28162e0b7b64/appengine/swarming/ui/res/imp/taskpage/task-page.html

Comment 5 by kjlubick@google.com, Nov 17 2016

This is live on chromium-swarm (although since it's set up properly, you can't see it)
Status: Fixed (was: Started)

Sign in to add a comment