Change description: "caret-color" property allows coloring the insertion caret. Changes to API surface: New CSS property "caret-color" Links: https://drafts.csswg.org/css-ui/#propdef-caret-color Support in other browsers: Internet Explorer: No Firefox: No (https://bugzilla.mozilla.org/show_bug.cgi?id=1063162) Safari: No
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c142daf285cf004dd28c7a88c57920279d123300 commit c142daf285cf004dd28c7a88c57920279d123300 Author: rego <rego@igalia.com> Date: Wed Nov 30 18:19:33 2016 [css-ui] Add support for caret-color property The test basically adds the new CSS property "caret-color": https://drafts.csswg.org/css-ui/#propdef-caret-color "caret-color" is a regular color property but it accepts also "auto". To support this a new class StyleAutoColor has been created, including a new flag to know if the color is auto, currentColor or a specified one. Finally the patches modifies CaretBase::paintCaret() to use that property instead of "color" as it's been doing until now. We're using the test suite from the W3C CSS WG, which was imported on r434986. This CL manually imports some pixel tests too. This is based on a patch by Claudio Saavedra <csaavedra@igalia.com>. BUG= 665422 TEST=editing/caret/caret-color-*.html TEST=imported/csswg-test/css-ui-3/caret-color-*.html Review-Url: https://codereview.chromium.org/2520873002 Cr-Commit-Position: refs/heads/master@{#435338} [modify] https://crrev.com/c142daf285cf004dd28c7a88c57920279d123300/third_party/WebKit/LayoutTests/TestExpectations [add] https://crrev.com/c142daf285cf004dd28c7a88c57920279d123300/third_party/WebKit/LayoutTests/editing/caret/caret-color-001.html [add] https://crrev.com/c142daf285cf004dd28c7a88c57920279d123300/third_party/WebKit/LayoutTests/editing/caret/caret-color-002.html [add] https://crrev.com/c142daf285cf004dd28c7a88c57920279d123300/third_party/WebKit/LayoutTests/editing/caret/caret-color-003.html [add] https://crrev.com/c142daf285cf004dd28c7a88c57920279d123300/third_party/WebKit/LayoutTests/editing/caret/caret-color-004.html [add] https://crrev.com/c142daf285cf004dd28c7a88c57920279d123300/third_party/WebKit/LayoutTests/editing/caret/caret-color-005.html [add] https://crrev.com/c142daf285cf004dd28c7a88c57920279d123300/third_party/WebKit/LayoutTests/editing/caret/caret-color-007.html [add] https://crrev.com/c142daf285cf004dd28c7a88c57920279d123300/third_party/WebKit/LayoutTests/editing/caret/caret-color-010.html [add] https://crrev.com/c142daf285cf004dd28c7a88c57920279d123300/third_party/WebKit/LayoutTests/editing/caret/caret-color-011.html [add] https://crrev.com/c142daf285cf004dd28c7a88c57920279d123300/third_party/WebKit/LayoutTests/editing/caret/caret-color-012.html [add] https://crrev.com/c142daf285cf004dd28c7a88c57920279d123300/third_party/WebKit/LayoutTests/editing/caret/caret-color-014.html [add] https://crrev.com/c142daf285cf004dd28c7a88c57920279d123300/third_party/WebKit/LayoutTests/editing/caret/caret-color-015.html [add] https://crrev.com/c142daf285cf004dd28c7a88c57920279d123300/third_party/WebKit/LayoutTests/editing/caret/caret-color-016.html [modify] https://crrev.com/c142daf285cf004dd28c7a88c57920279d123300/third_party/WebKit/LayoutTests/editing/pasteboard/dragstart-contains-default-content-expected.txt [modify] https://crrev.com/c142daf285cf004dd28c7a88c57920279d123300/third_party/WebKit/LayoutTests/editing/pasteboard/onpaste-text-html-expected.txt [modify] https://crrev.com/c142daf285cf004dd28c7a88c57920279d123300/third_party/WebKit/LayoutTests/fast/css/getComputedStyle/computed-style-listing-expected.txt [modify] https://crrev.com/c142daf285cf004dd28c7a88c57920279d123300/third_party/WebKit/LayoutTests/fast/css/getComputedStyle/computed-style-without-renderer-listing-expected.txt [modify] https://crrev.com/c142daf285cf004dd28c7a88c57920279d123300/third_party/WebKit/LayoutTests/fast/events/ondrop-text-html-expected.txt [add] https://crrev.com/c142daf285cf004dd28c7a88c57920279d123300/third_party/WebKit/LayoutTests/platform/linux/editing/caret/caret-color-001-expected.png [add] https://crrev.com/c142daf285cf004dd28c7a88c57920279d123300/third_party/WebKit/LayoutTests/platform/linux/editing/caret/caret-color-001-expected.txt [add] https://crrev.com/c142daf285cf004dd28c7a88c57920279d123300/third_party/WebKit/LayoutTests/platform/linux/editing/caret/caret-color-002-expected.png [add] https://crrev.com/c142daf285cf004dd28c7a88c57920279d123300/third_party/WebKit/LayoutTests/platform/linux/editing/caret/caret-color-002-expected.txt [add] https://crrev.com/c142daf285cf004dd28c7a88c57920279d123300/third_party/WebKit/LayoutTests/platform/linux/editing/caret/caret-color-003-expected.png [add] https://crrev.com/c142daf285cf004dd28c7a88c57920279d123300/third_party/WebKit/LayoutTests/platform/linux/editing/caret/caret-color-003-expected.txt [add] https://crrev.com/c142daf285cf004dd28c7a88c57920279d123300/third_party/WebKit/LayoutTests/platform/linux/editing/caret/caret-color-004-expected.png [add] https://crrev.com/c142daf285cf004dd28c7a88c57920279d123300/third_party/WebKit/LayoutTests/platform/linux/editing/caret/caret-color-004-expected.txt [add] https://crrev.com/c142daf285cf004dd28c7a88c57920279d123300/third_party/WebKit/LayoutTests/platform/linux/editing/caret/caret-color-005-expected.png [add] https://crrev.com/c142daf285cf004dd28c7a88c57920279d123300/third_party/WebKit/LayoutTests/platform/linux/editing/caret/caret-color-005-expected.txt [add] https://crrev.com/c142daf285cf004dd28c7a88c57920279d123300/third_party/WebKit/LayoutTests/platform/linux/editing/caret/caret-color-007-expected.png [add] https://crrev.com/c142daf285cf004dd28c7a88c57920279d123300/third_party/WebKit/LayoutTests/platform/linux/editing/caret/caret-color-007-expected.txt [add] https://crrev.com/c142daf285cf004dd28c7a88c57920279d123300/third_party/WebKit/LayoutTests/platform/linux/editing/caret/caret-color-010-expected.png [add] https://crrev.com/c142daf285cf004dd28c7a88c57920279d123300/third_party/WebKit/LayoutTests/platform/linux/editing/caret/caret-color-010-expected.txt [add] https://crrev.com/c142daf285cf004dd28c7a88c57920279d123300/third_party/WebKit/LayoutTests/platform/linux/editing/caret/caret-color-011-expected.png [add] https://crrev.com/c142daf285cf004dd28c7a88c57920279d123300/third_party/WebKit/LayoutTests/platform/linux/editing/caret/caret-color-011-expected.txt [add] https://crrev.com/c142daf285cf004dd28c7a88c57920279d123300/third_party/WebKit/LayoutTests/platform/linux/editing/caret/caret-color-012-expected.png [add] https://crrev.com/c142daf285cf004dd28c7a88c57920279d123300/third_party/WebKit/LayoutTests/platform/linux/editing/caret/caret-color-012-expected.txt [add] https://crrev.com/c142daf285cf004dd28c7a88c57920279d123300/third_party/WebKit/LayoutTests/platform/linux/editing/caret/caret-color-014-expected.png [add] https://crrev.com/c142daf285cf004dd28c7a88c57920279d123300/third_party/WebKit/LayoutTests/platform/linux/editing/caret/caret-color-014-expected.txt [add] https://crrev.com/c142daf285cf004dd28c7a88c57920279d123300/third_party/WebKit/LayoutTests/platform/linux/editing/caret/caret-color-015-expected.png [add] https://crrev.com/c142daf285cf004dd28c7a88c57920279d123300/third_party/WebKit/LayoutTests/platform/linux/editing/caret/caret-color-015-expected.txt [add] https://crrev.com/c142daf285cf004dd28c7a88c57920279d123300/third_party/WebKit/LayoutTests/platform/mac/editing/caret/caret-color-001-expected.png [add] https://crrev.com/c142daf285cf004dd28c7a88c57920279d123300/third_party/WebKit/LayoutTests/platform/mac/editing/caret/caret-color-001-expected.txt [add] https://crrev.com/c142daf285cf004dd28c7a88c57920279d123300/third_party/WebKit/LayoutTests/platform/mac/editing/caret/caret-color-002-expected.png [add] https://crrev.com/c142daf285cf004dd28c7a88c57920279d123300/third_party/WebKit/LayoutTests/platform/mac/editing/caret/caret-color-002-expected.txt [add] https://crrev.com/c142daf285cf004dd28c7a88c57920279d123300/third_party/WebKit/LayoutTests/platform/mac/editing/caret/caret-color-003-expected.png [add] https://crrev.com/c142daf285cf004dd28c7a88c57920279d123300/third_party/WebKit/LayoutTests/platform/mac/editing/caret/caret-color-003-expected.txt [add] https://crrev.com/c142daf285cf004dd28c7a88c57920279d123300/third_party/WebKit/LayoutTests/platform/mac/editing/caret/caret-color-004-expected.png [add] https://crrev.com/c142daf285cf004dd28c7a88c57920279d123300/third_party/WebKit/LayoutTests/platform/mac/editing/caret/caret-color-004-expected.txt [add] https://crrev.com/c142daf285cf004dd28c7a88c57920279d123300/third_party/WebKit/LayoutTests/platform/mac/editing/caret/caret-color-005-expected.png [add] https://crrev.com/c142daf285cf004dd28c7a88c57920279d123300/third_party/WebKit/LayoutTests/platform/mac/editing/caret/caret-color-005-expected.txt [add] https://crrev.com/c142daf285cf004dd28c7a88c57920279d123300/third_party/WebKit/LayoutTests/platform/mac/editing/caret/caret-color-007-expected.png [add] https://crrev.com/c142daf285cf004dd28c7a88c57920279d123300/third_party/WebKit/LayoutTests/platform/mac/editing/caret/caret-color-007-expected.txt [add] https://crrev.com/c142daf285cf004dd28c7a88c57920279d123300/third_party/WebKit/LayoutTests/platform/mac/editing/caret/caret-color-010-expected.png [add] https://crrev.com/c142daf285cf004dd28c7a88c57920279d123300/third_party/WebKit/LayoutTests/platform/mac/editing/caret/caret-color-010-expected.txt [add] https://crrev.com/c142daf285cf004dd28c7a88c57920279d123300/third_party/WebKit/LayoutTests/platform/mac/editing/caret/caret-color-011-expected.png [add] https://crrev.com/c142daf285cf004dd28c7a88c57920279d123300/third_party/WebKit/LayoutTests/platform/mac/editing/caret/caret-color-011-expected.txt [add] https://crrev.com/c142daf285cf004dd28c7a88c57920279d123300/third_party/WebKit/LayoutTests/platform/mac/editing/caret/caret-color-012-expected.png [add] https://crrev.com/c142daf285cf004dd28c7a88c57920279d123300/third_party/WebKit/LayoutTests/platform/mac/editing/caret/caret-color-012-expected.txt [add] https://crrev.com/c142daf285cf004dd28c7a88c57920279d123300/third_party/WebKit/LayoutTests/platform/mac/editing/caret/caret-color-014-expected.png [add] https://crrev.com/c142daf285cf004dd28c7a88c57920279d123300/third_party/WebKit/LayoutTests/platform/mac/editing/caret/caret-color-014-expected.txt [add] https://crrev.com/c142daf285cf004dd28c7a88c57920279d123300/third_party/WebKit/LayoutTests/platform/mac/editing/caret/caret-color-015-expected.png [add] https://crrev.com/c142daf285cf004dd28c7a88c57920279d123300/third_party/WebKit/LayoutTests/platform/mac/editing/caret/caret-color-015-expected.txt [add] https://crrev.com/c142daf285cf004dd28c7a88c57920279d123300/third_party/WebKit/LayoutTests/platform/win/editing/caret/caret-color-001-expected.png [add] https://crrev.com/c142daf285cf004dd28c7a88c57920279d123300/third_party/WebKit/LayoutTests/platform/win/editing/caret/caret-color-001-expected.txt [add] https://crrev.com/c142daf285cf004dd28c7a88c57920279d123300/third_party/WebKit/LayoutTests/platform/win/editing/caret/caret-color-002-expected.png [add] https://crrev.com/c142daf285cf004dd28c7a88c57920279d123300/third_party/WebKit/LayoutTests/platform/win/editing/caret/caret-color-002-expected.txt [add] https://crrev.com/c142daf285cf004dd28c7a88c57920279d123300/third_party/WebKit/LayoutTests/platform/win/editing/caret/caret-color-003-expected.png [add] https://crrev.com/c142daf285cf004dd28c7a88c57920279d123300/third_party/WebKit/LayoutTests/platform/win/editing/caret/caret-color-003-expected.txt [add] https://crrev.com/c142daf285cf004dd28c7a88c57920279d123300/third_party/WebKit/LayoutTests/platform/win/editing/caret/caret-color-004-expected.png [add] https://crrev.com/c142daf285cf004dd28c7a88c57920279d123300/third_party/WebKit/LayoutTests/platform/win/editing/caret/caret-color-004-expected.txt [add] https://crrev.com/c142daf285cf004dd28c7a88c57920279d123300/third_party/WebKit/LayoutTests/platform/win/editing/caret/caret-color-005-expected.png [add] https://crrev.com/c142daf285cf004dd28c7a88c57920279d123300/third_party/WebKit/LayoutTests/platform/win/editing/caret/caret-color-005-expected.txt [add] https://crrev.com/c142daf285cf004dd28c7a88c57920279d123300/third_party/WebKit/LayoutTests/platform/win/editing/caret/caret-color-007-expected.png [add] https://crrev.com/c142daf285cf004dd28c7a88c57920279d123300/third_party/WebKit/LayoutTests/platform/win/editing/caret/caret-color-007-expected.txt [add] https://crrev.com/c142daf285cf004dd28c7a88c57920279d123300/third_party/WebKit/LayoutTests/platform/win/editing/caret/caret-color-010-expected.png [add] https://crrev.com/c142daf285cf004dd28c7a88c57920279d123300/third_party/WebKit/LayoutTests/platform/win/editing/caret/caret-color-010-expected.txt [add] https://crrev.com/c142daf285cf004dd28c7a88c57920279d123300/third_party/WebKit/LayoutTests/platform/win/editing/caret/caret-color-011-expected.png [add] https://crrev.com/c142daf285cf004dd28c7a88c57920279d123300/third_party/WebKit/LayoutTests/platform/win/editing/caret/caret-color-011-expected.txt [add] https://crrev.com/c142daf285cf004dd28c7a88c57920279d123300/third_party/WebKit/LayoutTests/platform/win/editing/caret/caret-color-012-expected.png [add] https://crrev.com/c142daf285cf004dd28c7a88c57920279d123300/third_party/WebKit/LayoutTests/platform/win/editing/caret/caret-color-012-expected.txt [add] https://crrev.com/c142daf285cf004dd28c7a88c57920279d123300/third_party/WebKit/LayoutTests/platform/win/editing/caret/caret-color-014-expected.png [add] https://crrev.com/c142daf285cf004dd28c7a88c57920279d123300/third_party/WebKit/LayoutTests/platform/win/editing/caret/caret-color-014-expected.txt [add] https://crrev.com/c142daf285cf004dd28c7a88c57920279d123300/third_party/WebKit/LayoutTests/platform/win/editing/caret/caret-color-015-expected.png [add] https://crrev.com/c142daf285cf004dd28c7a88c57920279d123300/third_party/WebKit/LayoutTests/platform/win/editing/caret/caret-color-015-expected.txt [modify] https://crrev.com/c142daf285cf004dd28c7a88c57920279d123300/third_party/WebKit/LayoutTests/svg/css/getComputedStyle-listing-expected.txt [modify] https://crrev.com/c142daf285cf004dd28c7a88c57920279d123300/third_party/WebKit/LayoutTests/virtual/stable/webexposed/css-properties-as-js-properties-expected.txt [modify] https://crrev.com/c142daf285cf004dd28c7a88c57920279d123300/third_party/WebKit/LayoutTests/webexposed/css-properties-as-js-properties-expected.txt [modify] https://crrev.com/c142daf285cf004dd28c7a88c57920279d123300/third_party/WebKit/Source/core/css/BUILD.gn [modify] https://crrev.com/c142daf285cf004dd28c7a88c57920279d123300/third_party/WebKit/Source/core/css/CSSComputedStyleDeclaration.cpp [modify] https://crrev.com/c142daf285cf004dd28c7a88c57920279d123300/third_party/WebKit/Source/core/css/CSSProperties.in [modify] https://crrev.com/c142daf285cf004dd28c7a88c57920279d123300/third_party/WebKit/Source/core/css/CSSPropertyEquality.cpp [modify] https://crrev.com/c142daf285cf004dd28c7a88c57920279d123300/third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp [add] https://crrev.com/c142daf285cf004dd28c7a88c57920279d123300/third_party/WebKit/Source/core/css/StyleAutoColor.h [modify] https://crrev.com/c142daf285cf004dd28c7a88c57920279d123300/third_party/WebKit/Source/core/css/parser/CSSParserFastPaths.cpp [modify] https://crrev.com/c142daf285cf004dd28c7a88c57920279d123300/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp [modify] https://crrev.com/c142daf285cf004dd28c7a88c57920279d123300/third_party/WebKit/Source/core/css/resolver/StyleBuilderConverter.cpp [modify] https://crrev.com/c142daf285cf004dd28c7a88c57920279d123300/third_party/WebKit/Source/core/css/resolver/StyleBuilderConverter.h [modify] https://crrev.com/c142daf285cf004dd28c7a88c57920279d123300/third_party/WebKit/Source/core/css/resolver/StyleBuilderCustom.cpp [modify] https://crrev.com/c142daf285cf004dd28c7a88c57920279d123300/third_party/WebKit/Source/core/editing/CaretBase.cpp [modify] https://crrev.com/c142daf285cf004dd28c7a88c57920279d123300/third_party/WebKit/Source/core/editing/EditingStyle.cpp [modify] https://crrev.com/c142daf285cf004dd28c7a88c57920279d123300/third_party/WebKit/Source/core/frame/UseCounter.cpp [modify] https://crrev.com/c142daf285cf004dd28c7a88c57920279d123300/third_party/WebKit/Source/core/style/ComputedStyle.cpp [modify] https://crrev.com/c142daf285cf004dd28c7a88c57920279d123300/third_party/WebKit/Source/core/style/ComputedStyle.h [modify] https://crrev.com/c142daf285cf004dd28c7a88c57920279d123300/third_party/WebKit/Source/core/style/StyleRareInheritedData.cpp [modify] https://crrev.com/c142daf285cf004dd28c7a88c57920279d123300/third_party/WebKit/Source/core/style/StyleRareInheritedData.h [modify] https://crrev.com/c142daf285cf004dd28c7a88c57920279d123300/third_party/WebKit/Source/web/tests/WebViewTest.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1d659157007dc8af77915b4af72f577b324c5e81 commit 1d659157007dc8af77915b4af72f577b324c5e81 Author: rego <rego@igalia.com> Date: Mon Jan 09 09:13:57 2017 [css-ui] Update resolved value of caret-color property The resolved value of caret-color should be the used value, like for the rest of color properties. This was discussed and resolved by the CSS WG (see https://github.com/w3c/csswg-drafts/issues/781). BUG= 665422 TEST=imported/csswg-test/css-ui-3/caret-color-009.html TEST=imported/csswg-test/css-ui-3/caret-color-013.html Review-Url: https://codereview.chromium.org/2577633002 Cr-Commit-Position: refs/heads/master@{#442214} [modify] https://crrev.com/1d659157007dc8af77915b4af72f577b324c5e81/third_party/WebKit/LayoutTests/TestExpectations [modify] https://crrev.com/1d659157007dc8af77915b4af72f577b324c5e81/third_party/WebKit/LayoutTests/editing/pasteboard/dragstart-contains-default-content-expected.txt [modify] https://crrev.com/1d659157007dc8af77915b4af72f577b324c5e81/third_party/WebKit/LayoutTests/editing/pasteboard/onpaste-text-html-expected.txt [modify] https://crrev.com/1d659157007dc8af77915b4af72f577b324c5e81/third_party/WebKit/LayoutTests/fast/css/getComputedStyle/computed-style-listing-expected.txt [modify] https://crrev.com/1d659157007dc8af77915b4af72f577b324c5e81/third_party/WebKit/LayoutTests/fast/css/getComputedStyle/computed-style-without-renderer-listing-expected.txt [modify] https://crrev.com/1d659157007dc8af77915b4af72f577b324c5e81/third_party/WebKit/LayoutTests/fast/events/ondrop-text-html-expected.txt [modify] https://crrev.com/1d659157007dc8af77915b4af72f577b324c5e81/third_party/WebKit/LayoutTests/svg/css/getComputedStyle-listing-expected.txt [modify] https://crrev.com/1d659157007dc8af77915b4af72f577b324c5e81/third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp [modify] https://crrev.com/1d659157007dc8af77915b4af72f577b324c5e81/third_party/WebKit/Source/core/editing/EditingStyle.cpp [modify] https://crrev.com/1d659157007dc8af77915b4af72f577b324c5e81/third_party/WebKit/Source/core/editing/EditingStyle.h [modify] https://crrev.com/1d659157007dc8af77915b4af72f577b324c5e81/third_party/WebKit/Source/web/tests/WebViewTest.cpp
Sorry but the last CL should have linked to bug #676763 instead of this one.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3618fd094800a43c016804b042481d2b70530660 commit 3618fd094800a43c016804b042481d2b70530660 Author: rego <rego@igalia.com> Date: Mon Jan 16 08:08:57 2017 [css-ui] Update caret-color tests This is a new import from W3C csswg-tests repository, as now the caret-color tests don't use "autofocus" anymore. Using "autofocus" was causing some issues to run the tests with https://codereview.chromium.org/2605173002/. BUG= 665422 Review-Url: https://codereview.chromium.org/2632963002 Cr-Commit-Position: refs/heads/master@{#443857} [modify] https://crrev.com/3618fd094800a43c016804b042481d2b70530660/third_party/WebKit/LayoutTests/editing/caret/caret-color-001.html [modify] https://crrev.com/3618fd094800a43c016804b042481d2b70530660/third_party/WebKit/LayoutTests/editing/caret/caret-color-002.html [modify] https://crrev.com/3618fd094800a43c016804b042481d2b70530660/third_party/WebKit/LayoutTests/editing/caret/caret-color-003.html [modify] https://crrev.com/3618fd094800a43c016804b042481d2b70530660/third_party/WebKit/LayoutTests/editing/caret/caret-color-004.html [modify] https://crrev.com/3618fd094800a43c016804b042481d2b70530660/third_party/WebKit/LayoutTests/editing/caret/caret-color-005.html [modify] https://crrev.com/3618fd094800a43c016804b042481d2b70530660/third_party/WebKit/LayoutTests/editing/caret/caret-color-007.html [modify] https://crrev.com/3618fd094800a43c016804b042481d2b70530660/third_party/WebKit/LayoutTests/editing/caret/caret-color-010.html [modify] https://crrev.com/3618fd094800a43c016804b042481d2b70530660/third_party/WebKit/LayoutTests/editing/caret/caret-color-012.html [modify] https://crrev.com/3618fd094800a43c016804b042481d2b70530660/third_party/WebKit/LayoutTests/platform/linux/editing/caret/caret-color-001-expected.txt [modify] https://crrev.com/3618fd094800a43c016804b042481d2b70530660/third_party/WebKit/LayoutTests/platform/linux/editing/caret/caret-color-003-expected.txt [modify] https://crrev.com/3618fd094800a43c016804b042481d2b70530660/third_party/WebKit/LayoutTests/platform/linux/editing/caret/caret-color-004-expected.txt [modify] https://crrev.com/3618fd094800a43c016804b042481d2b70530660/third_party/WebKit/LayoutTests/platform/linux/editing/caret/caret-color-005-expected.txt [modify] https://crrev.com/3618fd094800a43c016804b042481d2b70530660/third_party/WebKit/LayoutTests/platform/linux/editing/caret/caret-color-010-expected.txt [modify] https://crrev.com/3618fd094800a43c016804b042481d2b70530660/third_party/WebKit/LayoutTests/platform/mac/editing/caret/caret-color-001-expected.txt [modify] https://crrev.com/3618fd094800a43c016804b042481d2b70530660/third_party/WebKit/LayoutTests/platform/mac/editing/caret/caret-color-003-expected.txt [modify] https://crrev.com/3618fd094800a43c016804b042481d2b70530660/third_party/WebKit/LayoutTests/platform/mac/editing/caret/caret-color-004-expected.txt [modify] https://crrev.com/3618fd094800a43c016804b042481d2b70530660/third_party/WebKit/LayoutTests/platform/mac/editing/caret/caret-color-005-expected.txt [modify] https://crrev.com/3618fd094800a43c016804b042481d2b70530660/third_party/WebKit/LayoutTests/platform/mac/editing/caret/caret-color-010-expected.txt [modify] https://crrev.com/3618fd094800a43c016804b042481d2b70530660/third_party/WebKit/LayoutTests/platform/win/editing/caret/caret-color-001-expected.txt [modify] https://crrev.com/3618fd094800a43c016804b042481d2b70530660/third_party/WebKit/LayoutTests/platform/win/editing/caret/caret-color-003-expected.txt [modify] https://crrev.com/3618fd094800a43c016804b042481d2b70530660/third_party/WebKit/LayoutTests/platform/win/editing/caret/caret-color-004-expected.txt [modify] https://crrev.com/3618fd094800a43c016804b042481d2b70530660/third_party/WebKit/LayoutTests/platform/win/editing/caret/caret-color-005-expected.txt [modify] https://crrev.com/3618fd094800a43c016804b042481d2b70530660/third_party/WebKit/LayoutTests/platform/win/editing/caret/caret-color-010-expected.txt
Hey rego@, is this finished?
@meade the only pending thing is bug #676295 , @alancutter said he'll work on that.
Ah fantastic, thanks for the update!
Issue 676295 fixed. (:
Thanks @alancutter for fixing the last bit. We can close this now!
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/85394da73e559e58395471cb780eee7cb7e3cd49 commit 85394da73e559e58395471cb780eee7cb7e3cd49 Author: rego <rego@igalia.com> Date: Thu May 11 06:27:02 2017 DevTools: Add "caret-color: auto" as one of the possibilities Spec: https://drafts.csswg.org/css-ui-3/#propdef-caret-color BUG= 665422 Review-Url: https://codereview.chromium.org/2866323002 Cr-Commit-Position: refs/heads/master@{#470843} [modify] https://crrev.com/85394da73e559e58395471cb780eee7cb7e3cd49/third_party/WebKit/Source/devtools/front_end/sdk/CSSMetadata.js
Comment 1 by r...@igalia.com
, Nov 17 2016