Regression : In bookmark manager, unable to drag any bookmarked page into the folder.
Reported by
yfulgaon...@etouch.net,
Nov 15 2016
|
||||||||
Issue descriptionChrome Version : 56.0.2920.0 (Official Build) 378fc3fd49ebb678fc98cd99831b858fd304691f-refs/heads/master@{#432057} 32/64-bit OS : Mac(10.11.6, 10.12.1, 10.12), Windows (7,8,8.1,10), Linux(Ubuntu 14.04 LTS) What steps will reproduce the problem? 1. Launch chrome, open NTP and bookmark the NTP (‘New Tab’ page gets added into bookmarks bar). 2. Navigate to chrome://bookmarks, click on ‘Organise’ menu and add a new folder using ‘Add Folder..’ option. 3. Now try to drag and drop the ’New Tab’ page into newly added folder and observe. Actual : Unable to drag any bookmarked page into the folder. Expected : User should be able to drag and drop any bookmarked page into the folder. This is a regression issue broken in ‘M-56’, below is the Manual Regression range and will soon update bisect info. Good Build : 56.0.2914.0 Bad Build : 56.0.2915.0
,
Nov 15 2016
Adding RB label as this is a recent Regression. Please feel free to remove if not required. Thank You.
,
Nov 15 2016
Typo error on above comment#1 test edit on canary 56.0.2920.0 This is regression issue broken in M56.
,
Nov 17 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5b68b9b08166d20070c7360c11da97e75f547f3d commit 5b68b9b08166d20070c7360c11da97e75f547f3d Author: rdevlin.cronin <rdevlin.cronin@chromium.org> Date: Thu Nov 17 21:48:46 2016 [Extensions] Fix bookmark drag-and-drop bug https://crrev.com/a32a0900c104b2143e6462febc81e6900dbd2104 stopped ExtensionWebUI from being created for chrome://bookmarks in favor of a WebContentsUserData implementation. Unfortunately, WebUI is created on a per render frame basis and refreshed on navigation, whereas WebContentsUserData are created once at web contents initalization. As such, the bookmarks drag helper wasn't being created. Instead, just create the bookmarks drag helper for each web contents. It's a little unfortunate, but it's only called into with explicit bookmark drag-and-drop commands and doesn't have any real initialization cost or maintained state, so if it's never used in the web contents, it becomes essentially a no-op. In practice, this is probably cheaper than watching each navigation and conditionally creating/destroying the helper on the fly. BUG= 665411 Review-Url: https://codereview.chromium.org/2509323003 Cr-Commit-Position: refs/heads/master@{#432978} [modify] https://crrev.com/5b68b9b08166d20070c7360c11da97e75f547f3d/chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_api.cc [modify] https://crrev.com/5b68b9b08166d20070c7360c11da97e75f547f3d/chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_api.h [modify] https://crrev.com/5b68b9b08166d20070c7360c11da97e75f547f3d/chrome/browser/extensions/tab_helper.cc
,
Nov 18 2016
This should be fixed with #4.
,
Nov 18 2016
[Auto-generated comment by a script] We noticed that this issue is targeted for M-56; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-56 label, otherwise remove Merge-TBD label. Thanks.
,
Nov 18 2016
Patch landed in M56; we should be good. https://chromium.googlesource.com/chromium/src/+/5b68b9b08166d20070c7360c11da97e75f547f3d/chrome/VERSION
,
Nov 18 2016
Issue 664201 has been merged into this issue.
,
Dec 16 2016
This bug requires manual review: No test file found in commits. Please contact the milestone owner if you have questions. Owners: amineer@(clank), cmasso@(bling), gkihumba@(cros), bustamante@(desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Dec 16 2016
This bug requires manual review: No test file found in commits. Please contact the milestone owner if you have questions. Owners: amineer@(clank), cmasso@(bling), gkihumba@(cros), bustamante@(desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Dec 16 2016
[Automated comment] removing mislabelled Merge-Review-56, Hotlist-Merge-Review |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by sureshkumari@chromium.org
, Nov 15 2016Labels: hasbisect-per-revision
Owner: rdevlin....@chromium.org
Status: Assigned (was: Unconfirmed)