Issue metadata
Sign in to add a comment
|
Regression: [MD History] Text 'इतिहास' is seems to be chopped on header and looks weird.
Reported by
dmascare...@etouch.net,
Nov 15 2016
|
||||||||||||||||||||||
Issue descriptionChrome Version: 56.0.2920.0 (Official Build) 378fc3fd49ebb678fc98cd99831b858fd304691f-refs/heads/master@{#432057} 32/64-bit. OS: Windows(7,8,10) What steps will reproduce the problem? 1. Launch chrome and change browser language to Hindi from chrome://settings/languages 2. Now, navigate to chrome://history page and observe the text 'इतिहास' at header (top LHS). Text 'इतिहास' is seems to be chopped from right side and looks weird. Text 'इतिहास' should seen properly. This is a regression issue, broken in M-54 series, below is manual regression range. Good build: 54.0.2797.0 Bad build: 54.0.2799.0 Note: This issue is not seen on 'Mac' and 'Linux' OS. Kindly review the attached screen-cast for reference.
,
Nov 16 2016
Below is bisect info for the above issue. Narrow bisect: https://chromium.googlesource.com/chromium/src/+log/dfc3fca1cf4ed63e0694f31eebae90c0e7a6b2d3..20e1a9ebc85103a1a0d89461c9c2b268bbd5d6a2?pretty=fuller&n=100 Suspecting: r405681 @tsergeant: Kindly help to reassign, if your changes are not related to this issue.
,
Nov 17 2016
,
Nov 18 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1e4fcf3a14c3bd8b581f726d60c9aa58e9ec7254 commit 1e4fcf3a14c3bd8b581f726d60c9aa58e9ec7254 Author: tsergeant <tsergeant@chromium.org> Date: Fri Nov 18 03:39:17 2016 MD WebUI: Fix appearance of toolbar title in certain languages * Workaround font rendering issue in Hindi by adding padding to the end of the text. * Fix incorrect order-of-operations in the calculation for title width, which could cause title text to overlap with the search bar. BUG= 665406 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2508043002 Cr-Commit-Position: refs/heads/master@{#433065} [modify] https://crrev.com/1e4fcf3a14c3bd8b581f726d60c9aa58e9ec7254/chrome/browser/resources/md_downloads/toolbar.html [modify] https://crrev.com/1e4fcf3a14c3bd8b581f726d60c9aa58e9ec7254/chrome/browser/resources/md_downloads/vulcanized.html [modify] https://crrev.com/1e4fcf3a14c3bd8b581f726d60c9aa58e9ec7254/chrome/browser/resources/md_history/app.vulcanized.html [modify] https://crrev.com/1e4fcf3a14c3bd8b581f726d60c9aa58e9ec7254/ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar.html
,
Nov 18 2016
,
Nov 20 2016
Verified in latest canary (57.0.2926.0) Requesting merge back to M56.
,
Nov 20 2016
Your change meets the bar and is auto-approved for M56 (branch: 2924)
,
Nov 20 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fcbb7a991fdeb0a6456a83953b1c718ea9a84405 commit fcbb7a991fdeb0a6456a83953b1c718ea9a84405 Author: Tim Sergeant <tsergeant@chromium.org> Date: Sun Nov 20 23:00:42 2016 MD WebUI: Fix appearance of toolbar title in certain languages * Workaround font rendering issue in Hindi by adding padding to the end of the text. * Fix incorrect order-of-operations in the calculation for title width, which could cause title text to overlap with the search bar. BUG= 665406 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2508043002 Cr-Commit-Position: refs/heads/master@{#433065} (cherry picked from commit 1e4fcf3a14c3bd8b581f726d60c9aa58e9ec7254) Review URL: https://codereview.chromium.org/2519783002 . Cr-Commit-Position: refs/branch-heads/2924@{#13} Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059} [modify] https://crrev.com/fcbb7a991fdeb0a6456a83953b1c718ea9a84405/chrome/browser/resources/md_downloads/toolbar.html [modify] https://crrev.com/fcbb7a991fdeb0a6456a83953b1c718ea9a84405/chrome/browser/resources/md_downloads/vulcanized.html [modify] https://crrev.com/fcbb7a991fdeb0a6456a83953b1c718ea9a84405/chrome/browser/resources/md_history/app.vulcanized.html [modify] https://crrev.com/fcbb7a991fdeb0a6456a83953b1c718ea9a84405/ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar.html |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by msrchandra@chromium.org
, Nov 15 2016Status: Untriaged (was: Unconfirmed)