New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 665400 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug



Sign in to add a comment

When Windows ADMX policy files for Chrome are installed together with ADMX files for Google Update, two root "Google" folders are created in Group Policy editor

Reported by cberru...@gmail.com, Nov 15 2016

Issue description

UserAgent: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:45.0) Gecko/20100101 Firefox/45.0

Steps to reproduce the problem:
1. Install Google Chrome ADMX/ADML files and Google Update ADMX/ADML files.
2. Create new or open existing GPO object for editing.
3. Expand "Computer Configuration" -> "Administrative Templates".
4. Observe "Google" folders.

What is the expected behavior?
There should be only one folder "Google", settings for both Chrome and Omaha should be grouped under it. 

What went wrong?
Two sibling "Google" folders are seen.

Did this work before? No 

Chrome version: <Copy from: 'about:version'>  Channel: n/a
OS Version: 6.1 (Windows 7, Windows Server 2008 R2)
Flash Version: Shockwave Flash 23.0 r0

The root category with display name "Google" should not be located in main ADMX files for Chrome and Omaha. Instead, it should be put into a separate ADMX file and referenced from main ADMX files of Chrome and Omaha. Currently Chrome and Omaha ADMX files have root categories with the same display name "Google", but with different internal names: "google" for Chrome and "Cat_Google" for Omaha. To make both sets of Administrative Templates use same root category, the common name must be choosen. In the set of instructions below it is assumed that name "Cat_Google" is choosen.

---New root category file---
1. New ADMX file should be created, preferred name "google.admx", together with corresponding ADML file(s).
2. The "google.admx" file must contain root namespace, preferred name "Google.Policies".
3. The root category with name "Cat_Google" must be put into "google.admx".
4. The root category name "Google" must be put into "google.adml" file(s).

---Chrome ADMX update---
1. The root category "google" must be removed from "chrome.admx".
2. The root category display name must be removed from "chrome.adml" file(s).
3. File "chrome.admx" must reference namespace "Google.Policies".
4. Second-level categories "googlechrome" and "googlechrome_recommended" must be modified to use root category "Cat_Google" from namespace "Google.Policies" as parent.

---Omaha ADMX update---
1. The root category "Cat_Google" must be removed from "GoogleUpdate.admx".
2. The root category display name must be removed from "GoogleUpdate.adml" file(s).
3. File "GoogleUpdate.admx" must reference namespace "Google.Policies".
4. Second-level category "Cat_GoogleUpdate" must be modified to use root category "Cat_Google" from namespace "Google.Policies" as parent.

Then new "google.admx" and its ADML file(s) should be distributed together with ADMX files for both Chrome and Google Update.
 
Google ADMX problem.png
25.6 KB View Download
Cc: blumberg@chromium.org pastarmovj@chromium.org ligim...@chromium.org
Labels: M-54
Unfortunately I am not able to reproduce this issue in latest chrome stable - 54.0.2840.99.

1. Downloaded and unzipped the policy.zip file
2. Added the adm file in template.

Observed : Seeing only one Google folder under (ADM)
OS Configuration: Windows 7 Enterprise SP1 ( 64 Bit OS)

Tried adding the admx file, but file not shown while trying to select the same.Please correct me if I am missing any important step.
Capture.PNG
67.8 KB View Download
Labels: Needs-Feedback
Labels: -M-54 M-56 Enterprise
Owner: ljusten@chromium.org
Status: Assigned (was: Unconfirmed)
Thanks for the report!

Per our discussion, Lutz, can you please take a look?
Status: Started (was: Assigned)
Labels: -Needs-Feedback ReleaseBlock-Stable
Thanks for the update. 

M56 already branched we need a merge once the fix is available hence tagging with an RB label so that TE won't miss it.
Project Member

Comment 6 by bugdroid1@chromium.org, Nov 21 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/76942473295e92c2f34a6ed40a47a806dec38072

commit 76942473295e92c2f34a6ed40a47a806dec38072
Author: ljusten <ljusten@chromium.org>
Date: Mon Nov 21 19:05:24 2016

Split off 'Google' category into separate ADMX/ADML files

Allows sharing of the category. The category shows up as tree item
in the GPO editor. If multiple ADMX files use a 'Google' category,
there is one 'Google' tree item for each ADMX file. This CL allows
the category to be shared. ADMX files can reference the 'Google'
category by pointing into the google.admx file.

BUG= chromium:665400 
TEST=Tested policy_templates and pack_policy_templates, both branded and unbranded, made sure ADMX loads in editor.

Review-Url: https://codereview.chromium.org/2509243003
Cr-Commit-Position: refs/heads/master@{#433597}

[modify] https://crrev.com/76942473295e92c2f34a6ed40a47a806dec38072/components/policy/BUILD.gn
[modify] https://crrev.com/76942473295e92c2f34a6ed40a47a806dec38072/components/policy/resources/policy_templates.gni
[add] https://crrev.com/76942473295e92c2f34a6ed40a47a806dec38072/components/policy/tools/create_google_admx.py
[add] https://crrev.com/76942473295e92c2f34a6ed40a47a806dec38072/components/policy/tools/grd_helper.py
[modify] https://crrev.com/76942473295e92c2f34a6ed40a47a806dec38072/components/policy/tools/make_policy_zip.py
[modify] https://crrev.com/76942473295e92c2f34a6ed40a47a806dec38072/tools/grit/grit/format/policy_templates/writer_configuration.py
[modify] https://crrev.com/76942473295e92c2f34a6ed40a47a806dec38072/tools/grit/grit/format/policy_templates/writers/adm_writer.py
[modify] https://crrev.com/76942473295e92c2f34a6ed40a47a806dec38072/tools/grit/grit/format/policy_templates/writers/adm_writer_unittest.py
[modify] https://crrev.com/76942473295e92c2f34a6ed40a47a806dec38072/tools/grit/grit/format/policy_templates/writers/adml_writer.py
[modify] https://crrev.com/76942473295e92c2f34a6ed40a47a806dec38072/tools/grit/grit/format/policy_templates/writers/adml_writer_unittest.py
[modify] https://crrev.com/76942473295e92c2f34a6ed40a47a806dec38072/tools/grit/grit/format/policy_templates/writers/admx_writer.py
[modify] https://crrev.com/76942473295e92c2f34a6ed40a47a806dec38072/tools/grit/grit/format/policy_templates/writers/admx_writer_unittest.py

Owner: pastarmovj@chromium.org
Julian, the fix has landed. Could you merge it to beta, drover requires you to be a committer.
Labels: -M-56 M-57
I think we don't need to merge this back.

I will keep this bug open until both are in sync.

Comment 9 by ajha@chromium.org, Nov 30 2016

Please close the issue if there is no further work/merge to be done here.
@pastarmovj-- Please respond to the comment #9 .

Thanks!
Status: Fixed (was: Started)
I kept this open to track the work on the Google update side. There is no work to be done on Chrome's side for this. I will close this bug then and use the buganizer bug to track the state.

Sign in to add a comment