New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 665380 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Nov 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Unable to delete Extensions continuously through Keyboard

Project Member Reported by sc00335...@techmahindra.com, Nov 15 2016

Issue description

Version: 56.0.2920.0 dev
OS: Ubuntu 14.04

What steps will reproduce the problem?
(1) Launch chrome and go to chrome://extensions >> Tab until you reach trash icon >> Hit enter to remove and again hit enter 
(2)Now observe focus

Expected: After deleting one extension focus should be on next extension trash icon.
Actual: Instead focus is missing on next trash icon.

This is a regression issue broken in M56. Will provide bisect info soon.
 
Actual_extensions delete.ogv
791 KB View Download
Expected_extensions delete.ogv
873 KB View Download
Status: Untriaged (was: Unconfirmed)
Able to reproduce the issue on Ubuntu 14.04 using chrome latest Dev M56-56.0.2920.0. This issue is working fine on Mac OS.

Thanks!
Labels: ReleaseBlock-Stable
Issue is not seen in Windows 56.0.2920.0 dev.

Manual Bisect Range:
========================
Good build: 56.0.2902.0 
Bad build: 56.0.2903.0 
Labels: -Needs-Bisect hasbisect-per-revision
Owner: warx@chromium.org
Status: Assigned (was: Untriaged)
Bisect Information:
------------------------
You are probably looking for a change made after 428155 (known good), but no later than 428157 (first known bad).

CHANGELOG URL:
----------------
https://chromium.googlesource.com/chromium/src/+log/e0e3af8004e7f656ae8e1cb45c76a4a013c43961..c5e551b4da8b4bf7cc8fcfbdff3a052f19619bf3

From the CL above, assigning the issue to the concern owner 

@warx - Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Thanks!

Comment 4 by ajha@chromium.org, Nov 18 2016

Cc: sky@chromium.org
Project Member

Comment 5 by bugdroid1@chromium.org, Nov 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/34ce9a4718f571b8f8ee0f95b6d153aff38223db

commit 34ce9a4718f571b8f8ee0f95b6d153aff38223db
Author: warx <warx@chromium.org>
Date: Mon Nov 21 23:57:27 2016

Fix unable to delete extensions continuously through keyboard

Changes:
(1) revert the cl in Issue 2451323002.
(2) using a different approach, which is to avoid restorefocusedview call if desktopnativewidget is not active (since that should be handled in HandleActivationChanged call).

BUG= 665380 
TEST=manual test see bug fixed.
Also, this reverts the cl in Issue 2451323002, checked that the bug in that issue is not regressed.

Review-Url: https://codereview.chromium.org/2517663002
Cr-Commit-Position: refs/heads/master@{#433706}

[modify] https://crrev.com/34ce9a4718f571b8f8ee0f95b6d153aff38223db/ui/views/widget/desktop_aura/desktop_native_widget_aura.cc
[modify] https://crrev.com/34ce9a4718f571b8f8ee0f95b6d153aff38223db/ui/views/widget/desktop_aura/desktop_native_widget_aura.h

Comment 6 by warx@chromium.org, Nov 22 2016

Status: Fixed (was: Assigned)
Labels: Merge-TBD
[Auto-generated comment by a script] We noticed that this issue is targeted for M-56; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-56 label, otherwise remove Merge-TBD label. Thanks.

Comment 8 by warx@chromium.org, Nov 22 2016

Labels: Merge-Request-56

Comment 9 by dimu@chromium.org, Nov 22 2016

Labels: -Merge-Request-56 Merge-Approved-56 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M56 (branch: 2924)
Project Member

Comment 10 by bugdroid1@chromium.org, Nov 22 2016

Labels: -merge-approved-56 merge-merged-2924
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a4466cde03858e1e1754c9498e7aad4c1ea9c251

commit a4466cde03858e1e1754c9498e7aad4c1ea9c251
Author: Qiang Xu <warx@chromium.org>
Date: Tue Nov 22 23:27:09 2016

[Merge to 2924] Fix unable to delete extensions continuously through keyboard

Changes:
(1) revert the cl in Issue 2451323002.
(2) using a different approach, which is to avoid restorefocusedview call if desktopnativewidget is not active (since that should be handled in HandleActivationChanged call).

BUG= 665380 
TBR=sky@chromium.org
TEST=manual test see bug fixed.
Also, this reverts the cl in Issue 2451323002, checked that the bug in that issue is not regressed.

Review-Url: https://codereview.chromium.org/2517663002
Cr-Commit-Position: refs/heads/master@{#433706}
(cherry picked from commit 34ce9a4718f571b8f8ee0f95b6d153aff38223db)

Review URL: https://codereview.chromium.org/2525823002 .

Cr-Commit-Position: refs/branch-heads/2924@{#67}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}

[modify] https://crrev.com/a4466cde03858e1e1754c9498e7aad4c1ea9c251/ui/views/widget/desktop_aura/desktop_native_widget_aura.cc
[modify] https://crrev.com/a4466cde03858e1e1754c9498e7aad4c1ea9c251/ui/views/widget/desktop_aura/desktop_native_widget_aura.h

Labels: TE-Verified-M56 TE-Verified-56.0.2924.10
Tested the fix on Linux Ubuntu 14.04 using chrome version 56.0.2924.10.Able to see the focus on next extension trash icon after deleting the extension.
Please find the attached screen cast for the same.

Adding TE-Verified labels.
665380.ogv
1.3 MB View Download
Please confirm the behavior in#11 ,if there is no pending work please remove merge-TBD label.

Comment 13 by warx@chromium.org, Dec 2 2016

Labels: -Merge-TBD
Labels: TE-Verified-M57 TE-Verified-57.0.2946.0
Tested the issue on Chrome Dev# 57.0.2946.0 on Ubuntu 14.04 and observed that the issue is no more reproducible.
Focus shifts to the next extension after deletion. Hence adding TE-Verified Labels accordingly.
Attaching screen cast for reference.
665380.ogv
2.0 MB View Download
Project Member

Comment 15 by sheriffbot@chromium.org, Dec 16 2016

Labels: Merge-Review-56 Hotlist-Merge-Review
This bug requires manual review: No test file found in commits.
Please contact the milestone owner if you have questions.
Owners: amineer@(clank), cmasso@(bling), gkihumba@(cros), bustamante@(desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 16 by sheriffbot@chromium.org, Dec 16 2016

This bug requires manual review: No test file found in commits.
Please contact the milestone owner if you have questions.
Owners: amineer@(clank), cmasso@(bling), gkihumba@(cros), bustamante@(desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 17 by dimu@google.com, Dec 16 2016

Labels: -Merge-Review-56 -Hotlist-Merge-Review
[Automated comment] removing mislabelled Merge-Review-56, Hotlist-Merge-Review

Sign in to add a comment