Issue metadata
Sign in to add a comment
|
22.5% regression in blink_perf.shadow_dom at 431545:431569 |
||||||||||||||||||||
Issue descriptionSee the link to graphs below.
,
Nov 15 2016
Started bisect job https://chromeperf.appspot.com/buildbucket_job_status/8995939259005017936
,
Nov 15 2016
=== Auto-CCing suspected CL author alexclarke@chromium.org === Hi alexclarke@chromium.org, the bisect results pointed to your CL below as possibly causing a regression. Please have a look at this info and see whether your CL be related. ===== BISECT JOB RESULTS ===== Status: completed ===== SUSPECTED CL(s) ===== Subject : Revert of Add crash keys to TaskQueueManager::ProcessTaskFromWorkQueue (patchset #9 id:200001 of https://codereview.chromium.org/2464853002/ ) Author : alexclarke Commit description: Reason for revert: Long term I'd like to reland this, after the perf regression has been sorted out. Data from this helped fix a number of bugs. https://bugs.chromium.org/p/chromium/issues/detail?id=661927&can=8&q=2464853002&colspec=ID%20Pri%20M%20Stars%20ReleaseBlock%20Component%20Status%20Owner%20Summary%20OS%20Modified Original issue's description: > Add crash keys to TaskQueueManager::ProcessTaskFromWorkQueue > > We suspect a bad task closure is getting posted and would like to > add crash keys to aid diagnosis. > > BUG=660427, 661927 > > Committed: https://crrev.com/c08c078b27b353f4ab8de7deccfb862270b1ff2a > Cr-Commit-Position: refs/heads/master@{#429285} TBR=rsesek@chromium.org,skyostil@chromium.org,ananta@chromium.org,scottmg@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=660427, 661927 Review-Url: https://codereview.chromium.org/2486673007 Cr-Commit-Position: refs/heads/master@{#431551} Commit : a706db8b1ae44c392ac9b518a2d93e88d4b891fd Date : Fri Nov 11 13:02:02 2016 ===== TESTED REVISIONS ===== Revision Mean Std Dev N Good? chromium@431544 37.8176 25.8864 25 good chromium@431548 37.2246 20.9101 25 good chromium@431550 37.1224 18.528 25 good chromium@431551 45.2814 18.0228 25 bad <-- chromium@431557 42.1164 22.4769 25 bad chromium@431569 43.7178 22.4302 25 bad Bisect job ran on: winx64_10_perf_bisect Bug ID: 665365 Test Command: src/tools/perf/run_benchmark -v --browser=release_x64 --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests blink_perf.shadow_dom Test Metric: shadow-style-share-attr-selectors/shadow-style-share-attr-selectors Relative Change: 15.60% Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/winx64_10_perf_bisect/builds/778 Job details: https://chromeperf.appspot.com/buildbucket_job_status/8995939259005017936 Not what you expected? We'll investigate and get back to you! https://chromeperf.appspot.com/bad_bisect?try_job_id=5863777675771904 | O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq | X | for more information addressing perf regression bugs. For feedback, | / \ | file a bug with component Tests>AutoBisect. Thank you!
,
Nov 15 2016
That bisect is wrong :) I've kicked off another.
,
Nov 15 2016
Started bisect job https://chromeperf.appspot.com/buildbucket_job_status/8995933495555566160
,
Nov 15 2016
===== BISECT JOB RESULTS ===== Status: failed === Bisection aborted === The bisect was aborted because Bisect cannot identify a culprit: Please contact the the team (see below) if you believe this is in error. ===== TESTED REVISIONS ===== Revision Mean Std Dev N Good? chromium@431500 36.6976 23.8478 25 good chromium@431550 39.5824 30.9053 25 unknown chromium@431600 42.15 21.9466 25 bad Bisect job ran on: winx64_10_perf_bisect Bug ID: 665365 Test Command: src/tools/perf/run_benchmark -v --browser=release_x64 --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests blink_perf.shadow_dom Test Metric: shadow-style-share-attr-selectors/shadow-style-share-attr-selectors Relative Change: 14.86% Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/winx64_10_perf_bisect/builds/779 Job details: https://chromeperf.appspot.com/buildbucket_job_status/8995933495555566160 Not what you expected? We'll investigate and get back to you! https://chromeperf.appspot.com/bad_bisect?try_job_id=5907833839681536 | O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq | X | for more information addressing perf regression bugs. For feedback, | / \ | file a bug with component Tests>AutoBisect. Thank you!
,
Jan 17 2017
,
Mar 1 2017
let me close this since results have been unstable, and the latest result looks fine |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by toyoshim@chromium.org
, Nov 15 2016