New issue
Advanced search Search tips

Issue 665364 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 665363
Owner:
Closed: Nov 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

16% regression in blink_perf.paint at 431607:431670

Project Member Reported by toyoshim@chromium.org, Nov 15 2016

Issue description

See the link to graphs below.
 
All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=665364

Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?keys=agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICg88T-nQgM


Bot(s) for this bug's original alert(s):

chromium-rel-win7-gpu-ati
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, Nov 15 2016


===== BISECT JOB RESULTS =====
Status: failed


=== Bisection aborted ===
The bisect was aborted because Bisect cannot identify a culprit: Bisect failed to reproduce the regression with enough confidence.
Please contact the the team (see below) if you believe this is in error.

===== TESTED REVISIONS =====
Revision         Mean     Std Dev  N   Good?
chromium@431606  243.943  37.8788  25  good
chromium@431670  244.619  26.4339  25  bad

Bisect job ran on: winx64ati_perf_bisect
Bug ID: 665364

Test Command: src/tools/perf/run_benchmark -v --browser=release_x64 --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests blink_perf.paint
Test Metric: large-table-repaint/large-table-repaint
Relative Change: None

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/winx64ati_perf_bisect/builds/1646
Job details: https://chromeperf.appspot.com/buildbucket_job_status/8995939272192685200


Not what you expected? We'll investigate and get back to you!
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5791965822582784

| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!
Project Member

Comment 5 by 42576172...@developer.gserviceaccount.com, Nov 15 2016

Cc: pdr@chromium.org
Owner: pdr@chromium.org

=== Auto-CCing suspected CL author pdr@chromium.org ===

Hi pdr@chromium.org, the bisect results pointed to your CL below as possibly
causing a regression. Please have a look at this info and see whether
your CL be related.


===== BISECT JOB RESULTS =====
Status: completed


===== SUSPECTED CL(s) =====
Subject : Store paint properties directly on LayoutObject
Author  : pdr
Commit description:
  
This patch removes the temporary map that was used to avoid changing
the size of LayoutObject. This is in preparation for launching
property trees.

On profiles, the paint property map lookup is the hottest function
when running the paint-offset-change benchmark. On blink.perf, this
patch is a large improvement on all benchmarks[1]:
  color-changes.html: -3.78%
  large-table-background-change-with-invisible-collapsed-borders.html: -30.77%
  large-table-background-change-with-visible-collapsed-borders.html: 0%
  large-table-collapsed-border-change.html: -8.61%
  large-table-collapsed-border-change-with-backgrounds.html: -10.09%
  large-table-collapsed-border-change-with-text.html: -13.9%
  large-table-repaint.html: -14.28%
  paint-offset-changes.html: -5.05%
  transform-changes.html: -1.62%

[1] tools/perf/run_benchmark blink_perf.paint --browser=content-shell-release --pageset-repeat=3 --extra-browser-args=--enable-slimming-paint-v2

BUG= 645667 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2492073002
Cr-Commit-Position: refs/heads/master@{#431643}
Commit  : 3a5ab90f66206a967a646707dbdacb92b57bccc5
Date    : Fri Nov 11 21:14:09 2016


===== TESTED REVISIONS =====
Revision         Mean     Std Dev  N   Good?
chromium@431606  241.323  39.4343  25  good
chromium@431638  238.899  20.5721  25  good
chromium@431642  243.287  27.2182  25  good
chromium@431643  252.696  40.1286  25  bad    <--
chromium@431644  252.208  38.2996  25  bad
chromium@431646  253.583  36.6303  25  bad
chromium@431654  252.58   56.3633  25  bad
chromium@431670  253.444  57.0533  25  bad

Bisect job ran on: winx64ati_perf_bisect
Bug ID: 665364

Test Command: src/tools/perf/run_benchmark -v --browser=release_x64 --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests blink_perf.paint
Test Metric: large-table-repaint/large-table-repaint
Relative Change: 5.02%

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/winx64ati_perf_bisect/builds/1647
Job details: https://chromeperf.appspot.com/buildbucket_job_status/8995936494643755808


Not what you expected? We'll investigate and get back to you!
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5830796353470464

| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!

Comment 6 by pdr@chromium.org, Nov 15 2016

Cc: wangxianzhu@chromium.org
Status: Assigned (was: Untriaged)
This does seem like my change.

Shortly after my change landed, Xianzhu's table painting improvement patch landed which brought us back down to baseline. I'm leaning towards leaving this as-is.

Here's a better graph:
https://chromeperf.appspot.com/report?sid=3fc34673475aaf725a33b25114b39ae8da944715479425f036984ffecc44165d&rev=431670

Xianzhu, WDYT?
Mergedinto: 665363
Status: Duplicate (was: Assigned)

Sign in to add a comment