New issue
Advanced search Search tips

Issue 665363 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

16.5% regression in blink_perf.paint at 431761:431780

Project Member Reported by toyoshim@chromium.org, Nov 15 2016

Issue description

See the link to graphs below.
 
All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=665363

Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?keys=agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICgs4uDhwoM


Bot(s) for this bug's original alert(s):

chromium-rel-win7-gpu-nvidia
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, Nov 15 2016


===== BISECT JOB RESULTS =====
Status: failed


=== Bisection aborted ===
The bisect was aborted because Bisect cannot identify a culprit: Bisect failed to reproduce the regression with enough confidence.
Please contact the the team (see below) if you believe this is in error.

===== TESTED REVISIONS =====
Revision         Mean     Std Dev  N   Good?
chromium@431760  270.876  76.3607  25  good
chromium@431780  267.054  61.0016  25  bad

Bisect job ran on: winx64nvidia_perf_bisect
Bug ID: 665363

Test Command: src/tools/perf/run_benchmark -v --browser=release_x64 --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests blink_perf.paint
Test Metric: large-table-repaint/large-table-repaint
Relative Change: None

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/winx64nvidia_perf_bisect/builds/1955
Job details: https://chromeperf.appspot.com/buildbucket_job_status/8995939282754145760


Not what you expected? We'll investigate and get back to you!
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5303682801860608

| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!
another bisect was kicked with a wider range
Project Member

Comment 6 by 42576172...@developer.gserviceaccount.com, Nov 15 2016

Cc: wangxianzhu@chromium.org
Owner: wangxianzhu@chromium.org

=== Auto-CCing suspected CL author wangxianzhu@chromium.org ===

Hi wangxianzhu@chromium.org, the bisect results pointed to your CL below as possibly
causing a regression. Please have a look at this info and see whether
your CL be related.


===== BISECT JOB RESULTS =====
Status: completed


===== SUSPECTED CL(s) =====
Subject : Paint collapsed borders of a table as one display item
Author  : wangxianzhu
Commit description:
  
This simplifies paint invalidation logic on collapsed border changes.

About performance:
With this CL we create a big display item on the table containing all
collapsed border paintings, instead of many small display items on cells.
This will cause more painting when the display item is invalidated, but
saves time to handle many cached display items. Perf try jobs [1] show
that this CL actually improves performance of one test
(blink_perf.paint.large-table-background-change-with-invisible-collapsed-borders.html),
and doesn't affect much of performance of other tests.
Cluster-telemetry run showed no change or slight progression [2].

[1] https://codereview.chromium.org/2430313004/#ps60001
[2] https://ct.skia.org/chromium_perf_runs/, run 1433

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
BUG= 663208 

Review-Url: https://codereview.chromium.org/2430313004
Cr-Commit-Position: refs/heads/master@{#431744}
Commit  : c5cc11e88930c6e3f5e08b330fb14b6b571a0404
Date    : Sat Nov 12 02:16:08 2016


===== TESTED REVISIONS =====
Revision         Mean     Std Dev  N   Good?
chromium@431675  239.437  35.4817  25  good
chromium@431728  244.47   31.7659  25  good
chromium@431741  239.684  21.9914  25  good
chromium@431743  240.621  22.9428  25  good
chromium@431744  264.32   43.2108  25  bad    <--
chromium@431745  264.247  36.4243  25  bad
chromium@431748  265.862  40.1357  25  bad
chromium@431754  267.536  43.9636  25  bad
chromium@431780  274.44   71.9426  25  bad

Bisect job ran on: winx64nvidia_perf_bisect
Bug ID: 665363

Test Command: src/tools/perf/run_benchmark -v --browser=release_x64 --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests blink_perf.paint
Test Metric: large-table-repaint/large-table-repaint
Relative Change: 14.62%

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/winx64nvidia_perf_bisect/builds/1957
Job details: https://chromeperf.appspot.com/buildbucket_job_status/8995936749697665440


Not what you expected? We'll investigate and get back to you!
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5858352863641600

| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!
Status: Fixed (was: Untriaged)
The CL has been reverted for other reason.
Cc: pdr@chromium.org
 Issue 665364  has been merged into this issue.

Sign in to add a comment