New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 665328 link

Starred by 1 user
Status: Duplicate
Merged: issue 663823
Owner:
█ hpayer@chromium.org
Last visit > 30 days ago
Closed: Nov 2016
Cc:
jgruber@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

3.5% regression in system_health.memory_desktop at 430478:430592

Project Member Reported by jgruber@chromium.org, Nov 15 2016 
See the link to graphs below.

Comment 1 by jgruber@chromium.org, Nov 15 2016 

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=665328

Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?keys=agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICg8_Gs7QgM


Bot(s) for this bug's original alert(s):

chromium-rel-mac11
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, Nov 15 2016 


===== BISECT JOB RESULTS =====
Status: failed


=== Bisection aborted ===
The bisect was aborted because Bisect cannot identify a culprit: Bisect failed to reproduce the regression with enough confidence.
Please contact the the team (see below) if you believe this is in error.

===== TESTED REVISIONS =====
Revision         Mean      Std Dev    N    Good?
chromium@430477  30614297  419170233  212  good
chromium@430592  32201530  566417597  265  bad

Bisect job ran on: mac_10_11_perf_bisect
Bug ID: 665328

Test Command: src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests system_health.memory_desktop
Test Metric: memory:chrome:renderer_processes:reported_by_chrome:v8:heap:allocated_objects_size_avg/memory:chrome:renderer_processes:reported_by_chrome:v8:heap:allocated_objects_size_avg
Relative Change: None

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/mac_10_11_perf_bisect/builds/1029
Job details: https://chromeperf.appspot.com/buildbucket_job_status/8995943335846091744


Not what you expected? We'll investigate and get back to you!
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5776521388621824

| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!
Project Member

Comment 5 by 42576172...@developer.gserviceaccount.com, Nov 18 2016 

Bisect failed: http://build.chromium.org/p/tryserver.chromium.perf/builders/mac_10_11_perf_bisect/builds/1037
Failure reason: the build has failed due to infrastructure failure.

Comment 6 by rbyers@chromium.org, Nov 18 2016

Labels: Performance

Comment 7 by jgruber@chromium.org, Nov 21 2016

Cc: jgruber@chromium.org
Owner: hpayer@chromium.org
hpayer: not sure what to do with this one. Possibly related to  crbug.com/665319 , but revision ranges are are different. See load_news/browse_news for the clearest regressions.

Comment 10 by sullivan@chromium.org, Nov 21 2016 

Looks like it's specifically the load_news_qq story which is regressing. Kicked off a bisect on that.

Comment 11 by jgruber@chromium.org, Nov 21 2016 

Looking at browse_news subtests, it seems like the regression around 430370 is caused by missing browse_news_reddit data (no other subtests seem to regress).

Likewise the regression around 432083 seems to be caused by missing browse_news_flipboard data.

https://chromeperf.appspot.com/report?sid=60370088a96b04435e67fc28b78664a70254f819b33ef1cabeb0d6fbb37b67f6
Project Member

Comment 12 by 42576172...@developer.gserviceaccount.com, Nov 21 2016

Mergedinto: 663823
Status: Duplicate (was: Assigned)

===== BISECT JOB RESULTS =====
Status: completed


===== SUSPECTED CL(s) =====
Subject : Reland of Remove EventSender from HTMLStyleElement
Author  : hiroshige
Commit description:
  
This CL replaces EventSender in HTMLLinkElement with postTask():
Instead of calling HTMLStyleElement::dispatchPendingLoadEvents() in
Document::implicitClose() to enforce <style>'s onload events to be executed
before the document's onload event, this CL blocks document's onload until
<style>'s onload event using IncrementLoadEventDelayCount.

This CL changes the timing of body onload, particularly causes some of the
following events that were previously called AFTER document onload
to be called BEFORE document onload:
[A] The first layout.
[B] Latter half of FrameLoader::finishedParsing().
[C] JavaScript function |f| scheduled as |setTimeout(f, 0)| in the <script>
    at the end of <body>.

Notable test fixes (marked with the causes of failures):

fast/text/international/inline-plaintext-relayout-with-leading-neutrals.html:
  [A] Marked as flaky, because it depends on whether body onload is called
  before (Pass) or after (Failure) the first layout (crbug/651343).

fast/scrolling/scrollbar-tickmarks-styled.html:
  [A] Fixed by https://codereview.chromium.org/2450793002.

fast/scrolling/scrollbar-tickmarks-hittest.html:
  [A] Fixed by https://codereview.chromium.org/2484613003.

fast/forms/text/text-set-selection-crash.html:
  [A] There is race between "Blink Test Plugin: initializing" console log
  (which is asynchronously triggered by the first layout) and document onload
  (=test finish). Because the test should pass if not crashes, this CL make
  the test to ignore the log, by converting the test to use testharness.js
  and removing the -expected.txt.

virtual/rootlayerscrolls/fast/history/scroll-restoration/scroll-restoration-fragment-navigation-crossdoc.html:
  [B] Fixed by https://codereview.chromium.org/2467433002.

svg/animations/animate-end-attribute-numeric-precision.html:
  [C] After this CL, calling executeTest() in
  svg/animations/script-tests/animate-end-attribute-numeric-precision.js
  causes sampleAnimation() to be called before document onload and test to fail.
  We set |animationStartsImmediately| true instead, in order to ensure the test
  is started in document onload.

fast/harness/error-in-async-test.html:
  [C] Whether "Uncaught Exception" console log is shown depends on whether
  buggyAsyncCode() is executed before or after document onload. This CL
  deflakes the test by ensuring it is executed after document onload.

accessibility/inline-text-changes.html:
  [Race between the accessibility notification and document onload]
  Ignore the second call of the notification handler.
  Even before this CL, the notification is called multiple times, but the first
  notification terminated the test immediately by finishJSTest() because it is
  called after document onload.
  This CL makes the notification calls before document onload, and thus the test
  continues until document onload and we have to ignore the second call
  explicitly.

fast/block/float/marquee-shrink-to-avoid-floats.html:
  The layout tree changes slightly, but it looks like acceptable because the
  image expectation matches.

BUG= 624697 , 651343

Committed: https://crrev.com/52d00fd56184deadce99ff4fe599156ea1da3543
Review-Url: https://codereview.chromium.org/2269043002
Cr-Original-Commit-Position: refs/heads/master@{#430348}
Cr-Commit-Position: refs/heads/master@{#430572}
Commit  : b8cb16f79a95c8bc639a9c58785a8484c197aca9
Date    : Tue Nov 08 10:55:53 2016


===== TESTED REVISIONS =====
Revision         Mean       Std Dev    N   Good?
chromium@430541  143420101  23485349   12  good
chromium@430567  143692783  22989300   12  good
chromium@430571  139954176  38946717   18  good
chromium@430572  186790440  193083535  18  bad    <--
chromium@430573  188264868  121699701  12  bad
chromium@430574  176334602  120289478  8   bad
chromium@430580  192450207  140200773  8   bad
chromium@430592  185294569  147013587  12  bad

Bisect job ran on: mac_10_11_perf_bisect
Bug ID: 665328

Test Command: src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=load.news.qq system_health.memory_desktop
Test Metric: memory:chrome:renderer_processes:reported_by_chrome:v8:heap:allocated_objects_size_avg/load_news/load_news_qq
Relative Change: 29.20%

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/mac_10_11_perf_bisect/builds/1039
Job details: https://chromeperf.appspot.com/buildbucket_job_status/8995371808861897280


Not what you expected? We'll investigate and get back to you!
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5825389996277760

| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!
Project Member

Comment 13 by 42576172...@developer.gserviceaccount.com, Nov 22 2016 

Bisect failed: http://build.chromium.org/p/tryserver.chromium.perf/builders/mac_10_11_perf_bisect/builds/1038
Failure reason: the build has failed due to infrastructure failure.
►

Sign in to add a comment