Issue metadata
Sign in to add a comment
|
Regression: "No Cast destination found" message is misaligned after changing browser language to 'Italian'.
Reported by
dmascare...@etouch.net,
Nov 15 2016
|
||||||||||||||||||||||
Issue descriptionChrome Version:56.0.2919.0 (Official Build) 9fd27ddeb13974b24cfa42261b940f8de378117a-refs/heads/master@{#431801} OS: Windows (7,8,10) Pre-condition:1. Change browser language to 'Italian'. What steps will reproduce the problem? 1. Launch chrome and click on wrench icon, select 'Cast' option. 2. Observe. Actual: Misalignment of "No Cast destination found" message is seen. Expected: Misalignment should not be seen. This is regression issue, broken in 'M 54' and below is manual bisect: Good build:54.0.2815 Bad build:54.0.2816 Note: Issue is not seen on Linux and Mac OS.
,
Nov 15 2016
r409061 cl gets automatically created as part of weekly translation run. I don't think it is a culprit. Mano, could you ptal please?
,
Nov 15 2016
Running a per-revision bisect should really help in this case.
,
Nov 16 2016
Below are the steps to reproduce the issue, Pre-condition: 1. Change browser language to 'Italian'. 2. Enable "Show Media Router" from chrome://flags and relaunch. What steps will reproduce the problem? 1. Launch chrome and click on wrench icon, select 'Cast' option. 2. Observe. Actual: Misalignment of "No Cast destination found" message is seen. Expected: Misalignment should not be seen. Using the per-revision bisect providing the bisect results, Good build: 54.0.2815.0 (Revision: 408889). Bad build: 54.0.2816.0 (Revision: 409090). You are probably looking for a change made after 409060 (known good), but no later than 409064 (first known bad). CHANGELOG URL: The script might not always return single CL as suspectas some perf builds might get missing due to failure. https://chromium.googlesource.com/chromium/src/+log/9f7c262325b965be2a51475650d542c9791eee9d..62c1818efd6793549a21f744746a94b1a55dd2c1 Note: per revision bisect also provided multiple CLs, Unable to find the possible suspect from the above provided CL. @manoranjan -- Could you please help us in assigning to the concern owner. Thank You.
,
Nov 16 2016
mathp@, could you please look into this change (https://chromium.googlesource.com/chromium/src/+/62c1818efd6793549a21f744746a94b1a55dd2c1) if possible? Thank you!
,
Nov 16 2016
I was only the build sheriff on that day, relanding bauerb's change. Assigning to him.
,
Nov 17 2016
,
Nov 17 2016
My CL was Android-only, and this issue only happens on Windows. r409061 OTOH did change translation strings. Specifically, the CL added the translations of IDS_MEDIA_ROUTER_DESTINATION_MISSING, which was added in https://codereview.chromium.org/2154203004. What did the dialog look like in Italian before r409061?
,
Nov 17 2016
,
Nov 18 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ae0a80ba03e4a51253be34dfea8497753e6188f0 commit ae0a80ba03e4a51253be34dfea8497753e6188f0 Author: apacible <apacible@chromium.org> Date: Fri Nov 18 03:21:42 2016 [Media Router] Center device missing text. See crbug for before screenshot. BUG= 665301 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2508273002 Cr-Commit-Position: refs/heads/master@{#433055} [modify] https://crrev.com/ae0a80ba03e4a51253be34dfea8497753e6188f0/chrome/browser/resources/media_router/elements/media_router_container/media_router_container.css
,
Nov 18 2016
Is this fixed then?
,
Nov 18 2016
Yes, I'm trying to find if this made branch cut before closing.
,
Nov 18 2016
Just made M56 by 4 commits. :) |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by dmascare...@etouch.net
, Nov 15 2016Labels: hasbisect
Owner: gov...@chromium.org
Status: Assigned (was: Unconfirmed)