BrowserFocusTest.FocusOnNavigate in interactive_ui_tests is flaky |
||||||||||
Issue descriptioninteractive_ui_tests on Windows-7-SP1 failing on chromium.win/Win7 Tests (dbg)(1) Type: build-failure Builders failed on: - Win7 Tests (dbg)(1): https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29 https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20(dbg)(1)/builds/54710/steps/interactive_ui_tests%20on%20Windows-7-SP1/logs/BrowserFocusTest.FocusOnNavigate BrowserFocusTest.FocusOnNavigate (run #1): [ RUN ] BrowserFocusTest.FocusOnNavigate [6128:3868:1114/203720:INFO:media_foundation_video_encode_accelerator_win.cc(307)] Windows versions earlier than 8 are not supported. [5912:2644:1114/203722:ERROR:render_process_impl.cc(112)] WebFrame LEAKED 1 TIMES [4128:4348:1114/203722:ERROR:process_win.cc(135)] Unable to terminate process: Access is denied. (0x5) [4128:4348:1114/203725:ERROR:process_win.cc(135)] Unable to terminate process: Access is denied. (0x5) [5532:5696:1114/203727:ERROR:render_process_impl.cc(112)] WebFrame LEAKED 1 TIMES [1068:3688:1114/203729:ERROR:render_process_impl.cc(112)] WebFrame LEAKED 2 TIMES c:\c\win\src\chromerowser\uirowser_focus_uitest.cc(719): error: Value of: IsViewFocused(VIEW_ID_OMNIBOX) Actual: true Expected: false [4128:5000:1114/203730:WARNING:url_request_context_getter.cc(43)] URLRequestContextGetter leaking due to no owning thread. [ FAILED ] BrowserFocusTest.FocusOnNavigate, where TypeParam = and GetParam() = (11571 ms)
,
Nov 15 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c868c2f37f2ac99fbfe4b5160521fde86225dfe6 commit c868c2f37f2ac99fbfe4b5160521fde86225dfe6 Author: Tsuyoshi Horo <horo@chromium.org> Date: Tue Nov 15 05:21:38 2016 Disable BrowserFocusTest.FocusOnNavigate on windows BUG=665296,163931 TBR=warx@chromium.org Review URL: https://codereview.chromium.org/2503773002 . Cr-Commit-Position: refs/heads/master@{#432114} [modify] https://crrev.com/c868c2f37f2ac99fbfe4b5160521fde86225dfe6/chrome/browser/ui/browser_focus_uitest.cc
,
Nov 15 2016
Issue 665317 has been merged into this issue.
,
Nov 22 2016
Issue 667060 has been merged into this issue.
,
Nov 22 2016
This test is also flaking on MacOSX. I'm landing a disable CL now. Example failure: https://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/339210 [ RUN ] BrowserFocusTest.FocusOnNavigate [6676:51223:1118/170544:WARNING:mac_util.mm(222)] Failed to set backup exclusion for file '/private/var/folders/9x/6c6sv3cj4j53wzpzthbp4ksm0000gm/T/.org.chromium.Chromium.KqGfhX/d5ujbdP/Default/History': Error Domain=NSOSStatusErrorDomain Code=-50 "The operation couldn?t be completed. (OSStatus error -50.)" (paramErr: error in user parameter list) (-50) [6676:51223:1118/170544:WARNING:mac_util.mm(222)] Failed to set backup exclusion for file '/private/var/folders/9x/6c6sv3cj4j53wzpzthbp4ksm0000gm/T/.org.chromium.Chromium.KqGfhX/d5ujbdP/Default/Favicons': Error Domain=NSOSStatusErrorDomain Code=-50 "The operation couldn?t be completed. (OSStatus error -50.)" (paramErr: error in user parameter list) (-50) [6679:771:1118/170544:WARNING:vt_video_decode_accelerator_mac.cc(174)] Failed to create VTDecompressionSession: Error Domain=NSOSStatusErrorDomain Code=-8973 "The operation couldn?t be completed. (OSStatus error -8973.)" (codecOpenErr) (-8973) [6679:771:1118/170544:WARNING:vt_video_decode_accelerator_mac.cc(209)] Failed to create hardware VideoToolbox session [6679:771:1118/170544:ERROR:vt_video_encode_accelerator_mac.cc(540)] VTCompressionSessionCreate failed: -12908 [6676:97027:1118/170545:WARNING:simple_synchronous_entry.cc(1055)] Could not open platform files for entry. ../../chrome/browser/ui/browser_focus_uitest.cc:713: Failure Value of: IsViewFocused(VIEW_ID_OMNIBOX) Actual: true Expected: false [6676:771:1118/170547:WARNING:url_request_context_getter.cc(43)] URLRequestContextGetter leaking due to no owning thread. [ FAILED ] BrowserFocusTest.FocusOnNavigate, where TypeParam = and GetParam() = (3071 ms)
,
Nov 22 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ecbf1e11aa1d28dd3e48c2bc7fadeb0214e4a3ab commit ecbf1e11aa1d28dd3e48c2bc7fadeb0214e4a3ab Author: tsergeant <tsergeant@chromium.org> Date: Tue Nov 22 03:40:12 2016 Disable BrowserFocusTest.FocusOnNavigate on Mac BUG=665296 TBR=warx@chromium.org Review-Url: https://codereview.chromium.org/2521153003 Cr-Commit-Position: refs/heads/master@{#433777} [modify] https://crrev.com/ecbf1e11aa1d28dd3e48c2bc7fadeb0214e4a3ab/chrome/browser/ui/browser_focus_uitest.cc
,
Nov 16 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7aa410d501a988161392025b25976de4de3e5405 commit 7aa410d501a988161392025b25976de4de3e5405 Author: Greg Thompson <grt@chromium.org> Date: Thu Nov 16 21:04:12 2017 Enable BrowserFocusTest.FocusOnNavigate on Windows. The test harness is less flaky now, so perhaps this can run reliably. BUG=665296 R=sky@chromium.org Change-Id: Iae61f9aa6cce8eaa4d99ed2cf7d8794e9dec1094 Reviewed-on: https://chromium-review.googlesource.com/774599 Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#517187} [modify] https://crrev.com/7aa410d501a988161392025b25976de4de3e5405/chrome/browser/ui/browser_focus_uitest.cc
,
Dec 7 2017
This is flaking on linux-chromeos-dbg. https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=interactive_ui_tests&tests=BrowserFocusTest.FocusOnNavigate Flaking since this build: https://ci.chromium.org/buildbot/chromium.chromiumos/linux-chromeos-dbg/3018
,
Dec 7 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4d93ae49b7ec56a1ac010efd4bab32d4ad712ebb commit 4d93ae49b7ec56a1ac010efd4bab32d4ad712ebb Author: Kunihiko Sakamoto <ksakamoto@chromium.org> Date: Thu Dec 07 06:56:23 2017 Disable BrowserFocusTest.FocusOnNavigate on ChromeOS TBR=warx@chromium.org Bug: 665296 Change-Id: I69c487f17ce5ee1170fd7f1dc190b2f185e3643f Reviewed-on: https://chromium-review.googlesource.com/813457 Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#522372} [modify] https://crrev.com/4d93ae49b7ec56a1ac010efd4bab32d4ad712ebb/chrome/browser/ui/browser_focus_uitest.cc
,
Dec 7 2017
,
Feb 12 2018
Probably these are fixed by our cl, Michael?
,
Feb 12 2018
typo: your
,
Feb 13 2018
Possibly. There could be a lot of reasons for window focus flakiness, and the deeper I go into the shared and platform-specific activation code, the less I feel capable of reasoning about it ;-)
,
Apr 24 2018
Also flaky on windows.
,
Apr 24 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1ca3014d6b21fbe83025eabfb9f0880f061db67c commit 1ca3014d6b21fbe83025eabfb9f0880f061db67c Author: Xida Chen <xidachen@chromium.org> Date: Tue Apr 24 15:01:16 2018 Disable BrowserFocusTest.FocusOnNavigate on Win TBR=clamy@chromium.org NOTRY=true Bug: 665296 Change-Id: I538e83666a06e8e385c79f339f9089f4ee293242 Reviewed-on: https://chromium-review.googlesource.com/1025964 Reviewed-by: Xida Chen <xidachen@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#553107} [modify] https://crrev.com/1ca3014d6b21fbe83025eabfb9f0880f061db67c/chrome/browser/ui/browser_focus_uitest.cc
,
Aug 13
Detected 3 new flakes for test/step "BrowserFocusTest.FocusOnNavigate". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyKwsSBUZsYWtlIiBCcm93c2VyRm9jdXNUZXN0LkZvY3VzT25OYXZpZ2F0ZQw. This message was posted automatically by the chromium-try-flakes app. Since flakiness is ongoing, the issue was moved back into Sheriff Bug Queue (unless already there).
,
Aug 14
Detected 12 new flakes for test/step "BrowserFocusTest.FocusOnNavigate". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyKwsSBUZsYWtlIiBCcm93c2VyRm9jdXNUZXN0LkZvY3VzT25OYXZpZ2F0ZQw. This message was posted automatically by the chromium-try-flakes app.
,
Aug 15
Detected 14 new flakes for test/step "BrowserFocusTest.FocusOnNavigate". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyKwsSBUZsYWtlIiBCcm93c2VyRm9jdXNUZXN0LkZvY3VzT25OYXZpZ2F0ZQw. This message was posted automatically by the chromium-try-flakes app.
,
Aug 15
,
Aug 17
Detected 3 new flakes for test/step "BrowserFocusTest.FocusOnNavigate". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyKwsSBUZsYWtlIiBCcm93c2VyRm9jdXNUZXN0LkZvY3VzT25OYXZpZ2F0ZQw. This message was posted automatically by the chromium-try-flakes app. Since flakiness is ongoing, the issue was moved back into Sheriff Bug Queue (unless already there).
,
Aug 20
Skipping the test on Windows (as last platform) as well with https://crrev.com/c/1181262.
,
Aug 20
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/958b1b6b16f6e0844b6566898a0cb53780fb3147 commit 958b1b6b16f6e0844b6566898a0cb53780fb3147 Author: Friedrich Horschig <fhorschig@chromium.org> Date: Mon Aug 20 15:42:13 2018 [Win][Flaky] Disable BrowserFocusTest.FocusOnNaviate on Win This test is already disabled for all other platforms but (as linked in the bug) Windows bots also reported flakes. Therefore, disable it for windows as well. TBR=clamy@chromium.org Bug: 665296 Change-Id: I3991d966d72509324c00c28d82ace55d698eecb4 Reviewed-on: https://chromium-review.googlesource.com/1181262 Reviewed-by: Friedrich Horschig <fhorschig@chromium.org> Commit-Queue: Friedrich Horschig <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#584458} [modify] https://crrev.com/958b1b6b16f6e0844b6566898a0cb53780fb3147/chrome/browser/ui/browser_focus_uitest.cc
,
Jan 14
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ec52747a5abc25a862843edca761104b3c319764 commit ec52747a5abc25a862843edca761104b3c319764 Author: Gabriel Charette <gab@chromium.org> Date: Mon Jan 14 16:16:49 2019 [ui_controls] Unflake Send*NotifyWhenDone() on Windows ui_controls::Send*NotifyWhenDone() can be flaky when invoked after ui_controls::Send*() as the former can decide to notify based on observing a yet-to-be-processed event from the latter (or even a yet-to-be-processed event emitted by unrelated code) and thus notify too early, resuming and testing conditions that have yet to be met. Solution: defer the notification if the system queue has pending events of the same type awaiting dispatch. Note: mouse move can be repeated indefinitely during a drag, as such we consider a mouse move complete when it hits the target regardless of remaining mouse move messages in the queue. @ BUG OWNERS : This might unflake many currently disabled tests. I've CC'ed interactive_ui_tests + Windows bugs, please try to re-enable your test after this CL if you think it might be related. Bug: 892228 , 640996, 897801,893078,876224,875443,873110,852786,850343,848049,846695,840369,798492,756338,751031,665296,651906,499858,468660,419468,238347,131612,106489,97777,92467 Change-Id: I548856a3948ff71a145435799b4ba3e689561f14 Reviewed-on: https://chromium-review.googlesource.com/c/1392178 Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by: Greg Thompson <grt@chromium.org> Reviewed-by: Peter Kasting <pkasting@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#622470} [modify] https://crrev.com/ec52747a5abc25a862843edca761104b3c319764/chrome/browser/ui/views/bookmarks/bookmark_bar_view_test.cc [modify] https://crrev.com/ec52747a5abc25a862843edca761104b3c319764/ui/base/test/ui_controls_internal_win.cc |
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by horo@chromium.org
, Nov 15 2016