New issue
Advanced search Search tips

Issue 665285 link

Starred by 0 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Feature



Sign in to add a comment

Deprecate CancellableTaskFactory in favor of WebTaskRunner::postCancellableTask

Project Member Reported by nhiroki@chromium.org, Nov 15 2016

Issue description

CancellableTaskFactory has 2 create() functions. The first function has 9 occurrences and the second function has 2 occurrences.
 
Cc: -nhiroki@chromium.org
Owner: nhiroki@chromium.org
Status: Assigned (was: Available)
Status: Started (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Nov 21 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/350ebf173edb4994dd561ee16c2f7cf5afdaa7be

commit 350ebf173edb4994dd561ee16c2f7cf5afdaa7be
Author: nhiroki <nhiroki@chromium.org>
Date: Mon Nov 21 06:27:25 2016

Scheduler: Deprecate CancellableTaskFactory in favor of WebTaskRunner::postCancellableTask (2)

BUG= 665285 

Review-Url: https://codereview.chromium.org/2507673002
Cr-Commit-Position: refs/heads/master@{#433486}

[modify] https://crrev.com/350ebf173edb4994dd561ee16c2f7cf5afdaa7be/third_party/WebKit/Source/core/dom/Document.cpp
[modify] https://crrev.com/350ebf173edb4994dd561ee16c2f7cf5afdaa7be/third_party/WebKit/Source/core/dom/Document.h
[modify] https://crrev.com/350ebf173edb4994dd561ee16c2f7cf5afdaa7be/third_party/WebKit/Source/core/dom/ScriptRunner.cpp
[modify] https://crrev.com/350ebf173edb4994dd561ee16c2f7cf5afdaa7be/third_party/WebKit/Source/core/dom/ScriptRunnerTest.cpp
[modify] https://crrev.com/350ebf173edb4994dd561ee16c2f7cf5afdaa7be/third_party/WebKit/Source/core/frame/FrameView.cpp
[modify] https://crrev.com/350ebf173edb4994dd561ee16c2f7cf5afdaa7be/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp
[modify] https://crrev.com/350ebf173edb4994dd561ee16c2f7cf5afdaa7be/third_party/WebKit/Source/core/html/HTMLMediaElement.h
[modify] https://crrev.com/350ebf173edb4994dd561ee16c2f7cf5afdaa7be/third_party/WebKit/Source/core/html/parser/HTMLParserScheduler.cpp
[modify] https://crrev.com/350ebf173edb4994dd561ee16c2f7cf5afdaa7be/third_party/WebKit/Source/core/html/parser/HTMLParserScheduler.h
[modify] https://crrev.com/350ebf173edb4994dd561ee16c2f7cf5afdaa7be/third_party/WebKit/Source/core/loader/NavigationScheduler.cpp
[modify] https://crrev.com/350ebf173edb4994dd561ee16c2f7cf5afdaa7be/third_party/WebKit/Source/core/loader/NavigationScheduler.h

Project Member

Comment 5 by bugdroid1@chromium.org, Nov 25 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/387c97d5cf93a15e1b547bf9f96c8c441fe9d035

commit 387c97d5cf93a15e1b547bf9f96c8c441fe9d035
Author: nhiroki <nhiroki@chromium.org>
Date: Fri Nov 25 03:03:08 2016

Scheduler: Deprecate CancellableTaskFactory in favor of WebTaskWebTaskRunner::postCancellableTask (3)

This CL completely removes CancellableTaskFactory.

BUG= 665285 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2514733002
Cr-Commit-Position: refs/heads/master@{#434428}

[modify] https://crrev.com/387c97d5cf93a15e1b547bf9f96c8c441fe9d035/third_party/WebKit/Source/modules/webgl/WebGLQuery.cpp
[modify] https://crrev.com/387c97d5cf93a15e1b547bf9f96c8c441fe9d035/third_party/WebKit/Source/modules/webgl/WebGLQuery.h
[modify] https://crrev.com/387c97d5cf93a15e1b547bf9f96c8c441fe9d035/third_party/WebKit/Source/modules/webgl/WebGLTimerQueryEXT.cpp
[modify] https://crrev.com/387c97d5cf93a15e1b547bf9f96c8c441fe9d035/third_party/WebKit/Source/modules/webgl/WebGLTimerQueryEXT.h
[modify] https://crrev.com/387c97d5cf93a15e1b547bf9f96c8c441fe9d035/third_party/WebKit/Source/platform/BUILD.gn
[modify] https://crrev.com/387c97d5cf93a15e1b547bf9f96c8c441fe9d035/third_party/WebKit/Source/platform/mac/ScrollAnimatorMac.h
[modify] https://crrev.com/387c97d5cf93a15e1b547bf9f96c8c441fe9d035/third_party/WebKit/Source/platform/mac/ScrollAnimatorMac.mm
[delete] https://crrev.com/14076c954628a8dc4bdefbd080cb80851d43d4ac/third_party/WebKit/Source/platform/scheduler/CancellableTaskFactory.cpp
[delete] https://crrev.com/14076c954628a8dc4bdefbd080cb80851d43d4ac/third_party/WebKit/Source/platform/scheduler/CancellableTaskFactory.h
[delete] https://crrev.com/14076c954628a8dc4bdefbd080cb80851d43d4ac/third_party/WebKit/Source/platform/scheduler/CancellableTaskFactoryTest.cpp
[modify] https://crrev.com/387c97d5cf93a15e1b547bf9f96c8c441fe9d035/third_party/WebKit/Source/web/InspectorEmulationAgent.cpp
[modify] https://crrev.com/387c97d5cf93a15e1b547bf9f96c8c441fe9d035/third_party/WebKit/Source/web/InspectorEmulationAgent.h

Status: Fixed (was: Started)
CancellableTaskFactory is gone.

Sign in to add a comment